do not include source parameter when removing a chocolatey package and ensure source is used on all functional testsno_web

1 files changed, 4 insertions, 3 deletions

diff --git a/lib/chef/provider/package/chocolatey.rb b/lib/chef/provider/package/chocolatey.rb
index 14613b0218..e111beb9b5 100644
--- a/lib/chef/provider/package/chocolatey.rb
+++ b/lib/chef/provider/package/chocolatey.rb
@@ -126,7 +126,7 @@ EOS
         # @param names [Array<String>] array of package names to install
         # @param versions [Array<String>] array of versions to install
         def remove_package(names, versions)
-          choco_command("uninstall -y", cmd_args, *names)
+          choco_command("uninstall -y", cmd_args(include_source: false), *names)
         end
 
         # Support :uninstall as an action in order for users to easily convert
@@ -206,10 +206,11 @@ EOS
 
         # Helper to construct optional args out of new_resource
         #
+        # @param include_source [Boolean] should the source parameter be added
         # @return [String] options from new_resource or empty string
-        def cmd_args
+        def cmd_args(include_source: true)
           cmd_args = [ new_resource.options ]
-          cmd_args.push( "-source #{new_resource.source}" ) if new_resource.source
+          cmd_args.push( "-source #{new_resource.source}" ) if new_resource.source && include_source
           args_to_string(*cmd_args)
         end