summaryrefslogtreecommitdiff
path: root/lib/chef/resource/mount.rb
diff options
context:
space:
mode:
authorLamont Granquist <lamont@scriptkiddie.org>2017-03-06 19:06:23 -0800
committerLamont Granquist <lamont@scriptkiddie.org>2017-03-06 19:06:23 -0800
commit3e9b626b750fa7fd91c5cdad169992a606120d7b (patch)
tree5eb550341009b8c5ec43c2680f5d52773a8c8db5 /lib/chef/resource/mount.rb
parent29c39b56764a52945609b0eeb0f6068da6ed0041 (diff)
downloadchef-3e9b626b750fa7fd91c5cdad169992a606120d7b.tar.gz
remove most of supports API
still there on service (where it makes some sense) also still on mount (because i have no idea if that is actively being used or if it makes any sense at all). converts it to a property on mount + service as well. also removed setting it as an array -- did we ever document that and/or does anyone use it? i'm not religiously against that way of setting it, but if nobody ever used it i'd rather remove the YAGNI. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Diffstat (limited to 'lib/chef/resource/mount.rb')
-rw-r--r--lib/chef/resource/mount.rb16
1 files changed, 4 insertions, 12 deletions
diff --git a/lib/chef/resource/mount.rb b/lib/chef/resource/mount.rb
index 3e35325246..32ffee931b 100644
--- a/lib/chef/resource/mount.rb
+++ b/lib/chef/resource/mount.rb
@@ -1,7 +1,7 @@
#
# Author:: Joshua Timberman (<joshua@chef.io>)
# Author:: Tyler Cloke (<tyler@chef.io>)
-# Copyright:: Copyright 2009-2016, Chef Software Inc.
+# Copyright:: Copyright 2009-2017, Chef Software Inc.
# License:: Apache License, Version 2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
@@ -30,6 +30,9 @@ class Chef
default_action :mount
allowed_actions :mount, :umount, :unmount, :remount, :enable, :disable
+ # this is a poor API please do not re-use this pattern
+ property :supports, Hash, default: { remount: false }
+
def initialize(name, run_context = nil)
super
@mount_point = name
@@ -42,7 +45,6 @@ class Chef
@pass = 2
@mounted = false
@enabled = false
- @supports = { :remount => false }
@username = nil
@password = nil
@domain = nil
@@ -140,16 +142,6 @@ class Chef
)
end
- def supports(args = {})
- if args.is_a? Array
- args.each { |arg| @supports[arg] = true }
- elsif args.any?
- @supports = args
- else
- @supports
- end
- end
-
def username(arg = nil)
set_or_return(
:username,