diff options
| author | Lamont Granquist <lamont@scriptkiddie.org> | 2017-02-13 09:52:10 -0800 |
|---|---|---|
| committer | Lamont Granquist <lamont@scriptkiddie.org> | 2017-02-13 09:52:10 -0800 |
| commit | 404a9bc88be538769c6c80b3b31f39a6582991d2 (patch) | |
| tree | 2f8795e5f64153440c22a522d669c235a627f289 /lib/chef/run_list | |
| parent | b949a48acc21d4b64869bd7b834708d5232b1f2a (diff) | |
| download | chef-404a9bc88be538769c6c80b3b31f39a6582991d2.tar.gz | |
fix specs: RedundantReturn, RedundantSelf, RedundantBegin
department of redundancy department
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Diffstat (limited to 'lib/chef/run_list')
| -rw-r--r-- | lib/chef/run_list/run_list_item.rb | 2 | ||||
| -rw-r--r-- | lib/chef/run_list/versioned_recipe_list.rb | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/lib/chef/run_list/run_list_item.rb b/lib/chef/run_list/run_list_item.rb index 0abfb106ff..1c75907dd8 100644 --- a/lib/chef/run_list/run_list_item.rb +++ b/lib/chef/run_list/run_list_item.rb @@ -81,7 +81,7 @@ class Chef def ==(other) if other.kind_of?(String) - self.to_s == other.to_s + to_s == other.to_s else other.respond_to?(:type) && other.respond_to?(:name) && other.respond_to?(:version) && other.type == @type && other.name == @name && other.version == @version end diff --git a/lib/chef/run_list/versioned_recipe_list.rb b/lib/chef/run_list/versioned_recipe_list.rb index 7845568aaa..ccd7351eeb 100644 --- a/lib/chef/run_list/versioned_recipe_list.rb +++ b/lib/chef/run_list/versioned_recipe_list.rb @@ -36,17 +36,17 @@ class Chef end end @versions[name] = version if version - self << name unless self.include?(name) + self << name unless include?(name) end def with_versions - self.map { |recipe_name| { :name => recipe_name, :version => @versions[recipe_name] } } + map { |recipe_name| { :name => recipe_name, :version => @versions[recipe_name] } } end # Return an Array of Hashes, each of the form: # {:name => RECIPE_NAME, :version_constraint => Chef::VersionConstraint } def with_version_constraints - self.map do |recipe_name| + map do |recipe_name| constraint = Chef::VersionConstraint.new(@versions[recipe_name]) { :name => recipe_name, :version_constraint => constraint } end @@ -55,7 +55,7 @@ class Chef # Return an Array of Strings, each of the form: # "NAME@VERSION" def with_version_constraints_strings - self.map do |recipe_name| + map do |recipe_name| if @versions[recipe_name] "#{recipe_name}@#{@versions[recipe_name]}" else @@ -69,7 +69,7 @@ class Chef # # @return [Array] Array of strings with fully-qualified recipe names def with_fully_qualified_names_and_version_constraints - self.map do |recipe_name| + map do |recipe_name| qualified_recipe = if recipe_name.include?("::") recipe_name else @@ -89,7 +89,7 @@ class Chef # # @return [Array] Array of strings with fully-qualified and unexpanded recipe names def with_duplicate_names - self.map do |recipe_name| + map do |recipe_name| if recipe_name.include?("::") recipe_name else |