Merge pull request #5381 from MsysTechnologiesllc/nim/double_quotes_parsing_error

Handling double quotes in powershell_out

1 files changed, 10 insertions, 2 deletions

diff --git a/lib/chef/mixin/powershell_out.rb b/lib/chef/mixin/powershell_out.rb
index 74de85f86f..3e1f588319 100644
--- a/lib/chef/mixin/powershell_out.rb
+++ b/lib/chef/mixin/powershell_out.rb
@@ -34,7 +34,14 @@ class Chef
         script = command_args.first
         options = command_args.last.is_a?(Hash) ? command_args.last : nil
 
-        run_command_with_os_architecture(script, options)
+        result = run_command_with_os_architecture(script, options)
+
+        if result.stderr.include? "A positional parameter cannot be found that accepts argument"
+          raise Mixlib::ShellOut::ShellCommandFailed, "Please use single escape for special characters in powershell_out. \n #{result.stderr}"
+        elsif result.stderr != ""
+          raise Mixlib::ShellOut::ShellCommandFailed, result.stderr
+        end
+        result
       end
 
       # Run a command under powershell with the same API as shell_out!
@@ -91,7 +98,8 @@ class Chef
           "-InputFormat None",
         ]
 
-        "powershell.exe #{flags.join(' ')} -Command \"#{script}\""
+        # without gsub user has to add double escape for double quotes in the recipe
+        "powershell.exe #{flags.join(' ')} -Command \"#{script.gsub('"', '\"')}\""
       end
     end
   end