Remove deprecations for Cookbook Version HTTP resource behaviors

We cannot determine the best way to organize various CookbookManifest
formats ahead of time, so we make the CookbookManifest API private, and
un-deprecate the methods in CookbookVersion that delegate to
CookbookManifest. We'll re-deprecate these when we have a stable public
API for CookbookManifest behaviors.

1 files changed, 15 insertions, 11 deletions

diff --git a/spec/unit/cookbook_version_spec.rb b/spec/unit/cookbook_version_spec.rb
index d806153bc9..440dd9da6c 100644
--- a/spec/unit/cookbook_version_spec.rb
+++ b/spec/unit/cookbook_version_spec.rb
@@ -306,20 +306,24 @@ describe Chef::CookbookVersion do
 
     subject(:cbv) { Chef::CookbookVersion.new("version validation", '/tmp/blah') }
 
-    it "errors on #save_url" do
-      expect { cbv.save_url }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
-    end
+    describe "HTTP Resource behaviors", pending: "will be deprected when CookbookManifest API is stablized" do
 
-    it "errors on #force_save_url" do
-      expect { cbv.force_save_url }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
-    end
+      it "errors on #save_url" do
+        expect { cbv.save_url }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
+      end
 
-    it "errors on #to_hash" do
-      expect { cbv.to_hash }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
-    end
+      it "errors on #force_save_url" do
+        expect { cbv.force_save_url }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
+      end
+
+      it "errors on #to_hash" do
+        expect { cbv.to_hash }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
+      end
+
+      it "errors on #to_json" do
+        expect { cbv.to_json }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
+      end
 
-    it "errors on #to_json" do
-      expect { cbv.to_json }.to raise_error(Chef::Exceptions::DeprecatedFeatureError)
     end
 
     it "errors on #status and #status=" do