diff options
author | Lamont Granquist <lamont@scriptkiddie.org> | 2016-09-15 11:52:15 -0700 |
---|---|---|
committer | Lamont Granquist <lamont@scriptkiddie.org> | 2016-09-15 11:52:15 -0700 |
commit | 0b86d8b497a51401c4588e253fb957f2ccc20343 (patch) | |
tree | c8500d62d6a845c5adca71255fa57274eb0d10fe /spec/unit/file_content_management | |
parent | 41d99f6d8d8de416f9d5166e8e1f139ae768f134 (diff) | |
download | chef-0b86d8b497a51401c4588e253fb957f2ccc20343.tar.gz |
add tests and tweak code
also fixes the fact that we've been using @new_resource.name instead of
@new_resource.path all along which was never what was intended.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Diffstat (limited to 'spec/unit/file_content_management')
-rw-r--r-- | spec/unit/file_content_management/tempfile_spec.rb | 43 |
1 files changed, 34 insertions, 9 deletions
diff --git a/spec/unit/file_content_management/tempfile_spec.rb b/spec/unit/file_content_management/tempfile_spec.rb index 4b27fc8cc9..3dd90682a8 100644 --- a/spec/unit/file_content_management/tempfile_spec.rb +++ b/spec/unit/file_content_management/tempfile_spec.rb @@ -19,38 +19,54 @@ require "spec_helper" describe Chef::FileContentManagement::Tempfile do - let(:resource) do - r = Chef::Resource::File.new("new_file") - r.path "/foo/bar/new_file" - r - end - subject { described_class.new(resource) } + def tempfile_object_for_path(path) + r = Chef::Resource::File.new("decorative name that should not matter") + r.path path + Chef::FileContentManagement::Tempfile.new(r) + end describe "#tempfile_basename" do it "should return a dotfile", :unix_only do + subject = tempfile_object_for_path("/foo/bar/new_file") expect(subject.send(:tempfile_basename)).to eql(".chef-new_file") end it "should return a file", :windows_only do + subject = tempfile_object_for_path("/foo/bar/new_file") expect(subject.send(:tempfile_basename)).to eql("chef-new_file") end + + it "should strip the extension" do + subject = tempfile_object_for_path("/foo/bar/new_file.html.erb") + expect(subject.send(:tempfile_basename)).to eql(".chef-new_file") + end + end + + describe "#tempfile_extension" do + it "should preserve the file extension" do + subject = tempfile_object_for_path("/foo/bar/new_file.html.erb") + expect(subject.send(:tempfile_extension)).to eql(".html.erb") + end end describe "#tempfile_dirnames" do it "should select a temp dir" do + subject = tempfile_object_for_path("/foo/bar/new_file") Chef::Config[:file_staging_uses_destdir] = false expect(Dir).to receive(:tmpdir).and_return("/tmp/dir") expect(subject.send(:tempfile_dirnames)).to eql(%w{ /tmp/dir }) end it "should select the destdir" do + subject = tempfile_object_for_path("/foo/bar/new_file") Chef::Config[:file_staging_uses_destdir] = true expect(subject.send(:tempfile_dirnames)).to eql(%w{ /foo/bar }) end it "should select the destdir and a temp dir" do + subject = tempfile_object_for_path("/foo/bar/new_file") Chef::Config[:file_staging_uses_destdir] = :auto expect(Dir).to receive(:tmpdir).and_return("/tmp/dir") expect(subject.send(:tempfile_dirnames)).to eql(%w{ /foo/bar /tmp/dir }) @@ -67,18 +83,27 @@ describe Chef::FileContentManagement::Tempfile do end it "should create a temporary file" do + subject = tempfile_object_for_path("/foo/bar/new_file") expect(subject.send(:tempfile_open)).to be_a(Tempfile) end + it "should preserve the extention in the tempfile path" do + subject = tempfile_object_for_path("/foo/bar/new_file.html.erb") + tempfile = subject.send(:tempfile_open) + expect(tempfile.path).to match(/chef-new_file.*\.html\.erb$/) + end + it "should pick the destdir preferrentially" do - expect(Tempfile).to receive(:open).with(tempname, "/foo/bar").and_return(tempfile) + subject = tempfile_object_for_path("/foo/bar/new_file") + expect(Tempfile).to receive(:open).with([tempname, ""], "/foo/bar").and_return(tempfile) subject.send(:tempfile_open) end it "should use ENV['TMP'] otherwise" do + subject = tempfile_object_for_path("/foo/bar/new_file") expect(Dir).to receive(:tmpdir).and_return("/tmp/dir") - expect(Tempfile).to receive(:open).with(tempname, "/foo/bar").and_raise(SystemCallError, "foo") - expect(Tempfile).to receive(:open).with(tempname, "/tmp/dir").and_return(tempfile) + expect(Tempfile).to receive(:open).with([tempname, ""], "/foo/bar").and_raise(SystemCallError, "foo") + expect(Tempfile).to receive(:open).with([tempname, ""], "/tmp/dir").and_return(tempfile) subject.send(:tempfile_open) end end |