Prevent indentation from being set to negative numbers

If we don't defensively program here, the result is terrible.  All that
gets raised is "negative argument" from deep within the formatter and
from then on the formatter is broken.  It will continue to raise errors
from events called from inside the Chef::Client exception handler and
you're gonna have a bad time.

1 files changed, 48 insertions, 0 deletions

diff --git a/spec/unit/formatters/base_spec.rb b/spec/unit/formatters/base_spec.rb
new file mode 100644
index 0000000000..6a843ea775
--- /dev/null
+++ b/spec/unit/formatters/base_spec.rb
@@ -0,0 +1,48 @@
+#
+# Author:: Lamont Granquist (<lamont@getchef.com>)
+#
+# Copyright:: Copyright (c) 2012 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Formatters::Base do
+  let(:out) { double("out") }
+  let(:err) { double("err") }
+  let(:formatter) { Chef::Formatters::Base.new(out, err) }
+
+  it "starts with an indentation of zero" do
+    expect(formatter.output.indent).to eql(0)
+  end
+
+  it "increments it to two correctly" do
+    formatter.indent_by(2)
+    expect(formatter.output.indent).to eql(2)
+  end
+
+  it "increments it and then decrements it corectly" do
+    formatter.indent_by(2)
+    formatter.indent_by(-2)
+    expect(formatter.output.indent).to eql(0)
+  end
+
+  it "does not allow negative indentation" do
+    formatter.indent_by(-2)
+    expect(formatter.output.indent).to eql(0)
+  end
+end
+
+