[CHEF-4117] fix resource attempting to remove constants it doesn't have

Module.const_defined?() needs to be given an optional second argument to
disable constant lookups on ancestor classes. Otherwise LWRP creation
may attempt to remove a constant that does not exist.

1 files changed, 8 insertions, 0 deletions

diff --git a/spec/unit/lwrp_spec.rb b/spec/unit/lwrp_spec.rb
index 3e807bc06c..19d3504f3c 100644
--- a/spec/unit/lwrp_spec.rb
+++ b/spec/unit/lwrp_spec.rb
@@ -18,6 +18,8 @@
 
 require 'spec_helper'
 
+module LwrpConstScopingConflict
+end
 
 describe "LWRP" do
   before do
@@ -72,6 +74,12 @@ describe "LWRP" do
       Chef::Resource.resource_classes.should_not include(first_lwr_foo_class)
     end
 
+    it "does not attempt to remove classes from higher up namespaces [CHEF-4117]" do
+      conflicting_lwrp_file = File.expand_path( "lwrp_const_scoping/resources/conflict.rb", CHEF_SPEC_DATA)
+      # The test is that this should not raise an error:
+      Chef::Resource::LWRPBase.build_from_file("lwrp_const_scoping", conflicting_lwrp_file, nil)
+    end
+
   end
 
   describe "Lightweight Chef::Resource" do