diff options
author | Tim Smith <tsmith84@gmail.com> | 2020-04-17 16:32:46 -0700 |
---|---|---|
committer | Tim Smith <tsmith84@gmail.com> | 2020-04-17 16:43:28 -0700 |
commit | 0cf9f8817e5b493cf93949b69a580dd45b39e021 (patch) | |
tree | 9dc9df6e3b2ef017b70153fc8031de5c8bfc3d7d /spec/unit/provider | |
parent | d380678cb616e55682a3ca5a61a0be340f301ca0 (diff) | |
download | chef-0cf9f8817e5b493cf93949b69a580dd45b39e021.tar.gz |
Return empty hash from brew_info and avoid a bunch of nil checksmulti_package
Signed-off-by: Tim Smith <tsmith@chef.io>
Diffstat (limited to 'spec/unit/provider')
-rw-r--r-- | spec/unit/provider/package/homebrew_spec.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/spec/unit/provider/package/homebrew_spec.rb b/spec/unit/provider/package/homebrew_spec.rb index 8e4f754d07..62d8aee6f1 100644 --- a/spec/unit/provider/package/homebrew_spec.rb +++ b/spec/unit/provider/package/homebrew_spec.rb @@ -238,9 +238,9 @@ describe Chef::Provider::Package::Homebrew do expect(provider.brew_info).to have_key("vim") end - it "returns nil if brew_cmd_output_data returned empty stdout" do + it "returns empty hash if brew_cmd_output_data returned empty stdout" do allow(provider).to receive(:brew_cmd_output).and_return("") - expect(provider.brew_info).to be_nil + expect(provider.brew_info).to eq({}) end end @@ -282,9 +282,9 @@ describe Chef::Provider::Package::Homebrew do expect(provider.available_version("openssl")).to eql("1.1.1f") end - it "returns nil if brew_info returns nil" do - allow(provider).to receive(:brew_info).and_return(nil) - expect(provider.available_version("foo")).to be_nil + it "returns nil if the package is not installed" do + allow(provider).to receive(:brew_info).and_return(brew_info_data) + expect(provider.available_version("bogus")).to be_nil end end |