Adding more unit tests to the registry_helper spec

1 files changed, 221 insertions, 6 deletions

diff --git a/spec/unit/registry_helper_spec.rb b/spec/unit/registry_helper_spec.rb
index fd42d66101..da5a542177 100644
--- a/spec/unit/registry_helper_spec.rb
+++ b/spec/unit/registry_helper_spec.rb
@@ -22,6 +22,8 @@ module Win32
   class Registry
     KEY_SET_VALUE = 0x0002
     KEY_QUERY_VALUE = 0x0001
+    KEY_WRITE = 0x00020000 | 0x0002 | 0x0004
+    KEY_READ = 0x00020000 | 0x0001 | 0x0008 | 0x0010
   end
 end
 
@@ -30,7 +32,11 @@ describe Chef::Provider::RegistryKey do
   let(:value1) { { :name => "one", :type => :string, :data => "1" } }
   #let(:value2) { { :name => "two", :type => :string, :data => "2" } }
   let(:key_path) { 'HKCU\Software\OpscodeNumbers' }
-  let(:key1) { 'Software\OpscodeNumbers' }
+  let(:key) { 'Software\OpscodeNumbers' }
+  let(:key_parent) { 'Software' }
+  let(:key_to_delete) { 'OpscodeNumbers' }
+  let(:sub_key) {'OpscodePrimes'}
+  let(:missing_key_path) {'HKCU\Software'}
 
   before(:each) do
     Chef::Win32::Registry.any_instance.stub(:machine_architecture).and_return(:x86_64)
@@ -41,7 +47,7 @@ describe Chef::Provider::RegistryKey do
     it "does nothing if key and hive and value exist" do
       @registry.should_receive(:key_exists!).with(key_path).and_return(true)
       @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
-      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key1])
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
       @registry.should_receive(:value_exists?).with(key_path, value1).and_return(true)
       @registry.should_receive(:data_exists?).with(key_path, value1).and_return(true)
       @registry.set_value(key_path, value1)
@@ -50,11 +56,11 @@ describe Chef::Provider::RegistryKey do
     it "updates value if key and hive and value exist, but data is different" do
       @registry.should_receive(:key_exists!).with(key_path).and_return(true)
       @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
-      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key1])
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
       @registry.should_receive(:value_exists?).with(key_path, value1).and_return(true)
       @registry.should_receive(:data_exists?).with(key_path, value1).and_return(false)
       @reg_mock = mock("reg")
-      @hive_mock.should_receive(:open).with(key1, ::Win32::Registry::KEY_SET_VALUE | ::Win32::Registry::KEY_QUERY_VALUE | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_SET_VALUE | ::Win32::Registry::KEY_QUERY_VALUE | @registry.registry_system_architecture).and_yield(@reg_mock)
       @registry.should_receive(:get_type_from_name).with(:string).and_return(1)
       @reg_mock.should_receive(:write).with("one", 1, "1")
       @registry.set_value(key_path, value1)
@@ -63,10 +69,10 @@ describe Chef::Provider::RegistryKey do
     it "creates value if the key exists and the value does not exist" do
       @registry.should_receive(:key_exists!).with(key_path).and_return(true)
       @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
-      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key1])
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
       @registry.should_receive(:value_exists?).with(key_path, value1).and_return(false)
       @reg_mock = mock("reg")
-      @hive_mock.should_receive(:open).with(key1, ::Win32::Registry::KEY_SET_VALUE | ::Win32::Registry::KEY_QUERY_VALUE | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_SET_VALUE | ::Win32::Registry::KEY_QUERY_VALUE | @registry.registry_system_architecture).and_yield(@reg_mock)
       @registry.should_receive(:get_type_from_name).with(:string).and_return(1)
       @reg_mock.should_receive(:write).with("one", 1, "1")
       @registry.set_value(key_path, value1)
@@ -78,4 +84,213 @@ describe Chef::Provider::RegistryKey do
     end
   end
 
+  describe "delete_value" do
+    it "deletes value if value exists" do
+      @registry.should_receive(:value_exists?).with(key_path, value1).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @reg_mock = mock("reg")
+      @hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_SET_VALUE | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @reg_mock.should_receive(:delete_value).with("one")
+      @registry.delete_value(key_path, value1)
+    end
+
+    #  it "raises an exception if the key does not exist" do
+    #    @registry.should_receive(:value_exists?).with(key_path, value1).and_return(true)
+    #    @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+    #    @registry.should_receive(:get_hive_and_key).with(key_path).and_raise(Chef::Exceptions::Win32RegKeyMissing)
+    #    @reg_mock = mock("reg")
+    #    #@hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_SET_VALUE | @registry.registry_system_architecture).and_yield(@reg_mock)
+    #    #@reg_mock.should_receive(:delete_value).with("one")
+    #    @registry.delete_value(key_path, value1)
+    #  end
+
+    it "does nothing if the value does not exist" do
+      @registry.should_receive(:value_exists?).with(key_path, value1).and_return(false)
+      @registry.delete_value(key_path, value1)
+    end
+  end
+
+  describe "create_key" do
+    it "creates key if intermediate keys are missing and recursive is set to true" do
+      @registry.should_receive(:keys_missing?).with(key_path).and_return(true)
+      @registry.should_receive(:create_missing).with(key_path)
+      @registry.should_receive(:key_exists?).with(key_path).and_return(false)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @hive_mock.should_receive(:create).with(key, ::Win32::Registry::KEY_WRITE | @registry.registry_system_architecture)
+      @registry.create_key(key_path, true)
+    end
+
+    it "raises an exception if intermediate keys are missing and recursive is set to false" do
+      @registry.should_receive(:keys_missing?).with(key_path).and_return(true)
+      lambda{@registry.create_key(key_path, false)}.should raise_error(Chef::Exceptions::Win32RegNoRecursive)
+    end
+
+    it "does nothing if the key exists" do
+      @registry.should_receive(:keys_missing?).with(key_path).and_return(true)
+      @registry.should_receive(:create_missing).with(key_path)
+      @registry.should_receive(:key_exists?).with(key_path).and_return(true)
+      @registry.create_key(key_path, true)
+    end
+
+    it "create key if intermediate keys not missing and recursive is set to false" do
+      @registry.should_receive(:keys_missing?).with(key_path).and_return(false)
+      @registry.should_receive(:key_exists?).with(key_path).and_return(false)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @hive_mock.should_receive(:create).with(key, ::Win32::Registry::KEY_WRITE | @registry.registry_system_architecture)
+      @registry.create_key(key_path, false)
+    end
+
+    it "create key if intermediate keys not missing and recursive is set to true" do
+      @registry.should_receive(:keys_missing?).with(key_path).and_return(false)
+      @registry.should_receive(:key_exists?).with(key_path).and_return(false)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @hive_mock.should_receive(:create).with(key, ::Win32::Registry::KEY_WRITE | @registry.registry_system_architecture)
+      @registry.create_key(key_path, true)
+    end
+  end
+
+  describe "delete_key" do
+    it "deletes key if it has subkeys and recursive is set to true" do
+      @registry.should_receive(:key_exists?).with(key_path).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @registry.should_receive(:has_subkeys?).with(key_path).and_return(true)
+      @reg_mock = mock("reg")
+      @hive_mock.should_receive(:open).with(key_parent, ::Win32::Registry::KEY_WRITE | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @reg_mock.should_receive(:delete_key).with(key_to_delete, true)
+      @registry.delete_key(key_path, true)
+    end
+
+    it "raises an exception if it has subkeys but recursive is set to false" do
+      @registry.should_receive(:key_exists?).with(key_path).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @registry.should_receive(:has_subkeys?).with(key_path).and_return(true)
+      lambda{@registry.delete_key(key_path, false)}.should raise_error(Chef::Exceptions::Win32RegNoRecursive)
+    end
+
+    it "deletes key if the key exists and has no subkeys" do
+      @registry.should_receive(:key_exists?).with(key_path).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @registry.should_receive(:has_subkeys?).with(key_path).and_return(false)
+      @reg_mock = mock("reg")
+      @hive_mock.should_receive(:open).with(key_parent, ::Win32::Registry::KEY_WRITE | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @reg_mock.should_receive(:delete_key).with(key_to_delete)
+      @registry.delete_key(key_path, true)
+    end
+  end
+
+  # describe "key_exists?" do
+  #   it "returns true if key_exists" do
+  #     @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+  #     @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+  #     @hive_mock.should_receive(:open).with(key_parent, ::Win32::Registry::KEY_WRITE | @registry.registry_system_architecture).and_yield(@reg_mock)
+  #     @registry.key_exists?(key_path)
+  #   end
+
+  #   it "returns false if key does not exist" do
+
+  #   end
+  # end
+
+  describe "key_exists!" do
+    it "throws an exception if the key_parent does not exist" do
+      @registry.should_receive(:key_exists?).with(key_path).and_return(false)
+      lambda{@registry.key_exists!(key_path)}.should raise_error(Chef::Exceptions::Win32RegKeyMissing)
+    end
+  end
+
+  describe "get_subkeys" do
+    it "returns the subkeys if they exist" do
+      @registry.should_receive(:key_exists!).with(key_path).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @reg_mock = mock("reg")
+      @hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_READ | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @reg_mock.should_receive(:each_key).and_yield(sub_key)
+      @registry.get_subkeys(key_path)
+    end
+  end
+
+  describe "value_exists!" do
+    it "does nothing if the value exists" do
+      @registry.should_receive(:value_exists?).with(key_path, value1).and_return(true)
+      @registry.value_exists!(key_path, value1)
+    end
+
+    it "throws an exception if the value does not exist" do
+      @registry.should_receive(:value_exists?).with(key_path, value1).and_return(false)
+      lambda{@registry.value_exists!(key_path, value1)}.should raise_error(Chef::Exceptions::Win32RegValueMissing)
+    end
+  end
+
+  describe "data_exists!" do
+    it "does nothing if the data exists" do
+      @registry.should_receive(:data_exists?).with(key_path, value1).and_return(true)
+      @registry.data_exists!(key_path, value1)
+    end
+
+    it "throws an exception if the data does not exist" do
+      @registry.should_receive(:data_exists?).with(key_path, value1).and_return(false)
+      lambda{@registry.data_exists!(key_path, value1)}.should raise_error(Chef::Exceptions::Win32RegDataMissing)
+    end
+  end
+
+  describe "type_matches?" do
+    it "returns true if type matches" do
+      @registry.should_receive(:value_exists!).with(key_path, value1).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @reg_mock = mock("reg")
+      @hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_READ | @registry.registry_system_architecture).and_yield(@reg_mock)
+      @registry.should_receive(:get_type_from_name).with(:string).and_return(1)
+      @reg_mock.should_receive(:each).and_yield("one", 1)
+      @registry.type_matches?(key_path, value1).should == true
+    end
+
+    it "returns false if type does not match" do
+      @registry.should_receive(:value_exists!).with(key_path, value1).and_return(true)
+      @hive_mock = mock("::Win32::Registry::HKEY_CURRENT_USER")
+      @registry.should_receive(:get_hive_and_key).with(key_path).and_return([@hive_mock, key])
+      @reg_mock = mock("reg")
+      @hive_mock.should_receive(:open).with(key, ::Win32::Registry::KEY_READ | @registry.registry_system_architecture).and_yield(@reg_mock)
+     # @registry.should_receive(:get_type_from_name).with(:string).and_return(2)
+      @reg_mock.should_receive(:each).and_yield("two", 2)
+      @registry.type_matches?(key_path, value1).should == false
+    end
+
+    it "throws an exception if value does not exist" do
+      @registry.should_receive(:value_exists?).with(key_path, value1).and_return(false)
+      lambda{@registry.type_matches?(key_path, value1)}.should raise_error(Chef::Exceptions::Win32RegValueMissing)
+    end
+  end
+
+  describe "type_matches!" do
+    it "does nothing if the type_matches" do
+      @registry.should_receive(:type_matches?).with(key_path, value1).and_return(true)
+      @registry.type_matches!(key_path, value1)
+    end
+
+    it "throws an exception if the type does not match" do
+      @registry.should_receive(:type_matches?).with(key_path, value1).and_return(false)
+      lambda{@registry.type_matches!(key_path, value1)}.should raise_error(Chef::Exceptions::Win32RegTypesMismatch)
+    end
+  end
+
+  describe "keys_missing?" do
+    it "returns true if the keys are missing" do
+      @registry.should_receive(:key_exists?).with(missing_key_path).and_return(false)
+      @registry.keys_missing?(key_path).should == true
+    end
+
+    it "returns false if no keys in the path are missing" do
+      @registry.should_receive(:key_exists?).with(missing_key_path).and_return(true)
+      @registry.keys_missing?(key_path).should == false
+    end
+  end
 end