Raise an error when including a recipe from an unreachable cookbook

Fixes CHEF-4367.

When attempting to load a recipe belonging to a cookbook that is not in
the run_list or any dependencies of cookbooks in the run_list, chef
will now produce an error like this:

    Chef::Exceptions::MissingCookbookDependency
    -------------------------------------------
    Recipe `ancient::aliens` is not in the run_list, and cookbook 'ancient'
    is not a dependency of any cookbook in the run_list.  To load thisrecipe,
    first add a dependency on cookbook 'ancient' in the cookbook you're
    including it from in that cookbook's metadata.

This error will occur when chef-solo users use `include_recipe` without
specifying the dependency in metadata; prior to this patch, chef would
typically fail reading an undefined attribute, which commonly would
result in a NoMethodError for nil.

1 files changed, 12 insertions, 0 deletions

diff --git a/spec/unit/run_context/cookbook_compiler_spec.rb b/spec/unit/run_context/cookbook_compiler_spec.rb
index 52f4772206..5c50c3dd4b 100644
--- a/spec/unit/run_context/cookbook_compiler_spec.rb
+++ b/spec/unit/run_context/cookbook_compiler_spec.rb
@@ -170,5 +170,17 @@ describe Chef::RunContext::CookbookCompiler do
                                          :"circular-dep1",
                                          :"test-with-circular-deps"]
     end
+
+    it "determines if a cookbook is in the list of cookbooks reachable by dependency" do
+      node.run_list("test-with-deps::default", "test-with-deps::server")
+      compiler.cookbook_order.should == [:dependency1, :dependency2, :"test-with-deps"]
+      compiler.unreachable_cookbook?(:dependency1).should be_false
+      compiler.unreachable_cookbook?(:dependency2).should be_false
+      compiler.unreachable_cookbook?(:'test-with-deps').should be_false
+      compiler.unreachable_cookbook?(:'circular-dep1').should be_true
+      compiler.unreachable_cookbook?(:'circular-dep2').should be_true
+    end
+
+
   end
 end