Merge pull request #848 from onddo/CHEF-4298

[CHEF-4298] dependencies in metadata.rb require a space

1 files changed, 14 insertions, 2 deletions

diff --git a/spec/unit/version_constraint_spec.rb b/spec/unit/version_constraint_spec.rb
index a49b082d9d..4184689e2b 100644
--- a/spec/unit/version_constraint_spec.rb
+++ b/spec/unit/version_constraint_spec.rb
@@ -20,8 +20,8 @@ require 'chef/version_constraint'
 
 describe Chef::VersionConstraint do
   describe "validation" do
-    bad_version = ["> >", ">= 1.2.z", "> 1.2.3 < 5.0", "> 1.2.3, < 5.0"]
-    bad_op = ["<3.0.1", ">$ 1.2.3", "! 3.4"]
+    bad_version = [">= 1.2.z", "> 1.2.3 < 5.0", "> 1.2.3, < 5.0"]
+    bad_op = ["> >", ">$ 1.2.3", "! 3.4"]
     o_error = Chef::Exceptions::InvalidVersionConstraint
     v_error = Chef::Exceptions::InvalidCookbookVersion
     bad_version.each do |s|
@@ -64,6 +64,18 @@ describe Chef::VersionConstraint do
     vc.version.should be_an_instance_of(Chef::Version)
   end
 
+  it "should allow ops without space separator" do
+    Chef::VersionConstraint.new("=1.2.3").should eql(Chef::VersionConstraint.new("= 1.2.3"))
+    Chef::VersionConstraint.new(">1.2.3").should eql(Chef::VersionConstraint.new("> 1.2.3"))
+    Chef::VersionConstraint.new("<1.2.3").should eql(Chef::VersionConstraint.new("< 1.2.3"))
+    Chef::VersionConstraint.new(">=1.2.3").should eql(Chef::VersionConstraint.new(">= 1.2.3"))
+    Chef::VersionConstraint.new("<=1.2.3").should eql(Chef::VersionConstraint.new("<= 1.2.3"))
+  end
+
+  it "should allow ops with multiple spaces" do
+    Chef::VersionConstraint.new("=  1.2.3").should eql(Chef::VersionConstraint.new("= 1.2.3"))
+  end
+
   describe "include?" do
     describe "handles various input data types" do
       before do