diff options
author | Jay Mundrawala <jdmundrawala@gmail.com> | 2016-01-27 18:48:44 -0800 |
---|---|---|
committer | Jay Mundrawala <jdmundrawala@gmail.com> | 2016-01-28 15:28:33 -0800 |
commit | d1f9d3fe01da4620c983ee9b74cbd973abbff418 (patch) | |
tree | ba4bfcc70dd796fce8920f42c99d8ea87162e1a6 /spec/unit | |
parent | ed44d58632c02744ce02bcc6af504e4e3c802f1f (diff) | |
download | chef-d1f9d3fe01da4620c983ee9b74cbd973abbff418.tar.gz |
Refactor chef-config fips configjdm/fips-58
This refactor allows for better mocking in the tests.
Before, when init_openssl was called, classes would
get monkey patched. While this may not cause problems
now, some day in the future, somebody would have been
like "WTF is going on".
Diffstat (limited to 'spec/unit')
-rw-r--r-- | spec/unit/application/knife_spec.rb | 8 | ||||
-rw-r--r-- | spec/unit/application_spec.rb | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/spec/unit/application/knife_spec.rb b/spec/unit/application/knife_spec.rb index c6c3c4d12c..08e058caed 100644 --- a/spec/unit/application/knife_spec.rb +++ b/spec/unit/application/knife_spec.rb @@ -93,7 +93,7 @@ describe Chef::Application::Knife do it "does not initialize fips mode when no flags are passed" do with_argv(*%w{noop knife command}) do expect(@knife).to receive(:exit).with(0) - expect(OpenSSL).not_to receive(:'fips_mode=') + expect(Chef::Config).not_to receive(:enable_fips_mode) @knife.run expect(Chef::Config[:fips]).to eq(false) end @@ -102,7 +102,7 @@ describe Chef::Application::Knife do it "overwrites the Chef::Config value when passed --fips" do with_argv(*%w{noop knife command --fips}) do expect(@knife).to receive(:exit).with(0) - expect(OpenSSL).to receive(:'fips_mode=').with(true) + expect(Chef::Config).to receive(:enable_fips_mode) @knife.run expect(Chef::Config[:fips]).to eq(true) end @@ -117,7 +117,7 @@ describe Chef::Application::Knife do it "initializes fips mode when passed --fips" do with_argv(*%w{noop knife command --fips}) do expect(@knife).to receive(:exit).with(0) - expect(OpenSSL).to receive(:'fips_mode=').with(true) + expect(Chef::Config).to receive(:enable_fips_mode) @knife.run expect(Chef::Config[:fips]).to eq(true) end @@ -126,7 +126,7 @@ describe Chef::Application::Knife do it "overwrites the Chef::Config value when passed --no-fips" do with_argv(*%w{noop knife command --no-fips}) do expect(@knife).to receive(:exit).with(0) - expect(OpenSSL).not_to receive(:'fips_mode=') + expect(Chef::Config).not_to receive(:enable_fips_mode) @knife.run expect(Chef::Config[:fips]).to eq(false) end diff --git a/spec/unit/application_spec.rb b/spec/unit/application_spec.rb index 340f062564..ceff3b6eb5 100644 --- a/spec/unit/application_spec.rb +++ b/spec/unit/application_spec.rb @@ -148,7 +148,7 @@ describe Chef::Application do end it "sets openssl in fips mode" do - expect(OpenSSL).to receive(:'fips_mode=').with(true) + expect(Chef::Config).to receive(:enable_fips_mode) @app.configure_chef end end |