Use executionpolicy Bypass in powershell_script provider for PS 3.0 and later

2 files changed, 54 insertions, 12 deletions

diff --git a/spec/functional/resource/powershell_spec.rb b/spec/functional/resource/powershell_spec.rb
index b76e75782f..17ae8cbd2a 100644
--- a/spec/functional/resource/powershell_spec.rb
+++ b/spec/functional/resource/powershell_spec.rb
@@ -134,7 +134,7 @@ describe Chef::Resource::WindowsScript::PowershellScript, :windows_only do
     it "returns 1 if the script provided to the code attribute is not syntactically correct" do
       resource.code('if({)')
       resource.returns(1)
-      resource.run_action(:run)
+      expect { resource.run_action(:run) }.not_to raise_error
     end
 
     # This somewhat ambiguous case, two failures of different types,
diff --git a/spec/unit/provider/powershell_spec.rb b/spec/unit/provider/powershell_spec.rb
index 60dbcf80b0..855c18af9b 100644
--- a/spec/unit/provider/powershell_spec.rb
+++ b/spec/unit/provider/powershell_spec.rb
@@ -19,20 +19,62 @@
 require 'spec_helper'
 describe Chef::Provider::PowershellScript, "action_run" do
 
-  before(:each) do
-    @node = Chef::Node.new
+  let(:powershell_version) { nil }
+  let(:node) {
+    node = Chef::Node.new
+    node.default["kernel"] = Hash.new
+    node.default["kernel"][:machine] = :x86_64.to_s
+    if ! powershell_version.nil?
+      node.default[:languages] = { :powershell => { :version => powershell_version } }
+    end
+    node
+  }
 
-    @node.default["kernel"] = Hash.new
-    @node.default["kernel"][:machine] = :x86_64.to_s
+  let(:provider) {
+    empty_events = Chef::EventDispatch::Dispatcher.new
+    run_context = Chef::RunContext.new(node, {}, empty_events)
+    new_resource = Chef::Resource::PowershellScript.new('run some powershell code', run_context)
+    Chef::Provider::PowershellScript.new(new_resource, run_context)
+  }
 
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::PowershellScript.new('run some powershell code', @run_context)
+  context 'when setting interpreter flags' do
+    it "should set the -File flag as the last flag" do
+      expect(provider.flags.split(' ').pop).to eq("-File")
+    end
 
-    @provider = Chef::Provider::PowershellScript.new(@new_resource, @run_context)
-  end
+    let(:execution_policy_flag) do
+      execution_policy_index = 0
+      provider_flags = provider.flags.split(' ')
+      execution_policy_specified = false
 
-  it "should set the -File flag as the last flag" do
-    expect(@provider.flags.split(' ').pop).to eq("-File")
-  end
+      provider_flags.find do | value |
+        execution_policy_index += 1
+        execution_policy_specified = value.downcase == '-ExecutionPolicy'.downcase
+      end
+
+      execution_policy = execution_policy_specified ? provider_flags[execution_policy_index] : nil
+    end
 
+    context 'when running with an unspecified PowerShell version' do
+      let(:powershell_version) { nil }
+      it "should set the -ExecutionPolicy flag to 'Unrestricted' by default" do
+        expect(execution_policy_flag.downcase).to eq('unrestricted'.downcase)
+      end
+    end
+
+    { '2.0' => 'Unrestricted',
+      '2.5' => 'Unrestricted',
+      '3.0' => 'Bypass',
+      '3.6' => 'Bypass',
+      '4.0' => 'Bypass',
+      '5.0' => 'Bypass' }.each do | version_policy |
+      let(:powershell_version) { version_policy[0].to_f }
+      context "when running PowerShell version #{version_policy[0]}" do
+        let(:powershell_version) { version_policy[0].to_f }
+        it "should set the -ExecutionPolicy flag to '#{version_policy[1]}'" do
+          expect(execution_policy_flag.downcase).to eq(version_policy[1].downcase)
+        end
+      end
+    end
+  end
 end