diff options
author | Patrick Schaumburg <pschaumburg@tecracer.de> | 2020-03-30 16:18:39 +0200 |
---|---|---|
committer | Patrick Schaumburg <pschaumburg@tecracer.de> | 2020-03-30 16:18:39 +0200 |
commit | 9a0a642fdcb32306a7e4cd0d7895b1ff116c665e (patch) | |
tree | 6e59ec04bd4f3eb59fed9a514fb14ae14528ce86 /spec | |
parent | 0bdeca2ea7d7108db6418c597f5c379da6eba7e8 (diff) | |
download | chef-9a0a642fdcb32306a7e4cd0d7895b1ff116c665e.tar.gz |
add some more tests
Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
Diffstat (limited to 'spec')
-rw-r--r-- | spec/unit/resource/windows_firewall_rule_spec.rb | 30 |
1 files changed, 23 insertions, 7 deletions
diff --git a/spec/unit/resource/windows_firewall_rule_spec.rb b/spec/unit/resource/windows_firewall_rule_spec.rb index 64a2933aad..3907a8a699 100644 --- a/spec/unit/resource/windows_firewall_rule_spec.rb +++ b/spec/unit/resource/windows_firewall_rule_spec.rb @@ -505,6 +505,10 @@ describe Chef::Resource::WindowsFirewallRule do describe "#is_set_properly?" do context "#TCP" do + it "icmp_type is nil" do + expect(provider.is_set_properly?(nil, "TCP")).to eql(false) + end + it "icmp_type is empty" do expect(provider.is_set_properly?("", "TCP")).to eql(false) end @@ -521,6 +525,14 @@ describe Chef::Resource::WindowsFirewallRule do expect(provider.is_set_properly?(123, "TCP")).to eql(false) end + it "icmp_type is 345 as String" do + expect(provider.is_set_properly?("345", "TCP")).to eql(false) + end + + it "icmp_type is 345 as Integer" do + expect(provider.is_set_properly?(345, "TCP")).to eql(false) + end + it "icmp_type is '1:3' as code pair" do expect(provider.is_set_properly?("1:3", "TCP")).to eql(false) end @@ -528,13 +540,13 @@ describe Chef::Resource::WindowsFirewallRule do it "icmp_type is '123:456' as code pair out of range" do expect(provider.is_set_properly?("123:456", "TCP")).to eql(false) end + end + context "#ICMPv6" do it "icmp_type is nil" do - expect(provider.is_set_properly?(nil, "TCP")).to eql(false) + expect(provider.is_set_properly?(nil, "ICMPv6")).to eql(false) end - end - context "#ICMPv6" do it "icmp_type is empty" do expect(provider.is_set_properly?("", "ICMPv6")).to eql(false) end @@ -551,6 +563,14 @@ describe Chef::Resource::WindowsFirewallRule do expect(provider.is_set_properly?(123, "ICMPv6")).to eql(true) end + it "icmp_type is 345 as String" do + expect(provider.is_set_properly?("345", "ICMPv6")).to eql(false) + end + + it "icmp_type is 345 as Integer" do + expect(provider.is_set_properly?(345, "ICMPv6")).to eql(false) + end + it "icmp_type is '1:3' as code pair" do expect(provider.is_set_properly?("1:3", "ICMPv6")).to eql(true) end @@ -558,10 +578,6 @@ describe Chef::Resource::WindowsFirewallRule do it "icmp_type is '123:456' as code pair out of range" do expect(provider.is_set_properly?("123:456", "ICMPv6")).to eql(false) end - - it "icmp_type is nil" do - expect(provider.is_set_properly?(nil, "ICMPv6")).to eql(false) - end end end end |