diff options
author | Lamont Granquist <lamont@scriptkiddie.org> | 2017-03-21 08:13:47 -0700 |
---|---|---|
committer | Lamont Granquist <lamont@scriptkiddie.org> | 2017-03-21 08:13:47 -0700 |
commit | a65147034050361a8b2bf80a54a2532bf9f0413d (patch) | |
tree | feb2dbd85edca4c3e1d8d1f555422ed1f7852e53 /spec | |
parent | b39d1b2937d7f6b2b974531f99b60e7b5d026fc7 (diff) | |
download | chef-a65147034050361a8b2bf80a54a2532bf9f0413d.tar.gz |
Chef-13: remove method_missing from the DSL
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Diffstat (limited to 'spec')
-rw-r--r-- | spec/integration/recipes/recipe_dsl_spec.rb | 29 | ||||
-rw-r--r-- | spec/unit/recipe_spec.rb | 4 |
2 files changed, 2 insertions, 31 deletions
diff --git a/spec/integration/recipes/recipe_dsl_spec.rb b/spec/integration/recipes/recipe_dsl_spec.rb index 27176f65d8..bc99dddaf3 100644 --- a/spec/integration/recipes/recipe_dsl_spec.rb +++ b/spec/integration/recipes/recipe_dsl_spec.rb @@ -1174,35 +1174,6 @@ describe "Recipe DSL methods" do end end - context "with provides? returning true to blarghle_blarghle_little_star and not resource_name" do - before do - temp_blarghle_blarghle_little_star = blarghle_blarghle_little_star - resource_class.define_singleton_method(:provides?) do |node, resource_name| - @called_provides = true - resource_name == temp_blarghle_blarghle_little_star - end - end - - it "my_resource does not return the resource" do - dsl_name = my_resource - expect_converge do - instance_eval("#{dsl_name} 'foo'") - end.to raise_error(Chef::Exceptions::NoSuchResourceType) - expect(resource_class.called_provides).to be_truthy - end - - it "blarghle_blarghle_little_star 'foo' returns the resource and emits a warning" do - Chef::Config[:treat_deprecation_warnings_as_errors] = false - dsl_name = blarghle_blarghle_little_star - recipe = converge do - instance_eval("#{dsl_name} 'foo'") - end - expect(recipe.logged_warnings).to include "WARN: #{resource_class}.provides? returned true when asked if it provides DSL #{dsl_name}, but provides :#{dsl_name} was never called!" - expect(BaseThingy.created_resource).to eq resource_class - expect(resource_class.called_provides).to be_truthy - end - end - context "and a provider" do let(:provider_class) do Class.new(BaseThingy::Provider) do diff --git a/spec/unit/recipe_spec.rb b/spec/unit/recipe_spec.rb index 5ee33b14dd..8e00a82e59 100644 --- a/spec/unit/recipe_spec.rb +++ b/spec/unit/recipe_spec.rb @@ -307,7 +307,7 @@ describe Chef::Recipe do it "gives a sane error message when using method_missing" do expect do recipe.no_such_resource("foo") - end.to raise_error(NoMethodError, %q{No resource or method named `no_such_resource' for `Chef::Recipe "test"'}) + end.to raise_error(NoMethodError, /undefined method `no_such_resource' for #<Chef::Recipe:.*>/) end it "gives a sane error message when using method_missing 'bare'" do @@ -316,7 +316,7 @@ describe Chef::Recipe do # Giving an argument will change this from NameError to NoMethodError no_such_resource end - end.to raise_error(NameError, %q{No resource, method, or local variable named `no_such_resource' for `Chef::Recipe "test"'}) + end.to raise_error(NameError, /undefined local variable or method `no_such_resource' for #<Chef::Recipe:.*>/) end it "gives a sane error message when using build_resource" do |