diff options
-rw-r--r-- | lib/chef/data_bag.rb | 3 | ||||
-rw-r--r-- | lib/chef/data_bag_item.rb | 3 | ||||
-rw-r--r-- | spec/unit/data_bag_item_spec.rb | 4 | ||||
-rw-r--r-- | spec/unit/data_bag_spec.rb | 2 |
4 files changed, 7 insertions, 5 deletions
diff --git a/lib/chef/data_bag.rb b/lib/chef/data_bag.rb index af0560a640..26bf49a008 100644 --- a/lib/chef/data_bag.rb +++ b/lib/chef/data_bag.rb @@ -32,7 +32,8 @@ class Chef include Chef::Mixin::FromFile include Chef::Mixin::ParamsValidate - VALID_NAME = /^[\.\-[:alnum:]_]+$/.freeze + # Regex reference: https://rubular.com/r/oIMySIO4USPm5x + VALID_NAME = /^[\-[:alnum:]_]+$/.freeze RESERVED_NAMES = /^(node|role|environment|client)$/.freeze def self.validate_name!(name) diff --git a/lib/chef/data_bag_item.rb b/lib/chef/data_bag_item.rb index 3a4adb84cc..17a105a84e 100644 --- a/lib/chef/data_bag_item.rb +++ b/lib/chef/data_bag_item.rb @@ -36,7 +36,8 @@ class Chef include Chef::Mixin::FromFile include Chef::Mixin::ParamsValidate - VALID_ID = /^[\.\-[:alnum:]_]+$/.freeze + # Regex reference: https://rubular.com/r/oIMySIO4USPm5x + VALID_ID = /^[\-[:alnum:]_]+$/.freeze def self.validate_id!(id_str) if id_str.nil? || ( id_str !~ VALID_ID ) diff --git a/spec/unit/data_bag_item_spec.rb b/spec/unit/data_bag_item_spec.rb index 61e0a80444..2487bd25d7 100644 --- a/spec/unit/data_bag_item_spec.rb +++ b/spec/unit/data_bag_item_spec.rb @@ -73,11 +73,11 @@ describe Chef::DataBagItem do end it "should accept alphanum.alphanum for the id" do - expect { data_bag_item.raw_data = { "id" => "foo.bar" } }.not_to raise_error + expect { data_bag_item.raw_data = { "id" => "foo.bar" } }.to raise_error(ArgumentError) end it "should accept .alphanum for the id" do - expect { data_bag_item.raw_data = { "id" => ".bozo" } }.not_to raise_error + expect { data_bag_item.raw_data = { "id" => ".bozo" } }.to raise_error(ArgumentError) end it "should raise an exception if the id contains anything but alphanum/-/_" do diff --git a/spec/unit/data_bag_spec.rb b/spec/unit/data_bag_spec.rb index 2a7ddddd5b..891f9c6616 100644 --- a/spec/unit/data_bag_spec.rb +++ b/spec/unit/data_bag_spec.rb @@ -49,7 +49,7 @@ describe Chef::DataBag do expect { @data_bag.name({}) }.to raise_error(ArgumentError) end - [ ".", "-", "_", "1"].each do |char| + ["-", "_", "1"].each do |char| it "should allow a '#{char}' character in the data bag name" do expect(@data_bag.name("clown#{char}clown")).to eq("clown#{char}clown") end |