summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Make this a helper module not a mixincron_validationsTim Smith2020-03-234-27/+27
| | | | | | Stop abusing the mixin name and stop using the mixin like the kitchen drawer of junk it's becoming. Signed-off-by: Tim Smith <tsmith@chef.io>
* Add additional specs to the cron_d resourceTim Smith2020-03-231-1/+13
| | | | | | Why not Signed-off-by: Tim Smith <tsmith@chef.io>
* Fixes to the mixin tests from the reviewTim Smith2020-03-231-2/+6
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove a functional test that was already well cover in unit testsTim Smith2020-03-231-7/+0
| | | | | | This is really unit test land Signed-off-by: Tim Smith <tsmith@chef.io>
* Chefstyle fixTim Smith2020-03-231-2/+2
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Update lib/chef/mixin/cron_validations.rb Tim Smith2020-03-231-13/+3
| | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: pete higgins <pete@peterhiggins.org>
* Tweak functional spec orderTim Smith2020-03-231-1/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove another duplicate value checkTim Smith2020-03-231-1/+0
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Update lib/chef/mixin/cron_validations.rb Tim Smith2020-03-231-1/+0
| | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: pete higgins <pete@peterhiggins.org>
* Update lib/chef/mixin/cron_validations.rb Tim Smith2020-03-231-3/+1
| | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: pete higgins <pete@peterhiggins.org>
* Update lib/chef/mixin/cron_validations.rb Tim Smith2020-03-231-1/+0
| | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: pete higgins <pete@peterhiggins.org>
* Update the cron functional tests for the new errorTim Smith2020-03-231-7/+4
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Make the spec look more like realityTim Smith2020-03-231-4/+0
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Fix some invalid functional testsTim Smith2020-03-231-14/+9
| | | | | | | | | | | | | | | | | | This was setting a totally invalid cron timing: ``` # Chef Name: something @hourly * * * * /bin/true ``` This should be: ``` # Chef Name: something @hourly /bin/true ``` Signed-off-by: Tim Smith <tsmith@chef.io>
* Move the first part of the cron resource over to mixin cron validationsTim Smith2020-03-233-79/+27
| | | | | | Reduces duplicate code and allows us to convert these to properties which show in the resource inspector and can be automatically documented. One change to how the properties work: We no longer convert Integers to Strings since I couldn't determine why we'd want to do this. Signed-off-by: Tim Smith <tsmith@chef.io>
* Test both cron and cron_d resourcesTim Smith2020-03-231-1/+7
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Move cron validatioin methods into a mixinTim Smith2020-03-234-126/+169
| | | | | | This will allow us to use them in the other cron resource eventually, but definitely in the chef_client_cron resource today. Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #9519 from chef/remove-outdated-commentTim Smith2020-03-201-4/+0
|\ | | | | Remove outdated comment about shell args on different platforms.
| * Remove outdated comment about shell args on different platforms.remove-outdated-commentPete Higgins2020-03-201-4/+0
|/ | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
* Bump version to 16.0.150 by Chef Expeditorv16.0.150Chef Expeditor2020-03-207-19/+20
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #9516 from chef/ulimit_fixTim Smith2020-03-202-0/+16
|\ | | | | Fix loading the template file in the user_ulimit resource
| * Fix loading the template file in the user_ulimit resourceTim Smith2020-03-202-0/+16
| | | | | | | | | | | | Also test it in the kitchen tests. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 16.0.149 by Chef Expeditorv16.0.149Chef Expeditor2020-03-207-19/+20
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #9515 from chef/expeditor/train-core_3.2.26Tim Smith2020-03-201-5/+3
|\ \ | | | | | | Bump train-core to 3.2.26
| * | Bump train-core to 3.2.26Chef Expeditor2020-03-201-5/+3
|/ / | | | | | | | | | | This pull request was triggered automatically via Expeditor when train-core 3.2.26 was promoted to Rubygems. This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required.
* | Bump version to 16.0.148 by Chef Expeditorv16.0.148Chef Expeditor2020-03-207-19/+20
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #9514 from pschaumburg/ps/windows_firewall_rule-displaynameTim Smith2020-03-202-23/+45
|\ \ | | | | | | extend windows_firewall_rule abilities with displayname and description
| * | Fix Chefstyle lintPatrick Schaumburg2020-03-201-1/+1
| | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | fix own failures in unit testsPatrick Schaumburg2020-03-201-3/+3
| | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | Add/Change unit tests to support displaynamePatrick Schaumburg2020-03-201-20/+32
| | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | extend windows_firewall_rule abilities (displayname, description)Patrick Schaumburg2020-03-201-3/+13
|/ / | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
* | Bump version to 16.0.147 by Chef Expeditorv16.0.147Chef Expeditor2020-03-197-19/+20
|/ | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #9511 from tecracer/theinen/fix-windows-firewall-ruleTim Smith2020-03-191-2/+6
|\ | | | | Fix windows_firewall_rule resource for rules with multiple profiles
| * Fix windows_firewall_rule resource for rules with multiple associated profilesThomas Heinen2020-03-191-2/+6
| | | | | | | | Signed-off-by: Thomas Heinen <theinen@tecracer.de>
* | Bump version to 16.0.146 by Chef Expeditorv16.0.146Chef Expeditor2020-03-197-19/+20
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #9500 from chef/lcg/dnf-refreshLamont Granquist2020-03-199-245/+684
|\ \ | |/ |/| Refresh DNF package provider and add aarch el8 testing support
| * DNF refresh and aarch64-el8 supportlcg/dnf-refreshLamont Granquist2020-03-199-245/+684
|/ | | | | | | | should port all fixes from the yum provider back into the dnf provider. adds aarch for el8 since the func tests now pass. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Bump version to 16.0.145 by Chef Expeditorv16.0.145Chef Expeditor2020-03-187-19/+20
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #9492 from ↵Tim Smith2020-03-182-2/+3
|\ | | | | | | | | MsysTechnologiesllc/sangmesh/Fixed_Use_Ohai_data_to_determine_if_we_have_PowerShell_installed powershell_package: Use ohai data to get the powershell release instead of shelling out
| * run powershell_spec for windows onlysanga172020-03-181-1/+1
| | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| * Powershell spec file updatedsanga172020-03-171-0/+1
| | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| * Unwanted code removedsanga172020-03-171-1/+1
| | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| * used helper methodsanga172020-03-170-0/+0
| |\ | | | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| | * Update lib/chef/provider/package/powershell.rbSangmesh Ausekar2020-03-171-1/+1
| | | | | | | | | Co-Authored-By: Tim Smith <tsmith@chef.io>
| * | Used helper methodsanga172020-03-171-1/+1
| |/ | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| * Powershell script code replaced with ohai datasanga172020-03-161-1/+1
| | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| * Powershell script replaced with the ohai datasanga172020-03-161-1/+1
| | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
* | Update the introduced value for windows_firewall_rule's group propertyTim Smith2020-03-181-1/+1
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 16.0.144 by Chef Expeditorv16.0.144Chef Expeditor2020-03-187-19/+20
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8729 from pschaumburg/ps/windows_firewall_rule-groupTim Smith2020-03-181-0/+12
|\ \ | | | | | | add group to windows_firewall_rule resource
View Lorry Controller Status