Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use const_set instead of evaljdm/lwrp-base | Jay Mundrawala | 2015-06-30 | 1 | -1/+1 |
| | |||||
* | Added spec for #3607 | Jay Mundrawala | 2015-06-30 | 1 | -0/+10 |
| | |||||
* | Get tests passing | Jay Mundrawala | 2015-06-30 | 1 | -0/+15 |
| | |||||
* | Fix ability to monkey match LWRP through Chef::Resource::MyLwrp | Jay Mundrawala | 2015-06-30 | 2 | -61/+34 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Repro ===== The following cookbook would repro the issue cookbooks/lwrptest/resources/my_lwrp.rb --------------------------------------- ```ruby ``` cookbooks/lwrptest/providers/my_lwrp.rb --------------------------------------- ```ruby ``` cookbooks/lwrptest/recipes/default.rb ------------------------------------- ```ruby module Something def something puts 'something here' end end ::Chef::Resource::LwrptestMyLwrp.send(:include, Something) lwrptest_my_lwrp 'blah' do something end ``` Why it does not work ==================== Running this in 12.4.0 produces the error ``` NoMethodError ------------- undefined method `something' for LWRP resource lwrptest_my_lwrp from cookbook lwrptest ``` The problem is that LWRP usage through `Chef::Resource::MyLwrp` and `Chef::Provider::MyLwrp` is depreacted. In order to participate in the deprecation, `Chef::Resource::MyLwrp` is a subclass of the actual `MyLwrp` class with `initialize` overriden to do a Chef::Log.deprecation. In the example above, the intention is to add a method to the resource so that it can be used from the dsl. The reason this does not work is because including the method on `Chef::Resource::MyLwrp` adds the method to the subclass, and the resource that is looked up when running the recipe is the actual resource. | ||||
* | Merge pull request #3605 from coderanger/action | Thom May | 2015-06-30 | 26 | -51/+131 |
|\ | | | | | Rework Resource#action to match the 12.3 API. | ||||
| * | Test updates for the changes to default actions. | Noah Kantrowitz | 2015-06-29 | 19 | -24/+24 |
| | | |||||
| * | Make resource-based guard interpreters cope with arrays. | Noah Kantrowitz | 2015-06-29 | 1 | -1/+2 |
| | | | | | | Ping @adamedx for confirmation. | ||||
| * | Add a test for array assignment on action. | Noah Kantrowitz | 2015-06-29 | 1 | -0/+5 |
| | | |||||
| * | Tests for new default_action behaviors. | Noah Kantrowitz | 2015-06-29 | 1 | -0/+39 |
| | | |||||
| * | Be paranoid about potential weird overrides of default_action. | Noah Kantrowitz | 2015-06-29 | 1 | -1/+1 |
| | | | | | | Always compare them as arrays, just in case. | ||||
| * | Handle setting default action with the same coercion logic as action. | Noah Kantrowitz | 2015-06-29 | 1 | -9/+4 |
| | | | | | | | | This coerces default_action(:one) so action() == [:one]. Also update doctoring to match behavior. | ||||
| * | Get tests passing | Jay Mundrawala | 2015-06-29 | 2 | -2/+2 |
| | | |||||
| * | Fix ancillary tests. | Noah Kantrowitz | 2015-06-29 | 4 | -6/+6 |
| | | |||||
| * | Make sure the default case gives an array too. | Noah Kantrowitz | 2015-06-29 | 2 | -1/+5 |
| | | |||||
| * | Rework Resource#action to match the 12.3 API. | Noah Kantrowitz | 2015-06-29 | 2 | -8/+44 |
|/ | | | | | | | This means it always coerces to an Array. Also ensures that Resource#action= goes through the same validation. Fixes #3604. | ||||
* | Merge pull request #3600 from coderanger/patch-4 | Thom May | 2015-06-29 | 1 | -0/+6 |
|\ | | | | | Add myself as a core maintainer. | ||||
| * | Add myself as a core maintainer. | Noah Kantrowitz | 2015-06-25 | 1 | -0/+6 |
| | | | | | | I would really rather we split the DSL and Resource machinery in to a component because I'm definitely not able to call myself a maintainer for the "and everything else" part, but waiting to get my patches merged it getting annoying :-) | ||||
* | | Merge pull request #3606 from chef/jdm/pin-ffi | Jay Mundrawala | 2015-06-26 | 1 | -1/+1 |
|\ \ | | | | | | | FFI 1.9.9 is causing segfaults | ||||
| * | | FFI 1.9.9 is causing segfaultsjdm/pin-ffi | Jay Mundrawala | 2015-06-26 | 1 | -1/+1 |
|/ / | |||||
* | | Update CHANGELOGS. | Kartik Null Cating-Subramanian | 2015-06-26 | 1 | -0/+10 |
| | | |||||
* | | The wording seemed odd.jjasghar/needed_the | JJ Asghar | 2015-06-26 | 1 | -1/+1 |
| | | | | | | | | Added the word "the" and it now reads much better. | ||||
* | | Missing require (require what you use).jk/missing_require | John Keiser | 2015-06-26 | 1 | -0/+1 |
| | | |||||
* | | remove extraneous space | Dave Eddy | 2015-06-26 | 1 | -1/+1 |
| | | |||||
* | | correcting minor typo in user_edit knife action | Nell Shamrell | 2015-06-26 | 1 | -2/+1 |
| | | |||||
* | | Issue #3080: powershell_script: do not allow suppression of syntax errorsadamedx/ps-syntax-always-raise | adamedx | 2015-06-26 | 2 | -22/+35 |
| | | |||||
* | | changed the registry_key provider to scan collected registry keys with ↵ | JKerry | 2015-06-26 | 3 | -6/+32 |
| | | | | | | | | downcased keys | ||||
* | | downcasted registry key names to lowercase | JKerry | 2015-06-26 | 2 | -2/+22 |
| | | |||||
* | | Merge pull request #3587 from coderanger/patch-3 | Ranjib Dey | 2015-06-26 | 1 | -0/+7 |
|\ \ | | | | | | | Fix deprecated setters. | ||||
| * | | Fix deprecated setters. | Noah Kantrowitz | 2015-06-24 | 1 | -0/+7 |
| | | | | | | | | | Adds actual implementation for deprecated setters, and re-adds the accidentally removed resource_collection= setter. | ||||
* | | | Merge pull request #3589 from chef/tm/fix_bashisms | Thom May | 2015-06-26 | 1 | -4/+4 |
|\ \ \ | |_|/ |/| | | Fix some errant bashisms | ||||
| * | | Fix some errant bashismstm/fix_bashisms | Thom May | 2015-06-25 | 1 | -4/+4 |
| |/ | | | | | | | Fixes #3408 | ||||
* | | Merge branch 'jdm/changelog' | Jay Mundrawala | 2015-06-25 | 1 | -1/+4 |
|\ \ | |||||
| * | | Add CHANGELOG entry for #3593 | Jay Mundrawala | 2015-06-25 | 1 | -0/+1 |
| | | | |||||
| * | | Added CHANGELOG entry for #3586 | Jay Mundrawala | 2015-06-25 | 1 | -1/+3 |
| | | | |||||
* | | | Merge pull request #3599 from chef/jdm/3593 | Jay Mundrawala | 2015-06-25 | 2 | -1/+13 |
|\ \ \ | |/ / | | | | Fix issue where blocks were not considered in priority mapping | ||||
| * | | Fix issue where blocks were not considered in priority mappingjdm/3593 | Jay Mundrawala | 2015-06-25 | 1 | -1/+1 |
| | | | | | | | | | | | | This should solve #3593 | ||||
| * | | Added spec to check that blocks gain priority for resolution | Jay Mundrawala | 2015-06-25 | 1 | -0/+12 |
|/ / | |||||
* | | Merge pull request #3525 from chef/jtimberman/rfc-tier-maintainers | Bryan McLellan | 2015-06-25 | 2 | -4/+105 |
|\ \ | | | | | | | add maintainers/Lts for tier 1 & 2 support | ||||
| * | | Add Lamont as a maintainer for ArchLinuxjtimberman/rfc-tier-maintainers | jtimberman | 2015-06-25 | 2 | -0/+13 |
| | | | |||||
| * | | Thom maintainer for OmniOS, Lamont Lt for AIX | jtimberman | 2015-06-20 | 2 | -4/+15 |
| | | | |||||
| * | | add maintainers/Lts for tier 1 & 2 support | jtimberman | 2015-06-20 | 2 | -0/+77 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per the RFC submitted in chef-rfc PR 131: https://github.com/chef/chef-rfc/pull/131 We need lieutenants, maintainers for all the tier 1 and tier 2 platforms. Thom May and Lamont Granquist have volunteered for various platforms. | ||||
* | | | count skipped resources in among total resources | Ranjib Dey | 2015-06-25 | 2 | -1/+5 |
| | | | |||||
* | | | Merge pull request #3586 from chef/jdm/lwrp-fix | Jay Mundrawala | 2015-06-25 | 2 | -1/+27 |
|\ \ \ | |_|/ |/| | | Fix to allow LW resources to be used with HW providers | ||||
| * | | Fix to allow LW resources to be used with HW providersjdm/lwrp-fix | Jay Mundrawala | 2015-06-24 | 2 | -1/+27 |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | This should fix sethvargo-cookbooks/swap#22 Here's what was happening: The cookbooks creates a Resource using the LWRP base. This dynamically creates a class. We used to create this class with the name Chef::Resource::SomeResourceName. In 12.4, this change to something like "LWRP resource some_resource_name from cookbook CookbookName". When searching for a provider, it couldn't be found because it wasn't explicitly set, as it would have been if it was a LW provider, and it wasn't found in Chef::Provider, because Chef::Provider had a provider SomeResourceName instead of "LWRP resource some_resource_name from cookbook CookbookName". | ||||
* | | Merge branch 'jk/property-base' | John Keiser | 2015-06-23 | 6 | -131/+2415 |
|\ \ | |||||
| * | | Do not validate defaults, for backcompat purposesjk/property-base | John Keiser | 2015-06-23 | 2 | -21/+39 |
| | | | |||||
| * | | Freeze default constants | John Keiser | 2015-06-23 | 2 | -2/+7 |
| | | | |||||
| * | | Fix set_or_return order: default->coerce->validate | John Keiser | 2015-06-23 | 3 | -147/+188 |
| | | | |||||
| * | | Add some comments | John Keiser | 2015-06-23 | 1 | -13/+173 |
| | | | |||||
| * | | Evaluate lazy defaults in context of the instance | John Keiser | 2015-06-23 | 2 | -30/+29 |
| | | |