| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Our logic for creating the deprecation class was too complicated and had
a lot of edge cases. Simplifying here to only deprecate when
`:treat_deprecation_warnings_as_errors` is set. This means that warnings
will no longer be printed, however this is a lot less risky.
|
| |
|
|
|
|
|
| |
This reverts commit 27d8675ec1c80f1eb7ec57f7b6c854441bb395ee, reversing
changes made to 3501ba4020dc21377bc999e57e25eadb315ec783.
|
|\
| |
| | |
Fix ability to monkey match LWRP through Chef::Resource::MyLwrp
|
| | |
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Repro
=====
The following cookbook would repro the issue
cookbooks/lwrptest/resources/my_lwrp.rb
---------------------------------------
```ruby
```
cookbooks/lwrptest/providers/my_lwrp.rb
---------------------------------------
```ruby
```
cookbooks/lwrptest/recipes/default.rb
-------------------------------------
```ruby
module Something
def something
puts 'something here'
end
end
::Chef::Resource::LwrptestMyLwrp.send(:include, Something)
lwrptest_my_lwrp 'blah' do
something
end
```
Why it does not work
====================
Running this in 12.4.0 produces the error
```
NoMethodError
-------------
undefined method `something' for LWRP resource lwrptest_my_lwrp from cookbook lwrptest
```
The problem is that LWRP usage through `Chef::Resource::MyLwrp` and
`Chef::Provider::MyLwrp` is depreacted. In order to participate in
the deprecation, `Chef::Resource::MyLwrp` is a subclass of the actual
`MyLwrp` class with `initialize` overriden to do a Chef::Log.deprecation.
In the example above, the intention is to add a method to the resource
so that it can be used from the dsl. The reason this does not work is
because including the method on `Chef::Resource::MyLwrp` adds the method
to the subclass, and the resource that is looked up when running the
recipe is the actual resource.
|
|\
| |
| | |
Rework Resource#action to match the 12.3 API.
|
| | |
|
| |
| |
| | |
Ping @adamedx for confirmation.
|
| | |
|
| | |
|
| |
| |
| | |
Always compare them as arrays, just in case.
|
| |
| |
| |
| | |
This coerces default_action(:one) so action() == [:one]. Also update
doctoring to match behavior.
|
| | |
|
| | |
|
| | |
|
|/
|
|
|
|
|
| |
This means it always coerces to an Array. Also ensures that
Resource#action= goes through the same validation.
Fixes #3604.
|
|\
| |
| | |
Add myself as a core maintainer.
|
| |
| |
| | |
I would really rather we split the DSL and Resource machinery in to a component because I'm definitely not able to call myself a maintainer for the "and everything else" part, but waiting to get my patches merged it getting annoying :-)
|
|\ \
| | |
| | | |
FFI 1.9.9 is causing segfaults
|
|/ / |
|
| | |
|
| |
| |
| |
| | |
Added the word "the" and it now reads much better.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
downcased keys
|
| | |
|
|\ \
| | |
| | | |
Fix deprecated setters.
|
| | |
| | |
| | | |
Adds actual implementation for deprecated setters, and re-adds the accidentally removed resource_collection= setter.
|
|\ \ \
| |_|/
|/| | |
Fix some errant bashisms
|
| |/
| |
| |
| | |
Fixes #3408
|
|\ \ |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
| | | |
Fix issue where blocks were not considered in priority mapping
|
| | |
| | |
| | |
| | | |
This should solve #3593
|
|/ / |
|
|\ \
| | |
| | | |
add maintainers/Lts for tier 1 & 2 support
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Per the RFC submitted in chef-rfc PR 131:
https://github.com/chef/chef-rfc/pull/131
We need lieutenants, maintainers for all the tier 1 and tier 2
platforms. Thom May and Lamont Granquist have volunteered for various
platforms.
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Fix to allow LW resources to be used with HW providers
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This should fix sethvargo-cookbooks/swap#22
Here's what was happening:
The cookbooks creates a Resource using the LWRP base. This dynamically
creates a class. We used to create this class with the name
Chef::Resource::SomeResourceName. In 12.4, this change to something like
"LWRP resource some_resource_name from cookbook CookbookName". When
searching for a provider, it couldn't be found because it wasn't explicitly
set, as it would have been if it was a LW provider, and it wasn't found
in Chef::Provider, because Chef::Provider had a provider SomeResourceName
instead of "LWRP resource some_resource_name from cookbook CookbookName".
|
|\ \ |
|
| | | |
|