summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Layout/FirstMethodArgumentLineBreaklcg/new-chefstyle2Lamont Granquist2019-07-0894-444/+834
|
* lazy procs are instance_exec in the resource alreadyLamont Granquist2019-07-057-14/+14
| | | | | | | | exposed by Style/SymbolProc mangling some bad code. no idea how this ever worked. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix 4 copsLamont Granquist2019-07-0560-189/+296
| | | | | | | | | | | | | | - Layout/MultilineMethodCallBraceLayout - Layout/ClosingParenthesisIndentation - Layout/IndentFirstArgument EnforcedStyle: consistent - Layout/BlockEndNewline the first of these autocorrected to horrible looking code which exposed that we really needed the other three as well, which also cleaned up a bunch of other terrible looking code. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/SymbolProcLamont Granquist2019-07-0576-161/+121
| | | | | | enforce pretzels. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/StringLiteralsInInterpolationLamont Granquist2019-07-05148-433/+433
| | | | | | since we use double quotes, be consistent everywhere. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/ClassCheckLamont Granquist2019-07-0557-119/+119
| | | | | | convert kind_of? to is_a? Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/RegexpLiteralLamont Granquist2019-07-0558-149/+149
| | | | | | | given how many regexps we have with /'s in the match this seems like a very good one. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/NegatedIfLamont Granquist2019-07-0587-149/+149
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/EmptyLiteralLamont Granquist2019-07-0592-158/+158
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix more Style/SymbolArray autocorrect bugsLamont Granquist2019-07-024-11/+11
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix bugs from Style/SymbolArray autocorrect copLamont Granquist2019-07-022-3/+3
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/EmptyMethodLamont Granquist2019-07-0236-366/+183
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* tweak Lint/BlockAlignmentLamont Granquist2019-07-0217-167/+167
| | | | | | | | | | | | | | | Lint/BlockAlignment: Enabled: true EnforcedStyleAlignWith: start_of_block this works better with Layout/MultilineMethodCallIndentation to force indentation of multiline method calls that wind up with multiline blocks. i'd probably pull back the end to match with the start of the expression but this gets the indentation level inside the block correct. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Layout/MultilineMethodCallIndentationLamont Granquist2019-07-028-159/+159
| | | | | | | | Layout/MultilineMethodCallIndentation: Enabled: true EnforcedStyle: indented Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/MethodCallWithoutArgsParenthesesLamont Granquist2019-07-0279-210/+210
| | | | | | | | zero args methods don't get parens. this certainly reads better than the inverse. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/SymbolArrayLamont Granquist2019-07-02104-834/+834
| | | | | | start enforcing using %i{} instead of arrays of symbols Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Layout/EmptyLineAfterGuardClauseLamont Granquist2019-07-02220-0/+481
| | | | | | | i like this one, gives visual priority to returns or raises that are buried in the middle of things. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Layout/AlignArgumentslcg/new-chefstyleLamont Granquist2019-07-02180-1698/+1698
| | | | | | | | | | | | | | this is using: Layout/AlignArguments: Enabled: true EnforcedStyle: with_fixed_indentation the default style can use really excessive whitespace. on starting lines which are already long, it fully indents across to where the arguments start and then begins the line there. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fixes for chefstyle bumpLamont Granquist2019-07-0214-61/+61
| | | | | | | | result of automation https://github.com/chef/chefstyle/pull/72 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Bump version to 15.1.39 by Chef Expeditorv15.1.39Chef Expeditor2019-07-026-14/+15
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #8706 from robbkidd/robb/fix-hab-promotionTim Smith2019-07-021-1/+1
|\ | | | | update bldr config with new hab package name
| * update bldr config with new package nameRobb Kidd2019-07-021-1/+1
| | | | | | | | | | | | | | This should fix package promotion from unstable->current in expeditor, too. Signed-off-by: Robb Kidd <robb@thekidds.org>
* | Bump version to 15.1.38 by Chef Expeditorv15.1.38Chef Expeditor2019-07-026-14/+15
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8705 from ↵Tim Smith2019-07-022-3/+8
|\ \ | |/ |/| | | | | MsysTechnologiesllc/VSingh/windows_task_day_integer windows_task: Fix for :day option is not accepting integer value
| * Parse day param value into stringVivek Singh2019-07-022-3/+8
|/ | | | Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
* Bump version to 15.1.37 by Chef Expeditorv15.1.37Chef Expeditor2019-07-026-13/+21
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #8701 from chef/expeditor/inspec-core_4.6.9Tim Smith2019-07-011-3/+3
|\ | | | | Bump inspec-core to 4.6.9
| * Bump inspec-core to 4.6.9Chef Expeditor2019-07-011-3/+3
|/ | | | | | This pull request was triggered automatically via Expeditor when inspec-core 4.6.9 was promoted to Rubygems. This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required.
* Update CHANGELOG.md to reflect the promotion of 15.1.36Chef Expeditor2019-07-012-73/+70
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Update the codeowners formatTim Smith2019-07-011-3/+3
| | | | | | ** isn't what we wanted here Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 15.1.36 by Chef Expeditorv15.1.3615.1.36Chef Expeditor2019-07-016-14/+15
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #8687 from criteo-forks/issue_7215_yum_package_custom_repoTim Smith2019-07-011-5/+3
|\ | | | | Pass yum_package options to underlying python helper
| * Pass yum_package options to underlying python helperBaptiste Courtois2019-06-241-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When working with custom repo that are disabled by default, we need to enable them on-demand. The python helper handles that properly but the yum package provider does not pass user's options in all cases. Most of the time there is no issue because in normal cases you should not need to enable any repository to work with "installed" packages. However in some rare cases, you may have multiple installed versions of a given package. In that situation, python libraries used by the helper will do some extra work that may (will) requires to enable the repo. See call to _compare_providers in http://yum.baseurl.org/download/docs/yum-api/3.2.27/yum-pysrc.html#YumBase._bestPackageFromList Not passing the options in that case, will result in an unclear error: > ' * No candidate version available for "package" ' And often will lock/corrupt the rpm db. Signed-off-by: Baptiste Courtois <b.courtois@criteo.com>
* | Merge pull request #8696 from chef/15.1Tim Smith2019-07-011-0/+48
|\ \ | | | | | | Add Chef 15.1 release notes
| * | Remove the performance mentionTim Smith2019-07-011-4/+0
| | | | | | | | | | | | | | | | | | | | | Some of it was in 15.0 and some in 15.1 and it's tricky to call out the impact and the exact time that stuff landed so let's skip it Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Update RELEASE_NOTES.md Tim Smith2019-07-011-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
| * | Move the perf improvements to 15.0Tim Smith2019-07-011-4/+4
| | | | | | | | | | | | | | | | | | The majority of this work actually happened in 15.0 Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add Chef 15.1 release notesTim Smith2019-07-011-0/+52
|/ / | | | | | | | | | | Add the release notes for Chef 15.1 Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 15.1.35 by Chef Expeditorv15.1.35Chef Expeditor2019-07-016-14/+15
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8699 from chef/expeditor/train-core_2.1.13Tim Smith2019-07-011-4/+4
|\ \ | | | | | | Bump train-core to 2.1.13
| * | Bump train-core to 2.1.13Chef Expeditor2019-07-011-4/+4
|/ / | | | | | | | | | | This pull request was triggered automatically via Expeditor when train-core 2.1.13 was promoted to Rubygems. This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required.
* | Bump version to 15.1.34 by Chef Expeditorv15.1.34Chef Expeditor2019-06-286-14/+15
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8698 from chef/chef-infraTim Smith2019-06-287-4/+4
|\ \ | | | | | | Rename the habitat package to chef-infra-client