| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Good example of why this is breaking, but this is better.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All required properties are now required for all actions by default
even if the action does not reference the property.
In order to only make the property required for a subset of the
actions, specify them as an array of symbols to the required
options on the property.
```
property :whatever, String, required: %i{start stop}
action :start do
end
action :stop do
end
action :enable do
end
action :disable do
end
```
That property will be required for start+stop but not for
enable+disable.
There's an unaddressed edge case here where if you reference the
property in an action which was not specified that it will also
fail validation. That is correct behavior. We should probably
dig into how to warn the user that they must either remove the
reference to the property from that action or else to add the
action to the list of required actions on the property.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\
| |
| | |
Update Ohai to 16.0.18 for Windows DMI plugin
|
| |/
|
|
|
|
| |
Also bump all the other stuff while we're at it.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| |
|
|
| |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\
| |
| | |
Knife bootstrap options cleanup
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We have issue that are caused by old code before merging of hash values
were done correctly.
The `config` hash correctly merges all options and should always be
used.
Knife plugins should never touch Chef::Config[:knife] values (either
reading or writing from them).
The `knife_config` should be converted to the `config` hash since it
directly accesses Chef::Config[:knife] values.
The `config_value()` helper should no longer be used. Very clearly most
people started to use that when they should just use the config hash
directly. That was intended to be used only when a knife cli option
was being renamed and the former configuration value needed to be
used as well. It has been cargo culted around as the way to access
config values, and that should really stop.
The DataBagSecretOption mixin has been cleaned up so that the cli
options read+write only to the config[:cl_secret] and
config[:cl_secret_file] values. The config file values go into
config[:secret] and config[:secret_file]. The fact that those are
the merged values in the `config` hash doesn't matter since only
the cli should be writing to the first two and only the config
file should be writing to the latter two. I don't know why it was
made so complicated to begin with, but if there's some hidden
chef-11.early backcompat there, then chef-16 deliberately breaks that.
The use of `locate_config_value` helpers in all knife plugins is also
discouraged (but they all implement those themselves), just use the
config hash, which has the correct hash merge ordering. All of those
need to be deleted.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
I guess this is minimum viable testing to ensure this doesn't break in
the future.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| | | |
| | |
| | |
| | | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \ \
| |/ / |
|
| |/ /
| |
| |
| |
| |
| |
| | |
The consumption of ohai attributes by the ohai segment plugin code
was breaking this feature.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \
| | |
| | | |
Merge ohai resource / provider into a single resource
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| |/ /
| |
| |
| |
| |
| | |
Simplify this resource and squash some files
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \ |
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |\ \ \
| |/ /
|/| | |
Fix typo in chef-utils comment
|
| |/ /
| |
| |
| |
| |
| | |
These generate the vscode helpers so there was a typo in that snippet
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \
| | |
| | |
| | |
| | | |
MsysTechnologiesllc/dh/add-timeout-for-msu-package-removal
msu_package: Removal also requires passing timeout property
|
| |/ /
| |
| |
| | |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \
| | |
| | | |
Add a warning to the end of the chef run for EOL releses
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use 2006 as the base year. Chef 15 goes EOL next year on 5-1-2021 so
2006 + 15 = 2021 and then we know it.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We really want to encourage people to upgrade. One way we can do this is
to just warn them that they're on an EOL release. This simple warning
might nudge them to upgrade their client. It's works off the base EOL
data of Chef 15 and takes the current release to add to that date. That
way we don't have to maintain anything and as long as we keep a yearly
release we're good. If we change the schedule then we either remove this
or update the logic. That's a risk in shipping code that doesn't fire
for 2 years.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | | |
| | |
| | |
| | | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
MsysTechnologiesllc/dh/fix-msu-pkg-cumulative-update
msu_package: Fix cumulative updates installation and provide a 3600s default timeout
|
| | | |
| | |
| | |
| | | |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
| | | |
| | |
| | |
| | | |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
| | | |
| | |
| | |
| | | |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
| | | |
| | |
| | |
| | | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \ \
| |_|/
|/| | |
Fix to use correct Amazon Linux 2 queues
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Christopher A. Snapp <csnapp@chef.io>
|
| | | |
| | |
| | |
| | | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \ \
| |/ /
|/| | |
Replace a few uses of attributes / parameters in messaging with properties
|
| |/ /
| |
| |
| |
| |
| | |
I think we may finally have them all now.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \
| |/
|/| |
Updates to timeout properties in various resources
|
| | |
| |
| |
| |
| |
| | |
This should just be done on the resource instead of hacking it into the provider
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
1) make sure they all have desired state false
2) Fix some indentation
3) Fix portage_package to have a type of String/Integer to match package
4) Add the String type to paludis_package to match the package default
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| | |
| |
| |
| | |
Obvious fix; these changes are the result of automation not creative thinking.
|
| |\ \
| |/
| | |
Update license scout to fix broken windows builds
|
| |/
|
|
|
|
| |
This knows about the new location of the readme file for win32-api gem.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
