summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* These are all input validation errors so they should raise ArgumentError not ↵more_taskTim Smith2017-12-082-16/+14
| | | | | | RuntimeError Signed-off-by: Tim Smith <tsmith@chef.io>
* Expect the right exceptionsTim Smith2017-12-081-23/+23
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Use integer for numeric evaluationTim Smith2017-12-081-2/+3
| | | | | | Why is this not just in the duration calculator? Well we use it in two places and I would have had to add the same logic in both of those places. It's nice and easy to read this way Signed-off-by: Tim Smith <tsmith@chef.io>
* Properly handle an ISO8601 duration of 0 secondsTim Smith2017-12-082-2/+4
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add tests for invalid datesTim Smith2017-12-071-2/+21
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Improve the integer/string warning messageTim Smith2017-12-073-7/+7
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Validate the start_date is correctly passedTim Smith2017-12-072-2/+5
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Explain what PT72H isTim Smith2017-12-071-1/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* allow random_delay and execution_time_limit to be integers and properly validateTim Smith2017-12-072-33/+61
| | | | | | Also set the default the right way with execution_time_limit Signed-off-by: Tim Smith <tsmith@chef.io>
* Validate that starttime is actually in HH:mm formatTim Smith2017-12-072-4/+15
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Test lowercase system users not requiring passwordsTim Smith2017-12-071-0/+5
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add testing of sec_to_durTim Smith2017-12-071-0/+16
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 13.6.27 by Expeditorv13.6.27Chef Expeditor2017-12-075-11/+12
|
* Merge pull request #6630 from chef/opensslTim Smith2017-12-073-22/+21
|\ | | | | Update for openssl 1.0.2n and inspec 1.48
| * Update for openssl 1.0.2n and inspec 1.48Tim Smith2017-12-073-22/+21
|/ | | | | | | | | Resolves: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-3738 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-3737 Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #6620 from chef/improved_task_loggingTim Smith2017-12-073-45/+49
|\ | | | | Additional logging improvements to windows_task
| * Improve the passwordless user error, logic, and testsimproved_task_loggingTim Smith2017-12-063-21/+25
| | | | | | | | | | | | Specify exactly what we're checking for in the error. This needs to go into the docs site as well. Signed-off-by: Tim Smith <tsmith@chef.io>
| * Update resource specsTim Smith2017-12-061-14/+14
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Attribute -> Property and remove double spacesTim Smith2017-12-061-10/+10
| | | | | | | | | | | | These are properties not attributes. Signed-off-by: Tim Smith <tsmith@chef.io>
| * Clarify that we're talking about the 1 and only SYSTEM user hereTim Smith2017-12-063-3/+3
|/ | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #6625 from chef/lcg/lwrp-test-speedupLamont Granquist2017-12-065-35/+56
|\ | | | | speedup lwrp tests
| * travis caught another speclcg/lwrp-test-speedupLamont Granquist2017-12-061-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * speedup lwrp testsLamont Granquist2017-12-064-34/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reset the global resource and provider handler maps before each and every test. note that mutation through the top-level keys will get preserved so this is not perfect, but deep-duping through every single test we run becomes expensive. this is sufficient to flush out the global state of all the test lwrp fixtures that we setup. it discovered several usage bugs where we either relied on this feature or where we were testing different fixtures from the ones we thought we were. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #6424 from chef/lcg/deep-merge-cache-rewriteLamont Granquist2017-12-069-159/+355
|\ \ | | | | | | Node attributes per-container lazy deep merge and deep merge performance improvements
| * | fixup some unit testslcg/deep-merge-cache-rewriteLamont Granquist2017-12-061-6/+7
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | remove more debugging and revert no-longer necessary fixLamont Granquist2017-12-061-4/+2
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | remove comments + debuggingLamont Granquist2017-12-062-3/+0
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | turboize arraysLamont Granquist2017-12-061-10/+36
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | turbo attribute mergingLamont Granquist2017-12-061-1/+16
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | Per-container deep merge cachingLamont Granquist2017-12-068-152/+311
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces the one-big top level deep merge cache with individual deep merge caches in every container. The Immutable container state becomes the deep merge cache. - Does not use a pure decorator style approach since that failed before because of ruby internals breaking things like `===` and `=~` on decorated objects, so we inherit (ultimately from Hash + Array). - The state being the container state is useful in ruby since APIs on Hash and Array poke around in internal state to make things fast. If we inherit from Hash/Array but don't have the correct internal state things go wonky. - Throwing away the internal state is equivalent to flushing the cache. - Since we throw away all linked objects when we do that, we flush at every level below the level being flushed (which is correct semantics). - If a user has a pointer to an old immutable object from a sub-level, that isn't mutated so the old object still contains the old view of the data (which I think is correct, although I have some doubts that its necessary, but it came along free for the ride). - When we reset the cache we do mutate the cache being reset, which might change data in held references. If this becomes an issue the fix would be to reset the cache at the level above by creating a new, "empty" ImmutableHash/ImmutableArray object and inserting it into the deep_merge_cache datastructure instead of clearing the internal state of the child object. I don't know practically how anyone would hit this, though, so would prefer to wait on doing that work until we see an actual bug report. - Because of the way ruby pokes around internally there's some weirdnesses like the pre-generation of the cache for all the values of a subarray when #each is called, which is due to the way that ruby walks through array-serialized hashes when called like: `Array#each { key, value| ... }` (which is an undocumented(?) thing in ruby). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Fixup the functional testsTim Smith2017-12-061-2/+2
|/ | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 13.6.26 by Expeditorv13.6.26Chef Expeditor2017-12-065-12/+12
|
* Merge pull request #6617 from chef/improved_task_loggingThom May2017-12-061-23/+29
|\ | | | | Improved windows_task logging
| * Use converge_by to perform actual resource updatesTim Smith2017-12-051-19/+19
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Clarify why we're not doing anything hereTim Smith2017-12-051-2/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add debug logging for the task existingTim Smith2017-12-051-0/+6
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Fix typos that prevented loggingTim Smith2017-12-051-2/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 13.6.25 by Expeditorv13.6.25Chef Expeditor2017-12-055-10/+12
| |
* | Merge pull request #6616 from chef/new_ohaiTim Smith2017-12-052-5/+17
|\ \ | |/ |/| Update InSpec to 1.47 and Ohai to 13.7
| * Update InSpec to 1.47 and Ohai to 13.7Tim Smith2017-12-052-5/+17
|/ | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Update CHANGELOG.md with details from pull request #6614Chef Expeditor2017-12-051-4/+4
|
* Merge pull request #6614 from chef/opensuse_testingTim Smith2017-12-048-5/+41
|\ | | | | Add openSUSE testing in Travis & expand cookbooks we test
| * Make sure we install sudo on opensuseTim Smith2017-12-041-0/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Fix the name of the opensuse kitchen boxTim Smith2017-12-041-1/+1
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Chefstyle fixTim Smith2017-12-041-1/+1
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Remove locale from the kitchen tests for nowTim Smith2017-12-043-5/+0
| | | | | | | | | | This cookbook needs some work Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add opensuse testing to TravisTim Smith2017-12-011-0/+18
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Exclude non-learnchef platforms from awesome chef cookbooksTim Smith2017-12-012-0/+4
| | | | | | | | | | | | There's no expectation that this will ever run on opensuse, amazon, or fedora Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add git and locale cookbooksTim Smith2017-12-014-1/+15
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add the cron cookbookTim Smith2017-12-012-0/+3
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>