| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the first pass through the JSON middleware it encodes the
body. if there's a retry, it re-encodes the body as a string
with all its metacharacters escaped.
this is a particular issue when doing a first request that is
a POST that requires negotiating the API version. when doing a
GET it isn't a problem because there's no body payload -- but a
POST or a PUT which requires a retry will get garbled and will
cause a 500.
this happens on hosted right now if trying to POST with a v2
API since hosted is only v1, so there's a retry to downgrade.
i also made the same kind of changes to the streaming download
requests, but since they're GETs its unclear to me if there was
any impact there -- but middleware could have been double-mangling
headers on a retry.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
| |
this hand-builds it with the software dep, and its not a direct dep of
chef itself and shouldn't be in the Gemfile.lock anyway, plus we need
to pin via omnibus_overrides.rb and double-pinning in the Gemfile.lock
is just added fussiness
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is also necessary for bundler-1.14.x
i'm still not entirely clear why we ever needed all the fussy software gem
configs or what the build-chef / build-chef-gem infrastructure ever
did for us. it seems to have been mostly micro-optimization around
building the software gems before bundle installing the project in order
to take advantage of git caching. i aggressively don't care about that,
this is quite fast enough. we can install nokogiri and libgecode early
and that should take care of 98% of the build optimization issue.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
| |
pretty sure i solved this some other way and this was debugging
i forgot to remove...
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See the PR comments for more philosophical background.
This simplifies the external tests. The major feature here is that
halite, poise, chefspec, etc are removed from the Gemfile.lock and
the transitive Gemfile splicing is gone from the external tests.
We're back to simply tracking master on external projects and bundle
installing without locks and going red if the break. Those external
projects should all similarly track master of chef/chef to reduce
the possibility that they break us here.
This also bumps bundler to 1.14.x and unblocks us there.
It continues to simplify our use of bundler to be more mainstream and
less impenetrable.
There was some crazy shit that I found where I had to remove env vars
like BUNDLE_ENABLE_TRAMPOLINE and the BUNDLE_IGNORE_CONFIG and
BUNDLE_FROZEN env vars in appveyor along with the .bundle/config frozen
setting were necessary to unbreak appveyor. We seem to have gotten
very far afield of standard bundler usage and it was breaking in strange
to debug ways.
Oddly enough this exposed weird errors in the
chef-config/spec/units/fips_spec.rb tests where we need to require the
"win32/registry" file there now even though I can't figure out why that
broke or how it was working previously.
Also, adding x64-mingw32 to x86-mingw32 was necessary to test in
appveyor on 64-bit windows (I tried universal-mingw32 and that failed)
which seems obvious and is another case that I don't understand how it
was working in bundler 1.12.x
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds InSpec to the Chef Gemfile, making it easier
for our community to use InSpec for testing without requiring
them to `chef_gem` install it prior to use.
This also helps our users who wish to use InSpec but are in an
air-gapped environment. Including our preferred testing library
in our Omnibus builds will make it much easier for those users
to use InSpec.
Signed-off-by: Adam Leff <adam@leff.co>
|
|
|
|
|
|
|
|
|
| |
This implements RFC 67, which removes cookbook segments, and moves to a
single list of all the files contained in a cookbook. This allows us to
move forward with better audit modes and also proper shipping of ohai
plugins.
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
nokogiri does not have a ruby-2.4 release for windows
this is slightly complicated because we still need nokogiri in the
Gemfile.lock for travis.
i'm starting to think we should have a Gemfile.travis and
Gemfile.travis.lock or something and stop using groups for that.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
| |
https://github.com/sparklemotion/nokogiri/issues/1615
This is required to pass the bundle-audit check in Travis CI
Change-Id: Ia34db5b0595b88560fdff36a451df7567907e727
Signed-off-by: Maxime Brugidou <m.brugidou@criteo.com>
|
|
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
|\
| |
| | |
Improve version bumping
|
| |
| |
| |
| | |
Signed-off-by: Tom Duffield <tom@chef.io>
|
|/
|
|
|
|
|
|
|
|
|
| |
This requires pulling in master of several gems, bumps all
the other gems, plus pulls in new kitchen-appbundle-updater
which supports pulling master of ohai.
Note that kitchen-windows is disabled because it turns out
it was broken and red on 12.19 all along.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Tom Duffield <tom@chef.io>
|
|
|
|
| |
Signed-off-by: Tom Duffield <tom@chef.io>
|
|
|
|
| |
Signed-off-by: Tom Duffield <tom@chef.io>
|
|
|
|
|
|
| |
blocks testing on ruby 2.4
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This branch fixes a number of bugs in the changelog generator, and
supports the type of behavior that we want when generating our
changelog. There is a PR open against
upstream (skywinder/github-changelog-generator#453) to merge this
upstream.
As part of this, we can now generate the changelog on every commit.
Signed-off-by: Tom Duffield <tom@chef.io>
|
|
|
|
|
|
|
|
| |
and its now officially deprecated in its README:
https://github.com/thommay/chef-rewind
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
| |
|
|
|
|
|
| |
See https://github.com/chef/chef-dk/pull/937
and https://github.com/chef/chef/issues/5116
|
|
|
|
| |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
|
|
| |
Rack 2.0 was released today and it requires Ruby 2.2+ now, which is
breaking Travis runs on anything that depends on Chef. This should get
our builds running again.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(we have a lockfile now, so we are protected against inadvertent updates)
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|