summaryrefslogtreecommitdiff
path: root/kitchen-tests
Commit message (Collapse)AuthorAgeFilesLines
* Update InSpec kitchen testsTim Smith2020-11-101-2/+2
| | | | | | Get the correct format here Signed-off-by: Tim Smith <tsmith@chef.io>
* Add homebrew to macos kitchen tests.Pete Higgins2020-11-021-0/+10
| | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
* Add back Oracle 8 Test Kitchen testingTim Smith2020-10-261-0/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* ifconfig is not compatible with Fedora 33 or laterTim Smith2020-10-261-0/+2
| | | | | | This resource only works with the legacy redhat /etc/networks configuration format. That format was slapped onto NetworkManager when RHEL moved off legacy init scripts. Fedora 33 switches to the keyfile format so this resource no longer works on those systems. Stop testing it there and add a note to the resource description so we get that up on the docs site. Signed-off-by: Tim Smith <tsmith@chef.io>
* Add Test Kitchen testing on Ubuntu 20.10ubuntu_2010Tim Smith2020-10-261-0/+8
| | | | | | | | We can bump this up to the latest non-LTS release every 6 months to determine if there's any resource updates we need to make in advance of the LTS release. Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove insserv-compat from opensuse now that it's there by defaultTim Smith2020-10-191-2/+1
| | | | | | This is in the dokken image now. Signed-off-by: Tim Smith <tsmith@chef.io>
* Make sure we have net-tools-deprecated on our SLES testerTim Smith2020-10-191-2/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* See if we can get Ubuntu/Debian workingTim Smith2020-10-191-0/+4
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Test ifconfig in Test Kitchen and add examples to the resourcetest_ifconfigTim Smith2020-10-192-0/+14
| | | | | | We lacked an actual test of this resource. Let's see if it works. Signed-off-by: Tim Smith <tsmith@chef.io>
* Dry up testing a bitTim Smith2020-10-125-37/+15
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add additional_config propertyTim Smith2020-10-124-1/+23
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add InSpec testTim Smith2020-10-121-0/+10
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove the unused debian-8 kitchen configTim Smith2020-10-121-7/+0
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Switch off our fork of docker-apiTim Smith2020-10-121-4/+1
| | | | | | 2.0 is out with Ruby 2.7 support Signed-off-by: Tim Smith <tsmith@chef.io>
* chef_client_config resourceTim Smith2020-10-124-10/+18
| | | | | | Initial stab at a chef_client_config resource that will allow people to easily write out a client.rb. This isn't meant to cover every single use case, but instead to provide a simple resource that works for 99% of users. Signed-off-by: Tim Smith <tsmith@chef.io>
* something was added that shouldn't have been in this PR.Davin Taddeo2020-09-301-5/+0
| | | | Signed-off-by: Davin Taddeo <davin@chef.io>
* updates from reviewDavin Taddeo2020-09-301-4/+4
| | | | Signed-off-by: Davin Taddeo <davin@chef.io>
* fix for the windows_audit_policy resource and added some tests for it into ↵Davin Taddeo2020-09-301-0/+24
| | | | | | the windows end-to-end kitchen testing. Signed-off-by: Davin Taddeo <davin@chef.io>
* some modifications to make the allowed privilege list a little easier to ↵Davin Taddeo2020-09-111-1/+1
| | | | | | sort through. And a chefstyle fix Signed-off-by: Davin Taddeo <davin@chef.io>
* A validation update to the windows_user_privilege resource I believe will ↵Davin Taddeo2020-09-111-0/+5
| | | | assist with issue #10420
* Update the windows_firewall_profile resource to move the load_firewall_state ↵Davin Taddeo2020-09-101-0/+10
| | | | | | method out of the action_class. Also add some firewall tests to the kitchen tests to avoid this issue in the future. Signed-off-by: Davin Taddeo <davin@chef.io>
* Update kitchen-tests/cookbooks/end_to_end/recipes/linux.rb niceTim Smith2020-09-031-1/+1
| | | | | Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
* chef_client_systemd_timer: Add the ability to set CPUQuota on the ↵Tim Smith2020-09-031-0/+1
| | | | | | | | chef-client unit This allows us to set a quota like 50% on everything handled by the chef-client including all the sub-processes like ohai or inspec. I looked at using systemd's nice functionality since that would give us a unified property for all the *nix processes, but that only applies to the chef-client process itself. This is much more powerful and gives users what user's probably really want which is "chef and all its stuff should not consume all the CPU on my host". Signed-off-by: Tim Smith <tsmith@chef.io>
* removed unnecessary 'ostruct' from linux mount provider spec.antima-gupta2020-08-282-1/+1
| | | | | | | Added permalink for Regex. Renamed the linux_mount recipe file to mount in kitechen-tests. Signed-off-by: antima-gupta <agupta@msystechnologies.com>
* Fixed mount Resource for bind mounts is not idempotent.antima-gupta2020-08-272-0/+21
| | | | | | | | Added a separate linux mount provider. Define 'mounted?' method and used 'findmnt -rn' command to list mount points along with device. Added linux_mount recipe to kitchen-tests. Signed-off-by: antima-gupta <agupta@msystechnologies.com>
* Add kitchen testing of the chef_client_launchd resourceTim Smith2020-08-251-0/+5
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add new chef_client_trusted_certificate resourceTim Smith2020-08-194-0/+33
| | | | | | | | This is a pretty simple resource for something that users can certainly do on their own right now, but most people don't even realize is an option. Giving it a dedicated resource exposes the functionality better and just makes it that much easier to write a simple cross platform cookbook that involves configuring the client. I'm not a huge fan of having to provide the certificate as a string, but I didn't want to add yet another place where we allow string values, or URI. They all have slightly different APIs and we need to just do it via a mixin or something. This can certainly move that direction in the future, but for this solves a real problem today. Signed-off-by: Tim Smith <tsmith@chef.io>
* Better specify how to set timezones on windowsTim Smith2020-08-181-1/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Refactor the timezone resource to properly load the current timezoneTim Smith2020-08-182-2/+2
| | | | | | This way we get a proper state change instead of just showing a converge. This also removes awk/grep in not_if statements and overall improves logging. Signed-off-by: Tim Smith <tsmith@chef.io>
* Fix chefstyle in the Test Kitchen testmac_testingTim Smith2020-08-181-2/+2
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Further improve osx_profile error message and add a testTim Smith2020-08-181-0/+5
| | | | | | Make sure we can execute the resource in a Test Kitchen run. Signed-off-by: Tim Smith <tsmith@chef.io>
* chef_client_systemd_timer: Fix failures in the :remove actionTim Smith2020-08-071-0/+4
| | | | | | Get the actual systemd action right. Add a kitchen test for this as well. Signed-off-by: Tim Smith <tsmith@chef.io>
* Update RuboCop config to Ruby 2.6Tim Smith2020-08-031-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the redundant begins ``` kitchen-tests/cookbooks/end_to_end/recipes/_chef-vault.rb:36:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. kitchen-tests/cookbooks/end_to_end/recipes/_chef-vault.rb:36:5: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ kitchen-tests/cookbooks/end_to_end/recipes/_chef-vault.rb:37:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. chef_vault_item("creds", "super_secret_1") ^^^^ kitchen-tests/cookbooks/end_to_end/recipes/_chef-vault.rb:38:5: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 38, 4 is not aligned with block do at 35, 2. rescue ChefVault::Exceptions::SecretDecryption ^^^^^^ kitchen-tests/cookbooks/end_to_end/recipes/_chef-vault.rb:40:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/application/apply.rb:216:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/application/apply.rb:216:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/application/apply.rb:217:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. runner.converge ^^^^ lib/chef/application/apply.rb:218:7: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 218, 6 is not aligned with catch(:end_client_run_early) do at 215, 4. ensure ^^^^^^ lib/chef/application/apply.rb:220:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/application/windows_service.rb:81:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/application/windows_service.rb:81:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/application/windows_service.rb:82:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Chef::Log.info("Next #{Chef::Dist::CLIENT} run will happen in #{timeout} seconds") ^^^^ lib/chef/application/windows_service.rb:101:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 101, 12 is not aligned with @service_action_mutex.synchronize do at 80, 10. rescue SystemExit => e ^^^^^^ lib/chef/application/windows_service.rb:105:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 105, 12 is not aligned with @service_action_mutex.synchronize do at 80, 10. rescue Exception => e ^^^^^^ lib/chef/application/windows_service.rb:107:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:175:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:175:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:176:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. parent.create_child(name, nil) ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:177:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 177, 12 is not aligned with with_parent_dir(path + [name], *options) do at 174, 10. rescue Chef::ChefFS::FileSystem::AlreadyExistsError => e ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:179:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:254:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:254:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:255:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. parent.create_child(name, data) ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:256:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 256, 12 is not aligned with with_parent_dir(path + [name], *options) do at 253, 10. rescue Chef::ChefFS::FileSystem::AlreadyExistsError => e ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:258:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:352:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:352:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:353:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. entry.read ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:354:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 354, 12 is not aligned with with_entry(path) do at 351, 10. rescue Chef::ChefFS::FileSystem::NotFoundError => e ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:356:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:436:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:436:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:437:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. if %w{cookbooks cookbook_artifacts}.include?(path[0]) && path.length >= 3 ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:442:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 442, 12 is not aligned with with_entry(path) do at 435, 10. rescue Chef::ChefFS::FileSystem::NotFoundError => e ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:444:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:474:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:474:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:475:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. entry.delete(options.include?(:recursive)) ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:476:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 476, 12 is not aligned with with_entry(path) do at 473, 10. rescue Chef::ChefFS::FileSystem::NotFoundError => e ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:478:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:490:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:490:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:491:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. policies.children.map { |policy| policy.name[0..-6].rpartition("-")[0] }.uniq ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:492:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 492, 12 is not aligned with with_entry([ path[0] ]) do at 489, 10. rescue Chef::ChefFS::FileSystem::NotFoundError ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:494:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:527:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:527:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:528:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. if path[0] == "cookbook_artifacts" ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:536:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 536, 12 is not aligned with with_entry(path) do at 526, 10. rescue Chef::ChefFS::FileSystem::NotFoundError ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:539:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:563:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/chef_fs_data_store.rb:563:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:564:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. entry.children.map { |c| zero_filename(c) }.sort ^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:565:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 565, 12 is not aligned with result at 562, 10. rescue Chef::ChefFS::FileSystem::NotFoundError => e ^^^^^^ lib/chef/chef_fs/chef_fs_data_store.rb:572:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/chef_server/acl_entry.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/chef_server/acl_entry.rb:50:15: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/file_system/chef_server/acl_entry.rb:51:13: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. rest.put("#{api_path}/#{permission}", { permission => acls[permission] }) ^^^^ lib/chef/chef_fs/file_system/chef_server/acl_entry.rb:52:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 52, 14 is not aligned with PERMISSIONS.each do at 49, 12. rescue Timeout::Error => e ^^^^^^ lib/chef/chef_fs/file_system/chef_server/acl_entry.rb:54:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 54, 14 is not aligned with PERMISSIONS.each do at 49, 12. rescue Net::HTTPClientException => e ^^^^^^ lib/chef/chef_fs/file_system/chef_server/acl_entry.rb:60:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb:47:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb:47:15: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb:48:13: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. rest.post(api_path, { "user" => invite }) ^^^^ lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb:49:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 49, 14 is not aligned with (desired_invites - invites).each do at 46, 12. rescue Net::HTTPClientException => e ^^^^^^ lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb:55:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb:46:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb:46:15: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb:47:13: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. rest.post(api_path, "username" => member) ^^^^ lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb:48:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 48, 14 is not aligned with (desired_members - members).each do at 45, 12. rescue Net::HTTPClientException => e ^^^^^^ lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb:54:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb:112:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb:112:17: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb:113:15: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. ::FileUtils.mkdir_p(path) ^^^^ lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb:127:17: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 127, 16 is not aligned with child_paths[name].each do at 111, 14. rescue Errno::EEXIST ^^^^^^ lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb:128:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/client.rb:710:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/client.rb:710:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/client.rb:711:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. events.converge_start(run_context) ^^^^ lib/chef/client.rb:716:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 716, 8 is not aligned with catch(:end_client_run_early) do at 709, 6. rescue Exception => e ^^^^^^ lib/chef/client.rb:719:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/dsl/platform_introspection.rb:82:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/dsl/platform_introspection.rb:82:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/dsl/platform_introspection.rb:83:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. if Chef::VersionConstraint::Platform.new(k).include?(node_version) ^^^^ lib/chef/dsl/platform_introspection.rb:86:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 86, 12 is not aligned with keys.each do at 81, 10. rescue Chef::Exceptions::InvalidVersionConstraint => e ^^^^^^ lib/chef/dsl/platform_introspection.rb:89:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/file_content_management/tempfile.rb:42:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/file_content_management/tempfile.rb:42:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/file_content_management/tempfile.rb:43:13: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 12 instead of 10). # preserving the file extension of the target filename should be considered a public API ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/chef/file_content_management/tempfile.rb:44:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. tf = ::Tempfile.open([tempfile_basename, tempfile_extension], tempfile_dirname) ^^^^ lib/chef/file_content_management/tempfile.rb:46:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 46, 10 is not aligned with tempfile_dirnames.each do at 41, 8. rescue SystemCallError => e ^^^^^^ lib/chef/file_content_management/tempfile.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/cookbook_upload.rb:135:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/cookbook_upload.rb:135:17: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/knife/cookbook_upload.rb:136:15: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. upload([cookbook], justify_width) ^^^^ lib/chef/knife/cookbook_upload.rb:138:17: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 138, 16 is not aligned with tmp_cl.each do at 134, 14. rescue Exceptions::CookbookNotFoundInRepo => e ^^^^^^ lib/chef/knife/cookbook_upload.rb:143:17: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 143, 16 is not aligned with tmp_cl.each do at 134, 14. rescue Exceptions::CookbookFrozen ^^^^^^ lib/chef/knife/cookbook_upload.rb:146:17: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 146, 16 is not aligned with tmp_cl.each do at 134, 14. rescue SystemExit => e ^^^^^^ lib/chef/knife/cookbook_upload.rb:148:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/cookbook_upload.rb:175:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/cookbook_upload.rb:175:15: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/knife/cookbook_upload.rb:176:13: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. unless upload_set.key?(cookbook_name) ^^^^ lib/chef/knife/cookbook_upload.rb:182:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 182, 14 is not aligned with @name_args.each do at 174, 12. rescue Exceptions::CookbookNotFoundInRepo => e ^^^^^^ lib/chef/knife/cookbook_upload.rb:185:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/delete.rb:99:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/delete.rb:99:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/knife/delete.rb:100:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. result.delete(config[:recurse]) ^^^^ lib/chef/knife/delete.rb:103:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 103, 10 is not aligned with results.each do at 98, 8. rescue Chef::ChefFS::FileSystem::NotFoundError ^^^^^^ lib/chef/knife/delete.rb:105:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 105, 10 is not aligned with results.each do at 98, 8. rescue Chef::ChefFS::FileSystem::MustDeleteRecursivelyError => e ^^^^^^ lib/chef/knife/delete.rb:109:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 109, 10 is not aligned with results.each do at 98, 8. rescue Chef::ChefFS::FileSystem::OperationNotAllowedError => e ^^^^^^ lib/chef/knife/delete.rb:113:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/ssh.rb:528:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/ssh.rb:528:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/knife/ssh.rb:529:13: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 12 instead of 10). # Unix and Mac only ^^^^^^^^^^^^^^^^^^^ lib/chef/knife/ssh.rb:530:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. cssh_cmd = shell_out!("which #{cmd}").stdout.strip ^^^^ lib/chef/knife/ssh.rb:532:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 532, 10 is not aligned with %w{csshX cssh}.each do at 527, 8. rescue Mixlib::ShellOut::ShellCommandFailed ^^^^^^ lib/chef/knife/ssh.rb:533:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/xargs.rb:207:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/knife/xargs.rb:207:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/knife/xargs.rb:208:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. value = file[:file].read ^^^^ lib/chef/knife/xargs.rb:213:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 213, 10 is not aligned with tempfiles.each_pair do at 206, 8. rescue Chef::ChefFS::FileSystem::OperationNotAllowedError => e ^^^^^^ lib/chef/knife/xargs.rb:219:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 219, 10 is not aligned with tempfiles.each_pair do at 206, 8. rescue Chef::ChefFS::FileSystem::NotFoundError => e ^^^^^^ lib/chef/knife/xargs.rb:225:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/monkey_patches/webrick-utils.rb:36:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/monkey_patches/webrick-utils.rb:36:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/monkey_patches/webrick-utils.rb:37:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. logger.debug("TCPServer.new(#{ai[3]}, #{port})") if logger ^^^^ lib/chef/monkey_patches/webrick-utils.rb:42:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 42, 8 is not aligned with res.each do at 35, 6. rescue => ex ^^^^^^ lib/chef/monkey_patches/webrick-utils.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/git.rb:47:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/git.rb:47:15: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/provider/git.rb:48:13: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. get_homedir(new_resource.user) ^^^^ lib/chef/provider/git.rb:49:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 49, 14 is not aligned with a.assertion do at 46, 12. rescue ArgumentError ^^^^^^ lib/chef/provider/git.rb:51:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/group/suse.rb:42:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/group/suse.rb:42:15: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/provider/group/suse.rb:43:13: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. to_add(new_resource.members).all? { |member| Etc.getpwnam(member) } ^^^^ lib/chef/provider/group/suse.rb:44:15: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 44, 14 is not aligned with a.assertion do at 41, 12. rescue ^^^^^^ lib/chef/provider/group/suse.rb:46:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/package/windows/registry_uninstall_entry.rb:40:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/package/windows/registry_uninstall_entry.rb:40:21: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/provider/package/windows/registry_uninstall_entry.rb:41:19: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. entry = reg.open(key, desired) ^^^^ lib/chef/provider/package/windows/registry_uninstall_entry.rb:47:21: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 47, 20 is not aligned with reg.each_key do at 39, 18. rescue ::Win32::Registry::Error => ex ^^^^^^ lib/chef/provider/package/windows/registry_uninstall_entry.rb:49:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/service/windows.rb:98:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/service/windows.rb:98:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/provider/service/windows.rb:99:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Win32::Service.start(@new_resource.service_name) ^^^^ lib/chef/provider/service/windows.rb:100:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 100, 12 is not aligned with spawn_command_thread do at 97, 10. rescue SystemCallError => ex ^^^^^^ lib/chef/provider/service/windows.rb:108:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/user/mac.rb:586:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/provider/user/mac.rb:586:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/provider/user/mac.rb:587:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. run_dscl("read", "/Users/#{new_resource.username}", "ShadowHashData") ^^^^ lib/chef/provider/user/mac.rb:589:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 589, 12 is not aligned with loop do at 585, 10. rescue Chef::Exceptions::DsclCommandFailed => e ^^^^^^ lib/chef/provider/user/mac.rb:595:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/resource.rb:666:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/resource.rb:666:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/resource.rb:667:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. all_props[p.name.to_s] = p.sensitive? ? '"*sensitive value suppressed*"' : value_to_text(p.get(self)) ^^^^ lib/chef/resource.rb:668:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 668, 8 is not aligned with self.class.state_properties.map do at 665, 6. rescue Chef::Exceptions::ValidationFailed ^^^^^^ lib/chef/resource.rb:669:11: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 10 instead of 8). # This space left intentionally blank, the property was probably required or had an invalid default. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/chef/resource.rb:670:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/resource/chef_vault_secret.rb:76:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/resource/chef_vault_secret.rb:76:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/resource/chef_vault_secret.rb:77:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. item = ChefVault::Item.load(data_bag, id) ^^^^ lib/chef/resource/chef_vault_secret.rb:82:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 82, 8 is not aligned with load_current_value do at 75, 6. rescue ChefVault::Exceptions::SecretDecryption ^^^^^^ lib/chef/resource/chef_vault_secret.rb:84:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 84, 8 is not aligned with load_current_value do at 75, 6. rescue ChefVault::Exceptions::KeysNotFound ^^^^^^ lib/chef/resource/chef_vault_secret.rb:86:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 86, 8 is not aligned with load_current_value do at 75, 6. rescue Net::HTTPClientException => e ^^^^^^ lib/chef/resource/chef_vault_secret.rb:88:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/resource/sysctl.rb:131:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/resource/sysctl.rb:131:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/resource/sysctl.rb:132:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. value get_sysctl_value(key) ^^^^ lib/chef/resource/sysctl.rb:133:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 133, 8 is not aligned with load_current_value do at 130, 6. rescue ^^^^^^ lib/chef/resource/sysctl.rb:135:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/run_context/cookbook_compiler.rb:172:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/run_context/cookbook_compiler.rb:172:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/run_context/cookbook_compiler.rb:173:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. path = resolve_recipe(recipe) ^^^^ lib/chef/run_context/cookbook_compiler.rb:176:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 176, 10 is not aligned with run_list_expansion.recipes.each do at 171, 8. rescue Chef::Exceptions::RecipeNotFound => e ^^^^^^ lib/chef/run_context/cookbook_compiler.rb:179:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 179, 10 is not aligned with run_list_expansion.recipes.each do at 171, 8. rescue Exception => e ^^^^^^ lib/chef/run_context/cookbook_compiler.rb:182:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/run_context/cookbook_compiler.rb:234:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/run_context/cookbook_compiler.rb:234:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/run_context/cookbook_compiler.rb:235:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. logger.trace("Loading cookbook #{cookbook_name}'s library file: #{filename}") ^^^^ lib/chef/run_context/cookbook_compiler.rb:238:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 238, 10 is not aligned with each_file_in_cookbook_by_segment(cookbook_name, :libraries, globs) do at 233, 8. rescue Exception => e ^^^^^^ lib/chef/run_context/cookbook_compiler.rb:241:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/util/diff.rb:109:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/util/diff.rb:109:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/util/diff.rb:110:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. hunk = ::Diff::LCS::Hunk.new(old_data, new_data, piece, 3, file_length_difference) ^^^^ lib/chef/util/diff.rb:116:11: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 116, 10 is not aligned with diff_data.each do at 108, 8. ensure ^^^^^^ lib/chef/util/diff.rb:118:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/win32/file/version_info.rb:52:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/chef/win32/file/version_info.rb:52:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ lib/chef/win32/file/version_info.rb:53:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. get_version_info_string(method.to_s) ^^^^ lib/chef/win32/file/version_info.rb:54:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 54, 12 is not aligned with define_method method do at 51, 10. rescue Chef::Exceptions::Win32APIError ^^^^^^ lib/chef/win32/file/version_info.rb:56:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/resource/group_spec.rb:310:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/resource/group_spec.rb:310:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/resource/group_spec.rb:311:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. gid = rand(2000..9999) # avoid low group numbers ^^^^ spec/functional/resource/group_spec.rb:313:7: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 313, 6 is not aligned with loop do at 309, 4. rescue ArgumentError # group does not exist ^^^^^^ spec/functional/resource/group_spec.rb:315:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/resource/link_spec.rb:58:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/resource/link_spec.rb:58:5: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/resource/link_spec.rb:59:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. cleanup_link(to) if File.exists?(to) ^^^^ spec/functional/resource/link_spec.rb:62:5: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 62, 4 is not aligned with after(:each) do at 57, 2. rescue ^^^^^^ spec/functional/resource/link_spec.rb:64:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/resource/powershell_script_spec.rb:276:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/resource/powershell_script_spec.rb:276:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/resource/powershell_script_spec.rb:277:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. expect(resource.architecture(:x86_64)).to raise_error Chef::Exceptions::Win32ArchitectureIncorrect ^^^^ spec/functional/resource/powershell_script_spec.rb:278:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 278, 8 is not aligned with it "raises an exception if :x86_64 process architecture is specified" do at 275, 6. rescue Chef::Exceptions::Win32ArchitectureIncorrect ^^^^^^ spec/functional/resource/powershell_script_spec.rb:279:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/run_lock_spec.rb:64:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/run_lock_spec.rb:64:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/run_lock_spec.rb:65:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. p1.stop ^^^^ spec/functional/run_lock_spec.rb:67:7: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 67, 6 is not aligned with after(:each) do at 63, 4. rescue ^^^^^^ spec/functional/run_lock_spec.rb:70:7: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 70, 6 is not aligned with after(:each) do at 63, 4. ensure ^^^^^^ spec/functional/run_lock_spec.rb:74:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/run_lock_spec.rb:448:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/run_lock_spec.rb:448:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/run_lock_spec.rb:449:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Timeout.timeout(CLIENT_PROCESS_TIMEOUT) do ^^^^ spec/functional/run_lock_spec.rb:459:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 459, 8 is not aligned with @pid at 447, 6. rescue ^^^^^^ spec/functional/run_lock_spec.rb:462:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/win32/registry_spec.rb:270:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/win32/registry_spec.rb:270:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/win32/registry_spec.rb:271:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. reg.delete_key("Trunk", true) ^^^^ spec/functional/win32/registry_spec.rb:272:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 272, 8 is not aligned with ::Win32::Registry::HKEY_CURRENT_USER.open("Software\\Root") do at 269, 6. rescue ^^^^^^ spec/functional/win32/registry_spec.rb:273:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/win32/registry_spec.rb:365:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/functional/win32/registry_spec.rb:365:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/functional/win32/registry_spec.rb:366:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. reg.delete_key("Red", true) ^^^^ spec/functional/win32/registry_spec.rb:367:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 367, 8 is not aligned with ::Win32::Registry::HKEY_CURRENT_USER.open("Software\\Root\\Trunk") do at 364, 6. rescue ^^^^^^ spec/functional/win32/registry_spec.rb:368:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/integration/knife/common_options_spec.rb:128:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/integration/knife/common_options_spec.rb:128:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/integration/knife/common_options_spec.rb:129:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. @server = ChefZero::Server.new(host: "localhost", port: 8889) ^^^^ spec/integration/knife/common_options_spec.rb:131:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 131, 8 is not aligned with before :each do at 127, 6. rescue Errno::EADDRINUSE ^^^^^^ spec/integration/knife/common_options_spec.rb:132:11: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 10 instead of 8). # OK. Don't care who has it in use, as long as *someone* does. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/integration/knife/common_options_spec.rb:133:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/integration/knife/common_options_spec.rb:147:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/integration/knife/common_options_spec.rb:147:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/integration/knife/common_options_spec.rb:148:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. @server = ChefZero::Server.new(host: "localhost", port: 9999) ^^^^ spec/integration/knife/common_options_spec.rb:150:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 150, 8 is not aligned with before :each do at 146, 6. rescue Errno::EADDRINUSE ^^^^^^ spec/integration/knife/common_options_spec.rb:151:11: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 10 instead of 8). # OK. Don't care who has it in use, as long as *someone* does. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/integration/knife/common_options_spec.rb:152:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/integration/knife/serve_spec.rb:29:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/integration/knife/serve_spec.rb:29:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/integration/knife/serve_spec.rb:30:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. knife("serve --chef-zero-port=8890") ^^^^ spec/integration/knife/serve_spec.rb:31:7: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 31, 6 is not aligned with t at 28, 4. rescue ^^^^^^ spec/integration/knife/serve_spec.rb:33:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/spec_helper.rb:300:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/spec_helper.rb:300:5: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/spec_helper.rb:301:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. ex.run ^^^^ spec/spec_helper.rb:302:5: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 302, 4 is not aligned with config.around(:example) do at 299, 2. rescue SystemExit => e ^^^^^^ spec/spec_helper.rb:304:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/shared/functional/file_resource.rb:479:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/shared/functional/file_resource.rb:479:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/support/shared/functional/file_resource.rb:480:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Chef::Config[:why_run] = true ^^^^ spec/support/shared/functional/file_resource.rb:482:11: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 482, 10 is not aligned with it "issues a warning/assumption in whyrun mode" do at 478, 8. ensure ^^^^^^ spec/support/shared/functional/file_resource.rb:484:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/shared/functional/file_resource.rb:507:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/shared/functional/file_resource.rb:507:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/support/shared/functional/file_resource.rb:508:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Chef::Config[:why_run] = true ^^^^ spec/support/shared/functional/file_resource.rb:510:11: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 510, 10 is not aligned with it "issues a warning/assumption in whyrun mode" do at 506, 8. ensure ^^^^^^ spec/support/shared/functional/file_resource.rb:512:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/shared/functional/file_resource.rb:538:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/shared/functional/file_resource.rb:538:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/support/shared/functional/file_resource.rb:539:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Chef::Config[:why_run] = true ^^^^ spec/support/shared/functional/file_resource.rb:541:11: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 541, 10 is not aligned with it "issues a warning/assumption in whyrun mode" do at 537, 8. ensure ^^^^^^ spec/support/shared/functional/file_resource.rb:543:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:107:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:107:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/mixin/template_spec.rb:108:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. tf = Tempfile.new("partial") ^^^^ spec/unit/mixin/template_spec.rb:114:7: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 114, 6 is not aligned with it "should render local files" do at 106, 4. ensure ^^^^^^ spec/unit/mixin/template_spec.rb:116:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:127:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:127:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/mixin/template_spec.rb:128:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. tf = Tempfile.new("partial") ^^^^ spec/unit/mixin/template_spec.rb:134:7: C: [Corrected] Layout/RescueEnsureAlignment: ensure at 134, 6 is not aligned with it "should render using the source argument if provided" do at 126, 4. ensure ^^^^^^ spec/unit/mixin/template_spec.rb:136:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:198:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:198:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/mixin/template_spec.rb:199:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. do_raise ^^^^ spec/unit/mixin/template_spec.rb:200:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 200, 10 is not aligned with subject(:exception) do at 197, 8. rescue Chef::Mixin::Template::TemplateError => e ^^^^^^ spec/unit/mixin/template_spec.rb:202:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:277:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/template_spec.rb:277:9: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/mixin/template_spec.rb:278:7: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. do_raise ^^^^ spec/unit/mixin/template_spec.rb:279:9: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 279, 8 is not aligned with before :each do at 276, 6. rescue Chef::Mixin::Template::TemplateError => e ^^^^^^ spec/unit/mixin/template_spec.rb:281:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/windows_architecture_helper_spec.rb:53:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/mixin/windows_architecture_helper_spec.rb:53:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/mixin/windows_architecture_helper_spec.rb:54:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. expect(assert_valid_windows_architecture!(architecture)).to raise_error Chef::Exceptions::Win32ArchitectureIncorrect ^^^^ spec/unit/mixin/windows_architecture_helper_spec.rb:55:7: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 55, 6 is not aligned with @invalid_architectures.each do at 52, 4. rescue Chef::Exceptions::Win32ArchitectureIncorrect ^^^^^^ spec/unit/mixin/windows_architecture_helper_spec.rb:56:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/node_spec.rb:1776:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/node_spec.rb:1776:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/node_spec.rb:1777:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. response.error! ^^^^ spec/unit/node_spec.rb:1778:13: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 1778, 12 is not aligned with let(:http_exception) do at 1775, 10. rescue => e ^^^^^^ spec/unit/node_spec.rb:1780:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/provider/remote_directory_spec.rb:204:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/provider/remote_directory_spec.rb:204:11: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/provider/remote_directory_spec.rb:205:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. @fclass.file_class.symlink(tmp_dir.dup, symlinked_dir_path) ^^^^ spec/unit/provider/remote_directory_spec.rb:212:11: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 212, 10 is not aligned with Dir.mktmpdir do at 203, 8. rescue Chef::Exceptions::Win32APIError ^^^^^^ spec/unit/provider/remote_directory_spec.rb:214:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/provider_resolver_spec.rb:57:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/unit/provider_resolver_spec.rb:57:7: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ spec/unit/provider_resolver_spec.rb:58:5: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. resource ? resource.provider_for_action(action).class : nil ^^^^ spec/unit/provider_resolver_spec.rb:59:7: C: [Corrected] Layout/RescueEnsureAlignment: rescue at 59, 6 is not aligned with let(:resolved_provider) do at 56, 4. rescue Chef::Exceptions::ProviderNotFound ^^^^^^ spec/unit/provider_resolver_spec.rb:61:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. 1783 files inspected, 306 offenses detected, 306 offenses corrected ``` Signed-off-by: Tim Smith <tsmith@chef.io>
* Add end-to-end hostname testingTim Smith2020-07-271-0/+4
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Avoid spelling warningTim Smith2020-07-211-1/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add testing of :delete action and fix failuresTim Smith2020-07-211-4/+18
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add additional Test Kitchen testsTim Smith2020-07-211-1/+30
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Fix case in test resourceTim Smith2020-07-201-1/+1
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Rework macos_userdefaults resourceTim Smith2020-07-201-2/+8
| | | | | | This is a reboot of sorts on the macos_userdefaults resource to fix some fundamental flaws in the UX of the resource and how it gets state / sets the values. Signed-off-by: Tim Smith <tsmith@chef.io>
* Test build_essential installation in Kitchenbuild_essential_mac_outputTim Smith2020-07-011-0/+2
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* add windows_security_policy to the windows end-to-end kitchen testDavin Taddeo2020-06-181-0/+5
| | | | Signed-off-by: Davin Taddeo <davin@chef.io>
* updates for chefstyle and spellcheck errorsDavin Taddeo2020-06-151-1/+1
| | | | Signed-off-by: Davin Taddeo <davin@chef.io>
* Chefstyle fixesTim Smith2020-06-141-5/+5
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Disable snap dokken tests for nowTim Smith2020-06-141-1/+4
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Add kitchen tests for snapdPhil Dibowitz2020-06-142-0/+15
| | | | Signed-off-by: Phil Dibowitz <phil@ipom.com>
* Add specs and rename fingerprint -> short idzypper_repositoryTim Smith2020-06-051-1/+1
| | | | | | | | These aren't actually fingerprints. They're short key ids https://futureboy.us/pgp.html#ShortKeyID Signed-off-by: Tim Smith <tsmith@chef.io>
* Change how we get the fingerprint againTim Smith2020-06-041-1/+1
| | | | | | It turns out the string I was matching on before was actually an error message to stderr. We can't rely on that. Signed-off-by: Tim Smith <tsmith@chef.io>
* Add a kitchen test for zypper_repositoryTim Smith2020-06-042-0/+14
| | | | | | Setup the nginx repo Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove the sudo testTim Smith2020-05-291-7/+0
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Swap TunnelBlick for a smaller dmgTim Smith2020-05-291-3/+3
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
View Lorry Controller Status