| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
| |
|
|
|
|
| |
cookbooks and updated tests
|
|
|
|
| |
before attempting to upload
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileVendor previously was configured by storing a closure/anonymous
function as a class instance variable. This had the following downsides:
* The API was too general, which caused a lot of code repetition
* The block was lazily evaluated, which hid errors and made testing more
difficult
* The closures captured references to classes with references to large
data structures, which complicates GC.
Since we've only ever had the same two implementations of FileVendor, we
can encapsulate configuration of the FileVendor factory by wrapping each
configuration option in a method. As a side benefit, arguments to these
methods will be eagerly evaluated, which makes it easier to detect
errors.
|
| |
|
|
|
|
| |
with #reject
|
| |
|
| |
|
|
|
|
|
|
|
| |
This change make Chef::CookbookUploader for testing whether a cookbook
upload has failed due to a frozen version existing on the server.
This fixes a regression introduced by 7c7b4ea1.
|
| |
|
|
|
|
| |
Chef::Version::Platform class, reverting Chef::Version class changes
|
|
|
|
| |
new classes created: Chef::Version::Cookbook and Chef::VersionConstraint::Cookbook
|
|
|
|
|
|
|
|
|
| |
User was getting an error message:
> ERROR: Cookbook git depends on cookbook runit, version >= 0.0.0,
Issue was the metadata for git had a dependency on 'runit,'. Should
probably also add validation to metadata depends for cookbook names, but
generally quoting user-supplied values in error messages makes this kind
of issue more obvious, so this should be a worthwhile quick fix.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cookbooks could be uploaded individually, but attempting to load all at once was resulting in the following error against Chef 11 servers:
ERROR: The data in your request was invalid
Response: Field 'checksums' invalid
The immediate cause of this message is that knife was trying to create a sandbox with no files, which we explicitly forbid on Chef 11.
The ultimate cause of this was introduced on August 14, 2012 with commit 70c019f3. It appears this was an incomplete refactoring of the CookbookLoader class. Before the refactoring, a cookbook loader would load its cookbooks lazily in each method that needed them. The refactoring made this explicit, but an explicit call was not added to the knife cookbook upload command.
This addresses CHEF-3638.
|
|
The opscode/chef repository now only contains the core Chef library code
used by chef-client, knife and chef-solo!
|