summaryrefslogtreecommitdiff
path: root/lib/chef/knife/core
Commit message (Collapse)AuthorAgeFilesLines
* Kill JSON auto inflate with firetm/remove_json_autoinflateThom May2017-03-141-2/+1
| | | | Signed-off-by: Thom May <thom@chef.io>
* Require chef/version when trying to read iter-478/fips_bootstrapTyler Ball2017-02-231-7/+8
| | | | | | | | | | | | | | | | When a node is bootstrapped in FIPS mode and then tries to run a chef-client run it gets the following error: ``` STDERR: /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-config-12.18.31/lib/chef-config/workstation_config_loader.rb:163:in `rescue in apply_config': You have an error in your config file /var/opt/delivery/workspace/.chef/knife.rb (ChefConfig::ConfigurationError) NameError: uninitialized constant Chef /var/opt/delivery/workspace/.chef/knife.rb:2:in `eval' /var/opt/delivery/workspace/.chef/knife.rb:2:in `eval' /var/opt/delivery/workspace/.chef/knife.rb:2:in `from_string' ``` Signed-off-by: tyler-ball <tyleraball@gmail.com>
* fix specs: RedundantReturn, RedundantSelf, RedundantBeginLamont Granquist2017-02-134-29/+23
| | | | | | department of redundancy department Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Style/DefWithParenthesesLamont Granquist2016-12-061-1/+1
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Style/SelfAssignmentLamont Granquist2016-12-061-1/+1
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Merge pull request #5502 from ↵Bryan McLellan2016-11-231-1/+25
|\ | | | | | | | | MsysTechnologiesllc/dheeraj/configurable_log_details Knife Bootstrap: Passing config_log_level and config_log_location from config.rb
| * Added specs for config_log_locationdheerajd-msys2016-11-221-7/+5
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
| * Handling remaining values of config_log_locationdheerajd-msys2016-11-181-2/+27
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
| * Passing config_log_level and config_log_location in client.rb and fixed ↵dheerajd-msys2016-11-091-1/+2
| | | | | | | | | | | | specs failure Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
* | Structure deprecations with additional metadatatm/deprecation_with_urlThom May2016-11-162-4/+4
|/ | | | | | | | This adds URLs to each class of deprecation, and correctly prints and formats them for maximum user efficiency. We also provide the URL to the data collector for Visibility to ingest. Signed-off-by: Thom May <thom@chef.io>
* Add the `--field-separator` flag to knife show commandsTom Duffield2016-10-281-1/+13
| | | | | | | | | | | | | For the commands that allow you to filter which attributes it shows you using the `--attribute` flag, add the `--field-separator` flag to allow the user to customize which character(s) they want to use to deliniate the attribute hierarchy. ```shell knife node show NODE -S: -a "packages:Chef Client v12.12.15" ``` Signed-off-by: Tom Duffield <tom@chef.io>
* Make includers of MultiAttributeReturnOption consistentTom Duffield2016-10-281-3/+5
| | | | | | | | Make all the Knife subcommands that include `Chef::Knife::Core::AttributeReturnOption` consistent in how they handle attributes. Signed-off-by: Tom Duffield <tom@chef.io>
* add another spec for chef_environmentLamont Granquist2016-09-201-1/+1
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix method_access and array handling in node presenterLamont Granquist2016-09-201-16/+12
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Style/BlockDelimiters, Style/MultilineBlockLayout and 0.42.0 engine upgradeLamont Granquist2016-08-171-2/+2
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* autofixing Style/MultilineIfThen copLamont Granquist2016-08-161-1/+1
|
* Merge pull request #4059 from yossigo/bootstrap_proxy_authLamont Granquist2016-08-021-0/+10
|\ | | | | Add bootstrap proxy authentication support.
| * Add bootstrap proxy authentication support.Yossi Gottlieb2015-10-141-0/+10
| |
* | correct typo in knife bootstrap contextAndre Elizondo2016-06-231-1/+1
| | | | | | We want client_d, not cliend_d
* | Merge pull request #4670 from tas50/knife_wording-3Tim Smith2016-03-232-2/+2
|\ \ | | | | | | Improve wording in Knife
| * | Single space after periodsTim Smith2016-03-052-2/+2
| | | | | | | | | | | | | | | Double spacing is for typewriters. Knife doesn't run on typewriters http://www.writersdigest.com/online-editor/how-many-spaces-after-a-period
* | | Merge pull request #4707 from chef/lcg/useless-assignmentLamont Granquist2016-03-151-1/+1
|\ \ \ | | | | | | | | fix some UselessAssignment cases
| * | | fix some UselessAssignment caseslcg/useless-assignmentLamont Granquist2016-03-141-1/+1
| | | |
* | | | chefstyle Style/AndOr fixesLamont Granquist2016-03-144-4/+4
|/ / / | | | | | | | | | | | | this is part of our informal style guide, lets make it formal since clearly its not getting followed very well.
* | | s/escape_glob/escape_glob_dir/lcg/fix-escape-globLamont Granquist2016-03-104-9/+9
|/ / | | | | | | | | Removes all remaining references to the deprecated escape_glob helper routine.
* | Merge pull request #4617 from chef/lcg/chefstyle-perfLamont Granquist2016-03-042-3/+4
|\ \ | | | | | | Autofixing new Perf cops in 0.37.2
| * | Autofixing new Perf cops in 0.37.2Lamont Granquist2016-02-232-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6 Performance/Casecmp 18 Performance/Detect 1 Performance/RangeInclude 27 Performance/RedundantBlockCall 6 Performance/RedundantMatch 5 Performance/RedundantMerge 18 Performance/StringReplacement
* | | Adding specs for rehash updatetyler-ball2016-03-041-2/+3
| | |
* | | Changing the knife behavior when using the cached plugins to only display 1 ↵tyler-ball2016-03-041-3/+21
| | | | | | | | | | | | error message when plugin files are missing from the cache
* | | First part of fixing the rehash command, it now always loads gems from disc ↵tyler-ball2016-03-041-0/+6
| | | | | | | | | | | | instead of using the hash file
* | | Merge pull request #4630 from chef/ksubrama/fips_guardKartik Null Cating-Subramanian2016-02-261-1/+7
|\ \ \ | | | | | | | | Have client.rb verify that FIPS mode can be enforced
| * | | Have client.rb verify that FIPS mode can be enforcedksubrama/fips_guardKartik Null Cating-Subramanian2016-02-251-1/+7
| |/ /
* | | Copy client.d files during bootstrapJay Mundrawala2016-02-241-0/+25
|/ / | | | | | | | | When knife finds a client.d/ directory, it will upload all files nested under that directory.
* | bugfix #2865 check for validation_keytm/h4ck3rm1k3-master-masterJames Michael DuPont2016-02-161-1/+2
| |
* | Be way more explicit about how we're handling datatm/missed_migrationThom May2016-02-152-5/+14
| | | | | | | | | | | | | | This just codifies the behaviour we're actually using - that we're passing a json string and expecting a hash back. Also adds a deprecation warning to the use of Chef::JSONCompat.from_json
* | convert MultilineOperationIndentation style to "indented"Lamont Granquist2016-02-121-1/+1
| | | | | | | | this looks nicer.
* | pull rubocop 0.37.2 into chefstyleLamont Granquist2016-02-122-3/+3
| | | | | | | | | | this is from the same ruleset that we had, but the new code catches more conditions.
* | auto fixing some rubocopsLamont Granquist2016-02-092-2/+2
| | | | | | | | | | | | | | | | | | Style/NegatedWhile Style/ParenthesesAroundCondition Style/WhileUntilDo Style/WordArray Performance/ReverseEach Style/ColonMethodCall
* | autofixing whitespace copsLamont Granquist2016-02-059-31/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4174 Style/SpaceInsideHashLiteralBraces 1860 Style/SpaceAroundOperators 1336 Style/SpaceInsideBlockBraces 1292 Style/AlignHash 997 Style/SpaceAfterComma 860 Style/SpaceAroundEqualsInParameterDefault 310 Style/EmptyLines 294 Style/IndentationConsistency 267 Style/TrailingWhitespace 238 Style/ExtraSpacing 212 Style/SpaceBeforeBlockBraces 166 Style/MultilineOperationIndentation 144 Style/TrailingBlankLines 120 Style/EmptyLineBetweenDefs 101 Style/IndentationWidth 82 Style/SpaceAroundBlockParameters 40 Style/EmptyLinesAroundMethodBody 29 Style/EmptyLinesAroundAccessModifier 1 Style/RescueEnsureAlignment
* | auto-fixing some easy copschefstyle/fixesLamont Granquist2016-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | 3 Performance/CaseWhenSplat: Place when conditions with a splat at the end of the when branches. 1 Style/ElseAlignment: Align else with if. 1 Style/EvenOdd: Replace with Fixnum#even?. 1 Style/MethodDefParentheses: Use def with parentheses when there are parameters. 3 Style/PercentQLiterals: Do not use %Q unless interpolation is needed. Use %q. 3 Style/SpaceAfterColon: Space missing after colon. 2 Style/SpaceAfterMethodName: Do not put a space between a method name and the opening parenthesis. 2 Style/Tab: Tab detected. 1 Style/TrailingUnderscoreVariable: Do not use trailing _s in parallel assignment. 1 Style/UnneededCapitalW: Do not use %W unless interpolation is needed. If not, use %w.
* | Merge pull request #4481 from chef/jdm/fips-58Jay Mundrawala2016-02-031-1/+1
|\ \ | | | | | | Allow use of command line fips switch for knife
| * | Allow use of command line fips switch for knifeJay Mundrawala2016-01-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This somewhat worked before. However, it was just for knife bootstrap. It also didn't support --no-fips in the case where it was in your knife.rb and you decided that you didn't want to use fips for that one call. The assumption here is fips mode you run knife with is the fips mode the node will get. This has the nice property that validatorless bootstraps will talk to the chef server in fips mode if the node is requested to be in fips mode.
* | | Update all auth email address from opscode.com and getchef.com to chef.io.Noah Kantrowitz2016-02-0210-14/+14
| | | | | | | | | Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
* | | Replace all Opscode copyrights with Chef Software.Noah Kantrowitz2016-02-026-6/+6
| | | | | | | | | Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
* | | Copyright year update for 2016 and massive cleanup.Noah Kantrowitz2016-02-0213-13/+13
|/ / | | | | Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
* | Rename openssl-fips to fips and add messagesJay Mundrawala2016-01-251-2/+2
| |
* | Add --openssl-fips to knife bootstrapJay Mundrawala2016-01-251-0/+4
| |
* | Merge pull request #4423 from chef/tm/rest_deprecationThom May2016-01-211-1/+1
|\ \ | | | | | | Add deprecation warnings to Chef::REST and all json_creates
| * | add deprecation warningsThom May2016-01-181-1/+1
| | |
* | | Autofixing Style/PercentLiteralDelimeterslcg/percentliteraldelimetersLamont Granquist2016-01-181-2/+2
|/ / | | | | | | | | | | See chef/chefstyle#11 for analysis and discussion. We select '{}' since audit of our source code shows that is the most common, and that used to be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.