| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
|
|
|
|
| |
Our check here to see if we're on Windows uses node data that's not
available in this context. Use the same Chef::Platform.windows? check we
use above. Without this you get the following error:
[2017-10-02T21:40:42+00:00] DEBUG: Re-raising exception: NameError - remote_file[c:/foo/bar] (foo::default line 14) had an error: NameError: undefined local variable or method `node' for #<Chef::Provider::RemoteFile::NetworkFile:0x00000000064c0148>
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
|
| |
|
|
|
|
|
| |
Conflicts:
spec/support/shared/functional/execute_resource.rb
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
When run against a VividMash.
Call .key? instead of [] when checking if a key exists for a VividMash
Otherwise the VividMash will return an empty object instead of nil for
that key.
Signed-off-by: DJ Mountney <david@twkie.net>
|
|
|
|
|
|
|
|
|
|
| |
Previously we injected our expected paths in to ENV['PATH'] but we
stopped doing that in Chef 13; for gem_package, we need to ensure that
if all else fails we'll use the Omnibus provided gem binary, but we
should never pick that if we can find a different one.
Closes: #6103
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out polluting PATH with a global path_sanity actually tends
to cause problems via picking up stuff from e.g. embedded/bin
when users don't want it. This change unsets the default setting
to add path sanity.
We already have the difference between internal and external uses
of shell_out, so what this does is take the internal use of
shell_out and always apply the PATH -- so anything calling
shell_out gets path_sanity.
It also modifies path_sanity to prepend the ruby bin and the
embedded bin into the PATH. When we need those for internal use
we really want those first.
Users who don't want path sanity at all can do:
shell_out_with_systems_locale(*whatever)
or:
shell_out(*whatever, env: { "PATH" => ENV['PATH'] })
Next PR I want to add:
shell_out(*whatever, internal: false)
Default will still be true though.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
| |
Also tidy up in the face of the real world.
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
|
| |
remove deprecations and now properties are nillable and passing a nil is
now always a set, not a get.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
| |
classes providing an API should include VersionedAPI, whilst the factory
class includes VersionedAPIFactory.
Signed-off-by: Thom May <thom@may.lt>
|
|
|
|
|
|
|
|
|
| |
When we make a request to a chef server, we capture the minimum and
maximum support API versions and allow them to be queried.
We then provide some infrastructure for making decisions on which class
should be used, in a middleware-ish mechanism.
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
| |
department of redundancy department
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
| |
- cleans up a lot of ivar usage
- converts most providers to shell_out_compact_timeout!
- almost deprecates a few APIs, but can't quite yet
- windows providers need mixlib-shellout to take an argv
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
also clean up a confusing spec test
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
| |
- fixes for dnf 2.0 / rhel7
- improved error messages from python helper (gives python stack
traces instead of just EPIPE all the time)
- improved which/where interface in the which mixin.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|\
| |
| | |
DNF Provider PR #2
|
| |
| |
| |
| | |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
| |
| |
| |
| |
| |
| |
| | |
- consistent use of shell_out_compact!
- remove more uses of run_command
- some other code cleanup
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
| |
| |
| | |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|/
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|\
| |
| | |
Core: fix Lint/UnifiedInteger cop
|
| |
| |
| |
| | |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
| |
| |
| |
| |
| | |
believe this becomes necessary for ruby 2.4/3.0
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|/
|
|
|
|
|
|
| |
This adds URLs to each class of deprecation, and correctly prints and
formats them for maximum user efficiency. We also provide the URL to the
data collector for Visibility to ingest.
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
| |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: NimishaS <nimisha.sharad@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: Matt Wrock <matt@mattwrock.com>
|
|
|
|
| |
Signed-off-by: NimishaS <nimisha.sharad@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: NimishaS <nimisha.sharad@msystechnologies.com>
|
|
|
|
|
|
|
|
|
|
| |
windows_package resource. (#5332)
* Fixed undefined short_cksum method issue and checksum in uppercase issue for windows_package resource.
* Added RSpecs for the changes done here.
* Fixed RSpecs issues.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some properties in custom resources may include sensitive data, such as a
password for a database server. When the Resource's state is built for use by
Data Collector or similar auditing tool, `Chef::Resource#state_for_resource_reporter`
builds a hash of all state properties for that resource and their values. This
leads to sensitive data being transmitted and potentially stored in the clear.
This change enhances properties with the ability to set an individual property
as sensitive and then have the value of that property suppressed when exporting
the Resource's state.
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
See http://stackoverflow.com/questions/2824126/whats-the-difference-between-uri-escape-and-cgi-escape#answer-13059657 for details on why.
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
|
|
|
| |
we only ever did this in order to mutate the options and with the
**options syntax we don't need to do this anymore.
|