| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
- cleans up a lot of ivar usage
- converts most providers to shell_out_compact_timeout!
- almost deprecates a few APIs, but can't quite yet
- windows providers need mixlib-shellout to take an argv
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
set rubygems_cache_enabled to true in Chef::Config to get the old behavior back
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
| |
|
|
|
|
|
|
| |
Add Package#version_requirement_satisfied? to separate fuzzy-match (:install) and exact-match (:upgrade) version checks when supported by the package subclass.
Wrap Package#candidate_version in a lazy-initialization object to minimize unnecessary API queries when candidate_version is not needed.
(fixes #3867)
|
| |
|
|
|
|
|
| |
this is part of our informal style guide, lets make it formal since
clearly its not getting followed very well.
|
|\
| |
| | |
Autofixing new Perf cops in 0.37.2
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6 Performance/Casecmp
18 Performance/Detect
1 Performance/RangeInclude
27 Performance/RedundantBlockCall
6 Performance/RedundantMatch
5 Performance/RedundantMerge
18 Performance/StringReplacement
|
|/
|
|
| |
for bonus points gem_package will pick this up as well.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
|
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
| |
|
|
|
|
| |
useless use of `"#{foo.to_s}"`
|
|\
| |
| | |
gem_package should install to the systemwide Ruby when using ChefDK.
|
| | |
|
| |
| |
| |
| | |
Fixes #3382.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
updates all the shell_out calls to respect the timeout which is passed
on the new_resource.
the old `Chef::Config` yum timeout values are still respected and will
override the default.
the default of 900 seconds is preserved.
|
|/
|
|
|
| |
Ruby 2.0 is the oldest release we support, and it ships with Rubygems
2.0: https://github.com/ruby/ruby/blob/v2_0_0_0/lib/rubygems.rb#L11
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
- fixes define_resource_requirements
- better idempotency (only packages that need updating are updated)
- better messaging (only packages that update are output)
- better comments
|
|
|
|
|
| |
URI previously was globally available because chef.rb loaded it via a
monkey patch for the URI class.
|
|\
| |
| |
| |
| | |
Conflicts:
CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| | |
Check for nil and length on version in package/rubygems tests
In gemspec test change @new_resource.instance_variable_set()
to @new_resource.version()
|
|\ \
| |/
|/|
| | |
tball/contrib-pass
|
| | |
|
|/ |
|
|
|
|
|
| |
makes resource and provider class resolution more dynamic.
begins deprecation of Chef::Platform static mapping.
|
|\ |
|
| |
| |
| |
| |
| | |
This was preventing chef from finding the candidate version when
upgrading a gem and assuming there was nothing to do
|
| |
| |
| |
| |
| | |
Chef::Provider::Package::Rubygems::AlternateGemEnvironment does
not inherit from Chef::Provider
|
| |
| |
| |
| | |
yes, i just used rubocop on the chef sourcecode...
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes CHEF-4275
In some cases, upgrading to rubygems 2.0 from 1.8 can leave both
installations available in the load path. The 2.0 install is ahead of
the 1.8 install, but it is possible to load a file from the 1.8 install
if that file does not exist in rubygems 2.0. In particular,
rubygems/format does not exist in 2.0, so `require "rubygems/format"`
loads from rubygems 1.8.
When Chef "accidentally" loads the old rubygems/format, it defeats the
version detection heuristic (check if Gem::Format) is defined, which
eventually causes an error calling Gem::Package.open. Adding a check to
see if Gem::Package defines open resolves this problem.
|
|
|
|
| |
Since we're here anyway...
|
| |
|
|
|
|
|
|
| |
in rubygems commit 432fc4818bbf14dfa5e49bbc1950eaa6d3fde133, return type
of dependency_installer's #find_gems_with_sources is changed to return a
Gem::AvailableSet collection instead of an ordered Array.
|
|
|
|
|
|
| |
* rubygems/format file removed
* Gem::Package replaces functionality in Gem::Format
* Gem.sources returns a SourceList which must be coerced to array
|