| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
I can barely understand what these intend. I'm pretty certain that
the logic in the encrypted data bag item code was wrong (fixed now
to match the comment) and I'm believe I converted the yum code to
preserve the logic. But holy fuck its hard to read the yum code
that I'm replacing.
|
|
|
|
|
| |
this is part of our informal style guide, lets make it formal since
clearly its not getting followed very well.
|
|
|
|
|
| |
Removes all remaining references to the deprecated escape_glob
helper routine.
|
|\
| |
| | |
Autofixing new Perf cops in 0.37.2
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6 Performance/Casecmp
18 Performance/Detect
1 Performance/RangeInclude
27 Performance/RedundantBlockCall
6 Performance/RedundantMatch
5 Performance/RedundantMerge
18 Performance/StringReplacement
|
|\ \
| | |
| | | |
RFC-060 gem metadata MVP
|
| | |
| | |
| | |
| | | |
for bonus points gem_package will pick this up as well.
|
| | | |
|
| | | |
|
| | | |
|
| |/
|/| |
|
| | |
|
| |
| |
| |
| | |
no enforced trailing comma on arguments...
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
252 Style/TrailingCommaInLiteral
84 Style/TrailingCommaInArguments
15 Style/SpaceAroundKeyword
--
351 Total
We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.
TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?
|
| |
| |
| |
| |
| | |
helps to remember the values of expensive things that we go off and
compute.
|
| |
| |
| |
| | |
ensure source is used on all functional tests
|
| | |
|
|/
|
|
|
|
|
|
|
| |
Style/NegatedWhile
Style/ParenthesesAroundCondition
Style/WhileUntilDo
Style/WordArray
Performance/ReverseEach
Style/ColonMethodCall
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
|
|
|
| |
Chocolatey.
|
| |
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
|
|
| |
Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
| |
|
| |
|
|
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
|
|
|
|
|
|
|
| |
autocorrects some merges that will be broken when the next
chefstyle is released.
also runs chefstyle after the travis tests, because i'd rather know
how the code is broken rather than how its not pretty.
|
| |
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
|
|
|
| |
chefstyle -a fixed 1044 occurrances
|
|
|
|
| |
Style/SignalException - 3
|
|\
| |
| | |
really fix cops
|
| | |
|
|\ \
| | |
| | | |
assert candidates exist for alternate sources and when pinning versions
|
| | | |
|
|\ \ \
| |_|/
|/| | |
fixes #4354 and fixes #4372 stop trying to auto detect versions for exe installers
|
| |/
| |
| |
| | |
installers
|
|\ \
| | |
| | | |
chefstyle: fix Lint/StringConversionInInterpolation
|
| |/
| |
| |
| | |
useless use of `"#{foo.to_s}"`
|
|/
|
|
|
|
|
|
|
| |
fixes the following offenses:
46 Lint/EndAlignment
21 Lint/BlockAlignment
3 Lint/SpaceBeforeFirstArg
1 Lint/DefEndAlignment
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
adds support for installer types inno, nsis, wise and installshield to windows_package resource
|
| |
| |
| |
| | |
windows_package resource
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously dpkg -s would allow a 0 or 1 exit status and it wasn't
entirely clear why this was so either from the code or the tests.
This restores throwing an exception if we are outside of the [0,1]
range, and then adds tests for both behaviors:
- on old ubuntu/debian we get an exit(0) and output on stdout if the
file is not installed
- on newer ubuntu/debian we get an exit(1) and output on stderr if
the file is not installed
Added tests for both those cases, and the case where dpkg -s does
some other kind of exitcode barf and we should raise.
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is just code rearrangement, no changes to behavior at
all. pushes the source_array and resolved_source_array up
into the superclass so that other providers can use it (as it
was intended, but that slipped out of the last PR). also
renamed it to something a little longer and less likely to
clash with variables (which it was already doing).
the block comment also refers to an earlier iteration that used
coercions, which had to be backed out because of chefspec.
|