summaryrefslogtreecommitdiff
path: root/lib/chef/util
Commit message (Collapse)AuthorAgeFilesLines
* Style/NegatedIfLamont Granquist2019-07-053-7/+7
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/EmptyLiteralLamont Granquist2019-07-052-3/+3
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Style/MethodCallWithoutArgsParenthesesLamont Granquist2019-07-022-2/+2
| | | | | | | | zero args methods don't get parens. this certainly reads better than the inverse. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Layout/EmptyLineAfterGuardClauseLamont Granquist2019-07-024-0/+6
| | | | | | | i like this one, gives visual priority to returns or raises that are buried in the middle of things. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Layout/AlignArgumentslcg/new-chefstyleLamont Granquist2019-07-022-3/+3
| | | | | | | | | | | | | | this is using: Layout/AlignArguments: Enabled: true EnforcedStyle: with_fixed_indentation the default style can use really excessive whitespace. on starting lines which are already long, it fully indents across to where the arguments start and then begins the line there. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix shellout require idempotency and bump gemsLamont Granquist2019-05-241-1/+1
| | | | | | | | | | something is declaring an empty class somewhere and trolling me hard but ruby makes that near impossible to figure out, so be slightly more specific by looking for a mixlib-shellout constant also bumps the gems Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* This hits the ones that are most frequently required.lcg/require-idempotencyLamont Granquist2019-05-202-2/+2
| | | | | | | | | Stops the kernel from scanning through all the activated gems every time in order to resolve names into pathnames. See rubygems/rubygems#2762 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Change some more require to require_relativeLamont Granquist2019-05-102-2/+2
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix a bunch of weirdly mangled require linesLamont Granquist2019-05-084-4/+4
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Convert require to require_relativeLamont Granquist2019-05-0814-27/+27
| | | | | | | This gives a speed boost since rubygems does not have to scan through every gem in the gemset in order to find the file. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Added support for setting the comment/description on a group in Windows. ↵Kapil Chouhan2018-12-131-0/+6
| | | | | | This is only for the Windows group. Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
* Properly capitalize PowerShell in descriptions and errorspowershellTim Smith2018-09-071-1/+1
| | | | | | It's PowerShell not Powershell. Our docs site had already been updated. Signed-off-by: Tim Smith <tsmith@chef.io>
* Assume credentials supplied are still valid if they cannot be validated due ↵Stuart Preston2018-07-251-2/+10
| | | | | to a Windows account restriction (#7416) Signed-off-by: Stuart Preston <stuart@chef.io>
* fix Style/MutableConstantLamont Granquist2018-07-021-1/+1
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Style/PreferredHashMethodsLamont Granquist2018-07-021-1/+1
| | | | | | | absolutely hard requirement on the fixes that went into chef-config 2.2.11, so the floor of that gem is bumped up. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Layout/LeadingCommentSpaceLamont Granquist2018-07-026-31/+31
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Layout/IndentHeredocLamont Granquist2018-07-021-10/+10
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Style/HashSyntaxLamont Granquist2018-07-027-9/+9
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Unification of shell_out APIsLamont Granquist2018-06-151-1/+1
| | | | | | | converts all usage to just shell_out() from the numerous helper utilities that we've had previously. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* mechanical conversion of most debug log statements to traceThom May2018-03-265-9/+9
| | | | Signed-off-by: Thom May <thom@chef.io>
* rubocop fixes from engine bump to 0.54.0lcg/rubocop-fixesLamont Granquist2018-03-211-2/+2
| | | | | | some cops got a little stricter. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Fixed review commentsnimisha2018-01-241-5/+2
| | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* Fixed/added specs for LogonSession changesnimisha2018-01-241-5/+5
| | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* Fixed/added specs for LogonSession changesnimisha2018-01-241-1/+1
| | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* Brought back Chef::Win32::Security functional test for running as a non ↵nimisha2018-01-241-2/+8
| | | | | | admin user Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* prepping for rubocop 0.52.1lcg/rubocop-0.52.1Lamont Granquist2018-01-171-4/+0
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix argument to restorecon not being shell-escapedDavid Ashby2017-11-221-4/+5
| | | | Signed-off-by: David Ashby <delta.mu.alpha@gmail.com>
* MSYS-684: Added parser for DSC configurationpiyushawasthi2017-10-052-18/+73
| | | | Signed-off-by: piyushawasthi <piyush.awasthi@msystechnologies.com>
* Code refactor and add spec for powershell version 5piyushawasthi2017-09-121-1/+0
| | | | Signed-off-by: piyushawasthi <piyush.awasthi@msystechnologies.com>
* Refactor all command line options into lcm_command()Bryan McLellan2017-09-121-12/+13
| | | | Signed-off-by: Bryan McLellan <btm@loftninjas.org>
* MSYS-656 - fixed dsc_script for WMF5piyushawasthi2017-09-121-5/+15
| | | | Signed-off-by: piyushawasthi <piyush.awasthi@msystechnologies.com>
* Using LOGON32_LOGON_NEW_CREDENTIALS instead of LOGON32_LOGON_NETWORKnimisha2017-09-051-1/+1
| | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* Fixing specsnimisha2017-09-051-4/+4
| | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* Added define_resource_requirement and some other validationsnimisha2017-09-051-3/+3
| | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* Alternate user remote file code review feedbackadamedx2017-09-051-17/+25
|
* Windows thread alternate user impersonation supportadamedx2017-09-051-0/+118
|
* Merge pull request #5725 from pescuma/masterThom May2017-03-211-1/+1
|\ | | | | Fix for creating users in non english windows machines
| * Fix for creating users in non english windows machines: uses SID instead of ↵Ricardo Pescuma Domenecci2017-01-131-1/+1
| | | | | | | | | | | | name to identify Users group Signed-off-by: Ricardo Pescuma Domenecci <ricardo@pescuma.org>
* | fix specs: RedundantReturn, RedundantSelf, RedundantBeginLamont Granquist2017-02-137-76/+48
|/ | | | | | department of redundancy department Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix Style/NilComparisonLamont Granquist2016-12-061-1/+1
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* set erroraction stop instead of continueNimishaS2016-09-301-1/+1
| | | | Signed-off-by: NimishaS <nimisha.sharad@msystechnologies.com>
* fixing Style/MultilineTernaryOperator copLamont Granquist2016-08-161-2/+5
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* autofixing Style/RedundantException copLamont Granquist2016-08-162-2/+2
|
* chefstyle Style/AndOr fixesLamont Granquist2016-03-142-2/+2
| | | | | this is part of our informal style guide, lets make it formal since clearly its not getting followed very well.
* add some @yield docsLamont Granquist2016-03-041-0/+1
| | | | added some FIXMEs because trying to sort out types for random undocumented code was making me completely aggro
* remove unused block argumentslcg/chefstyle-perfLamont Granquist2016-02-231-1/+1
|
* Autofixing new Perf cops in 0.37.2Lamont Granquist2016-02-231-1/+1
| | | | | | | | | | 6 Performance/Casecmp 18 Performance/Detect 1 Performance/RangeInclude 27 Performance/RedundantBlockCall 6 Performance/RedundantMatch 5 Performance/RedundantMerge 18 Performance/StringReplacement
* pull rubocop 0.37.2 into chefstyleLamont Granquist2016-02-121-1/+1
| | | | | this is from the same ruleset that we had, but the new code catches more conditions.
* auto fixing some rubocopsLamont Granquist2016-02-093-17/+17
| | | | | | | | | Style/NegatedWhile Style/ParenthesesAroundCondition Style/WhileUntilDo Style/WordArray Performance/ReverseEach Style/ColonMethodCall
* autofixing whitespace copsLamont Granquist2016-02-0513-251/+249
| | | | | | | | | | | | | | | | | | | | | | 4174 Style/SpaceInsideHashLiteralBraces 1860 Style/SpaceAroundOperators 1336 Style/SpaceInsideBlockBraces 1292 Style/AlignHash 997 Style/SpaceAfterComma 860 Style/SpaceAroundEqualsInParameterDefault 310 Style/EmptyLines 294 Style/IndentationConsistency 267 Style/TrailingWhitespace 238 Style/ExtraSpacing 212 Style/SpaceBeforeBlockBraces 166 Style/MultilineOperationIndentation 144 Style/TrailingBlankLines 120 Style/EmptyLineBetweenDefs 101 Style/IndentationWidth 82 Style/SpaceAroundBlockParameters 40 Style/EmptyLinesAroundMethodBody 29 Style/EmptyLinesAroundAccessModifier 1 Style/RescueEnsureAlignment