summaryrefslogtreecommitdiff
path: root/lib/chef
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8711 from chef/lcg/new-chefstyle2Lamont Granquist2019-07-08408-1740/+2043
|\ | | | | More Chefstyle updates
| * lazy procs are instance_exec in the resource alreadyLamont Granquist2019-07-056-13/+13
| | | | | | | | | | | | | | | | exposed by Style/SymbolProc mangling some bad code. no idea how this ever worked. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix 4 copsLamont Granquist2019-07-0512-17/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Layout/MultilineMethodCallBraceLayout - Layout/ClosingParenthesisIndentation - Layout/IndentFirstArgument EnforcedStyle: consistent - Layout/BlockEndNewline the first of these autocorrected to horrible looking code which exposed that we really needed the other three as well, which also cleaned up a bunch of other terrible looking code. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/SymbolProcLamont Granquist2019-07-0555-94/+86
| | | | | | | | | | | | enforce pretzels. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/StringLiteralsInInterpolationLamont Granquist2019-07-05103-213/+213
| | | | | | | | | | | | since we use double quotes, be consistent everywhere. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/ClassCheckLamont Granquist2019-07-0549-102/+102
| | | | | | | | | | | | convert kind_of? to is_a? Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/RegexpLiteralLamont Granquist2019-07-0535-50/+50
| | | | | | | | | | | | | | given how many regexps we have with /'s in the match this seems like a very good one. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/NegatedIfLamont Granquist2019-07-0573-129/+129
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/EmptyLiteralLamont Granquist2019-07-0548-69/+69
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix more Style/SymbolArray autocorrect bugsLamont Granquist2019-07-022-6/+6
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix bugs from Style/SymbolArray autocorrect copLamont Granquist2019-07-022-3/+3
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/EmptyMethodLamont Granquist2019-07-0223-306/+153
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * tweak Lint/BlockAlignmentLamont Granquist2019-07-0210-101/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lint/BlockAlignment: Enabled: true EnforcedStyleAlignWith: start_of_block this works better with Layout/MultilineMethodCallIndentation to force indentation of multiline method calls that wind up with multiline blocks. i'd probably pull back the end to match with the start of the expression but this gets the indentation level inside the block correct. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Layout/MultilineMethodCallIndentationLamont Granquist2019-07-024-7/+7
| | | | | | | | | | | | | | | | Layout/MultilineMethodCallIndentation: Enabled: true EnforcedStyle: indented Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/MethodCallWithoutArgsParenthesesLamont Granquist2019-07-0215-17/+17
| | | | | | | | | | | | | | | | zero args methods don't get parens. this certainly reads better than the inverse. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Style/SymbolArrayLamont Granquist2019-07-0256-627/+627
| | | | | | | | | | | | start enforcing using %i{} instead of arrays of symbols Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix Layout/EmptyLineAfterGuardClauseLamont Granquist2019-07-02206-0/+454
| | | | | | | | | | | | | | i like this one, gives visual priority to returns or raises that are buried in the middle of things. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Bump version to 15.1.44 by Chef Expeditorv15.1.44Chef Expeditor2019-07-081-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8708 from chef/lcg/new-chefstyleTim Smith2019-07-08152-1546/+1546
|\ \ | |/ | | fix Layout/AlignArguments
| * fix Layout/AlignArgumentslcg/new-chefstyleLamont Granquist2019-07-02152-1546/+1546
| | | | | | | | | | | | | | | | | | | | | | | | | | | | this is using: Layout/AlignArguments: Enabled: true EnforcedStyle: with_fixed_indentation the default style can use really excessive whitespace. on starting lines which are already long, it fully indents across to where the arguments start and then begins the line there. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Bump version to 15.1.43 by Chef Expeditorv15.1.43Chef Expeditor2019-07-081-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.42 by Chef Expeditorv15.1.42Chef Expeditor2019-07-031-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.41 by Chef Expeditorv15.1.41Chef Expeditor2019-07-021-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.40 by Chef Expeditorv15.1.40Chef Expeditor2019-07-021-1/+1
|/ | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 15.1.39 by Chef Expeditorv15.1.39Chef Expeditor2019-07-021-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 15.1.38 by Chef Expeditorv15.1.38Chef Expeditor2019-07-021-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Parse day param value into stringVivek Singh2019-07-021-2/+2
| | | | Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
* Bump version to 15.1.37 by Chef Expeditorv15.1.37Chef Expeditor2019-07-021-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 15.1.36 by Chef Expeditorv15.1.3615.1.36Chef Expeditor2019-07-011-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #8687 from criteo-forks/issue_7215_yum_package_custom_repoTim Smith2019-07-011-5/+3
|\ | | | | Pass yum_package options to underlying python helper
| * Pass yum_package options to underlying python helperBaptiste Courtois2019-06-241-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When working with custom repo that are disabled by default, we need to enable them on-demand. The python helper handles that properly but the yum package provider does not pass user's options in all cases. Most of the time there is no issue because in normal cases you should not need to enable any repository to work with "installed" packages. However in some rare cases, you may have multiple installed versions of a given package. In that situation, python libraries used by the helper will do some extra work that may (will) requires to enable the repo. See call to _compare_providers in http://yum.baseurl.org/download/docs/yum-api/3.2.27/yum-pysrc.html#YumBase._bestPackageFromList Not passing the options in that case, will result in an unclear error: > ' * No candidate version available for "package" ' And often will lock/corrupt the rpm db. Signed-off-by: Baptiste Courtois <b.courtois@criteo.com>
* | Bump version to 15.1.35 by Chef Expeditorv15.1.35Chef Expeditor2019-07-011-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.34 by Chef Expeditorv15.1.34Chef Expeditor2019-06-281-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.33 by Chef Expeditorv15.1.33Chef Expeditor2019-06-271-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.32 by Chef Expeditorv15.1.32Chef Expeditor2019-06-271-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Fix a typo in the hostname resource property descriptionsTim Smith2019-06-261-1/+1
| | | | | | | | | | | | Fix this so we can fix the docs site Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 15.1.31 by Chef Expeditorv15.1.31Chef Expeditor2019-06-261-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 15.1.30 by Chef Expeditorv15.1.30Chef Expeditor2019-06-251-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8691 from chef/choco_docsTim Smith2019-06-251-3/+5
|\ \ | | | | | | Add introduced fields for chocolatey_source
| * | Add introduced fields for chocolatey_sourcechoco_docsTim Smith2019-06-251-3/+5
| | | | | | | | | | | | | | | | | | This way we get the proper docs for Chef 15.1. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Bump version to 15.1.29 by Chef Expeditorv15.1.29Chef Expeditor2019-06-251-1/+1
| | | | | | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | | Merge pull request #8692 from chef/lcg/yum-exception-handlingTim Smith2019-06-251-24/+29
|\ \ \ | | | | | | | | yum_package: Better handle yum exceptions in our helper so we always close the rpmdb
| * | | be a bit more careful in the exit handler as wellLamont Granquist2019-06-251-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | mostly cosmetic Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | handle case where rpmdb has not been initialized yetLamont Granquist2019-06-251-1/+2
| | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | yum exception handling improvementslcg/yum-exception-handlingLamont Granquist2019-06-251-24/+27
| | |/ | |/| | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Bump version to 15.1.28 by Chef Expeditorv15.1.28Chef Expeditor2019-06-251-1/+1
| |/ |/| | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #8635 from gep13/choco_sourceTim Smith2019-06-251-0/+33
|\ \ | | | | | | (GH-8634) Add ability to further configure source
| * | Address PR review feedbackGary Ewan Park2019-06-051-6/+5
| | | | | | | | | | | | Signed-off-by: Gary Ewan Park <gep13@gep13.co.uk>
| * | (GH-8634) Add ability to further configure sourceGary Ewan Park2019-06-041-1/+35
| | | | | | | | | | | | | | | | | | | | | | | | This provides the ability to set additional properties for a Chocolatey source with properties `admin_only` and `allow_self_service`. As well as the ability to enable/disable a source. Signed-off-by: Gary Ewan Park <gep13@gep13.co.uk>
* | | Bump version to 15.1.27 by Chef Expeditorv15.1.27Chef Expeditor2019-06-251-1/+1
| | | | | | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
View Lorry Controller Status