summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* Use .key? instead of keys.includeTim Smith2020-08-034-4/+5
| | | | | | | | We don't need to create an array that we then search when we can just search the hash. Also disable a few hash like calls that are false positives Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.3.60 by Chef Expeditorv16.3.60Chef Expeditor2020-08-031-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.59 by Chef Expeditorv16.3.59Chef Expeditor2020-08-031-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.58 by Chef Expeditorv16.3.58Chef Expeditor2020-08-031-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.57 by Chef Expeditorv16.3.57Chef Expeditor2020-08-031-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #10247 from chef/rubocop_Performance_SortReverseTim Smith2020-08-031-1/+1
|\ | | | | Use sort.reverse instead of sort { |a, b| b <=> a }
| * Use sort.reverse instead of sort { |a, b| b <=> a }Tim Smith2020-08-031-1/+1
| | | | | | | | | | | | It's faster. See https://github.com/rubocop-hq/rubocop-performance/pull/130 Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #10245 from chef/rubocop_Performance_RangeIncludeTim Smith2020-08-031-3/+3
|\ \ | | | | | | Resolve Performance/RangeInclude warnings
| * | Resolve Performance/RangeInclude warningsrubocop_Performance_RangeIncludeTim Smith2020-08-031-3/+3
| |/ | | | | | | | | | | Use cover? instead of include? with ranges Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #10239 from chef/lcg/osx_profileLamont Granquist2020-08-033-261/+227
|\ \ | | | | | | Convert osx_profile to custom resource
| * | Convert osx_profile to custom resourcelcg/osx_profileLamont Granquist2020-08-033-261/+227
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also does some code cleanup. The path property has been removed as a property since it was never an input to the resource, and just some state that was necessary to abuse the tempfile mechanism. Documented the abuse of the tempfile mechanism for now (I think I actually recall signing off on this awhile back because there was no better way to do it, so its all half my fault, it's still horrible) The actual shell_out calls now raise. This might cause problems? I don't know, but it seems real bad to just blindly swallow errors and continue. Feels like more of a bugfix than a breaking change, but it isn't documented clearly as to why those errors were being ignored anywhere and didn't break any tests so it appears to be a coding error. The mutation of the new_resource was removed (other than the tempfile hack) and migrated to state on the provider. Removed some weird return values on things that are called from a void context. Added some lazy initializers for stuff that made it a lot more readable Converted the cookbook_file resource to a real cookbook_file now that we're in unified_mode. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Use .match? when we don't need data from a regex matchTim Smith2020-08-032-3/+3
|/ | | | | | We still had a few of these. Avoid creating the match object. Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.3.56 by Chef Expeditorv16.3.56Chef Expeditor2020-08-021-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.55 by Chef Expeditorv16.3.55Chef Expeditor2020-07-311-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.54 by Chef Expeditorv16.3.54Chef Expeditor2020-07-311-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.53 by Chef Expeditorv16.3.53Chef Expeditor2020-07-311-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.3.52 by Chef Expeditorv16.3.52Chef Expeditor2020-07-311-1/+1
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #9820 from ↵Tim Smith2020-07-311-2/+6
|\ | | | | | | | | MsysTechnologiesllc/dh/fix_feature_install_when_state_is_removed Fix install windows features when install state is removed
| * optimized codedheerajd-msys2020-07-301-4/+4
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
| * install removed feature when source is availabledheerajd-msys2020-07-291-1/+5
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
| * Fix install features when install state is removeddheerajd-msys2020-05-071-2/+2
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
* | Bump version to 16.3.51 by Chef Expeditorv16.3.51Chef Expeditor2020-07-311-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.50 by Chef Expeditorv16.3.50Chef Expeditor2020-07-301-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.49 by Chef Expeditorv16.3.49Chef Expeditor2020-07-301-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.48 by Chef Expeditorv16.3.48Chef Expeditor2020-07-301-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.47 by Chef Expeditorv16.3.47Chef Expeditor2020-07-291-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.46 by Chef Expeditorv16.3.46Chef Expeditor2020-07-291-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | mark the crazy node cache here as not a public API very clearlyLamont Granquist2020-07-291-0/+6
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Bump version to 16.3.45 by Chef Expeditorv16.3.45Chef Expeditor2020-07-291-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.44 by Chef Expeditorv16.3.44Chef Expeditor2020-07-281-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | clean up some weird looking conditionals in the retry logiclcg/fix-protocol-negotiationLamont Granquist2020-07-281-5/+5
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Fix protocol negotiation for unversioned objectsLamont Granquist2020-07-283-8/+10
| | | | | | | | | | | | | | | | | | We generally always do protocol negotiation on the get of the node object and the Chef::Node is an unversioned API, so we need to test that we backoff the API version to the highest version the server offers and then retry again. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Bump version to 16.3.43 by Chef Expeditorv16.3.43Chef Expeditor2020-07-281-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.42 by Chef Expeditorv16.3.42Chef Expeditor2020-07-281-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.41 by Chef Expeditorv16.3.41Chef Expeditor2020-07-281-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #10216 from chef/fix-406-no-method-errorTim Smith2020-07-271-2/+5
|\ \ | | | | | | Fix NoMethodError when server returns a 406.
| * | Fix NoMethodError when server returns a 406.Pete Higgins2020-07-271-2/+5
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
* | | Merge pull request #10147 from chef/hostnameTim Smith2020-07-271-18/+18
|\ \ \ | | | | | | | | Use powershell_out vs. powershell_script in hostname
| * | | Use a const for the ec2 config location on windowsTim Smith2020-07-271-4/+5
| | | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | | Add end-to-end hostname testingTim Smith2020-07-271-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | | Use powershell_out vs. powershell_script in hostnameTim Smith2020-07-271-15/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves the log output and probably speeds up the run since we're not writing out a temporary script file anymore and then executing it. I also removed some delcare_resource uses since we enabled unified_mode for this resource. There's a ton more to remove here. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Bump version to 16.3.40 by Chef Expeditorv16.3.40Chef Expeditor2020-07-271-1/+1
| | | | | | | | | | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | | | Merge pull request #10212 from chef/mark_privateTim Smith2020-07-271-0/+2
|\ \ \ \ | |_|/ / |/| | | Mark a private method as private with yard
| * | | Mark a private method as private with yardTim Smith2020-07-271-0/+2
| |/ / | | | | | | | | | | | | | | | Make sure this stays out of docs Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Bump version to 16.3.39 by Chef Expeditorv16.3.39Chef Expeditor2020-07-271-1/+1
|/ / | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Bump version to 16.3.38 by Chef Expeditorv16.3.38Chef Expeditor2020-07-251-1/+1
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #10205 from chef/remove-some-test-cruftTim Smith2020-07-241-1/+0
|\ \ | | | | | | Remove some test cruft around diffing
| * | Scratch this off the TODO list.Pete Higgins2020-07-241-1/+0
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
* | | Bump version to 16.3.37 by Chef Expeditorv16.3.37Chef Expeditor2020-07-251-1/+1
| | | | | | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | | fix el6 selinuxLamont Granquist2020-07-241-1/+1
|/ / | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
View Lorry Controller Status