| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
no enforced trailing comma on arguments...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
252 Style/TrailingCommaInLiteral
84 Style/TrailingCommaInArguments
15 Style/SpaceAroundKeyword
--
351 Total
We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.
TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?
|
| |
|
| |
|
|\
| |
| | |
Change shell for locked user.
|
| | |
|
| |
| |
| |
| |
| | |
this is from the same ruleset that we had, but the new code catches more
conditions.
|
| |
| |
| |
| | |
ensure source is used on all functional tests
|
|\ \
| | |
| | | |
fix a batch of cops
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Style/NegatedWhile
Style/ParenthesesAroundCondition
Style/WhileUntilDo
Style/WordArray
Performance/ReverseEach
Style/ColonMethodCall
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
3 Performance/CaseWhenSplat: Place when conditions with a splat at the end of the when branches.
1 Style/ElseAlignment: Align else with if.
1 Style/EvenOdd: Replace with Fixnum#even?.
1 Style/MethodDefParentheses: Use def with parentheses when there are parameters.
3 Style/PercentQLiterals: Do not use %Q unless interpolation is needed. Use %q.
3 Style/SpaceAfterColon: Space missing after colon.
2 Style/SpaceAfterMethodName: Do not put a space between a method name and the opening parenthesis.
2 Style/Tab: Tab detected.
1 Style/TrailingUnderscoreVariable: Do not use trailing _s in parallel assignment.
1 Style/UnneededCapitalW: Do not use %W unless interpolation is needed. If not, use %w.
|
| |
| |
| |
| | |
API instead of retyping them with our fingers
|
| |
| |
| | |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
| |
| |
| | |
Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
|
| |
| |
| | |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
| |
| |
| |
| |
| | |
This test is causing the rspec tests in appveyor to exit
with 116
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Rerunning ohai wastes a lot of time. This should
get us back to within our time limits in appveyor
even with the perf regression in Ohai.
Don't rerun ohai for unit/regsitry_helper_spec
Ohai is slow. We don't need to rerun this, it's
already run in our spec_helper.
Don't keep rerunning ohai for reboot_pending_spec
Running Ohai is slow. This should know almost 2
mins off the runtime of the tests.
Don't need to run ohai for registry_spec
crypto_spec does not need its own ohai
cmdlet_spec does not need its own ohai
functional registry_helper_spec does not need its own ohai
Use spec ohai system for knife configure_spec
Use OHAI_SYSTEM for dsc_script_spec
use OHAI_SYSTEM for dsc_resource_spec
|
|/
|
|
| |
Running ohai is slow
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to https://abcofaix.wordpress.com/tag/usermod/, the value
can be up to 200. We were seeing tests on our aix testers fail with
```
1) Chef::Provider::User::Useradd action :create when the user does not exist beforehand when a system user is specified ensures the user has the properties of a system user
Failure/Error: expect(pw_entry.uid.to_i).to be < uid_min.to_i
expected: < 100
got: 101
# ./spec/functional/resource/user/useradd_spec.rb:306:in `block (5 levels) in <top (required)>'
```
|
|
|
|
| |
home directory is expected
|
| |
|
|
|
|
| |
uppercase users
|
|
|
|
|
| |
First, making powershell raise if there is an exception installing.
Second, add choco to the path if it isn't already there.
|
| |
|
|
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
|
|
|
|
|
|
|
| |
autocorrects some merges that will be broken when the next
chefstyle is released.
also runs chefstyle after the travis tests, because i'd rather know
how the code is broken rather than how its not pretty.
|
| |
|
| |
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
|
|
|
| |
chefstyle -a fixed 1044 occurrances
|
|\
| |
| | |
really fix cops
|
| | |
|
|\ \
| |/
|/| |
fixes #4354 and fixes #4372 stop trying to auto detect versions for exe installers
|
| |
| |
| |
| | |
installers
|
|\ \
| | |
| | | |
chefstyle: fix Lint/StringConversionInInterpolation
|
| |/
| |
| |
| | |
useless use of `"#{foo.to_s}"`
|
|/
|
|
|
|
|
|
|
| |
fixes the following offenses:
46 Lint/EndAlignment
21 Lint/BlockAlignment
3 Lint/SpaceBeforeFirstArg
1 Lint/DefEndAlignment
|
|
|
|
|
|
|
| |
In the process, stop auto-expanding JSON in the HTTP client, and let
individual classes control that themselves.
Fixes #2737, Fixes #3518
|
|\
| |
| | |
Re-enable AIX mount functional test
|
| |
| |
| |
| | |
works inside both LPARs and WPARs.
|
|\ \
| |/
|/| |
fix run_as_user of windows_service
|
| |
| |
| |
| | |
not clobber existing service rights of other users
|
| | |
|
|/
|
|
| |
WPARs. In the future we should find a way to test this code. One cannot create a ramdisk in a WPAR, since it shares filesystem with the LPAR host.
|
| |
|
|\
| |
| | |
Fix dpkg specs to run on debian 6
|