| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
This test was originally written against a KnifeSupport that wasn't
actually pulling in the instance variables (i.e. :attribute) when
parsing the data. When running this command manually with Knife
v12.15.19, I get the output as now described in this test.
Signed-off-by: Tom Duffield <tom@chef.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
For the commands that allow you to filter which attributes it shows you
using the `--attribute` flag, add the `--field-separator` flag to allow
the user to customize which character(s) they want to use to deliniate the
attribute hierarchy.
```shell
knife node show NODE -S: -a "packages:Chef Client v12.12.15"
```
Signed-off-by: Tom Duffield <tom@chef.io>
|
| |
|
|
|
|
| |
Fixes chef/chef-vault#215
Signed-off-by: Thom May <thom@may.lt>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Windows Ruby 2.3 translates pathnames like ADMINI~1 to Administrator, making the comparison fail.
|
| |
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
| |
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
| | |
|
| |
|
|
|
|
|
|
| |
This allows us to use the path we produce for other display purposes and
consume it internally to have a canonical path for comparisons and
printing
Signed-off-by: Thom May <thom@may.lt>
|
| | |
|
| |\
| |
| | |
Improve wording in Knife
|
| | | |
|
| |\ \
| |/
|/| |
Support libraries with sub directories
|
| | | |
|
| |/
|
|
|
|
|
|
| |
lets us use Gem::Dependency constraints directly as rspec
constraints for matching Chef::Version and RUBY_VERSION.
copies some magic sauce from bundler that does something
similar
|
| |
|
|
| |
no enforced trailing comma on arguments...
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
252 Style/TrailingCommaInLiteral
84 Style/TrailingCommaInArguments
15 Style/SpaceAroundKeyword
--
351 Total
We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.
TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Style/NegatedWhile
Style/ParenthesesAroundCondition
Style/WhileUntilDo
Style/WordArray
Performance/ReverseEach
Style/ColonMethodCall
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
| |
|
| |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
| |
|
| |
Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
|
| |
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
another chefstyle catchup + pull master
|
| | |
| |
| |
| |
| |
| |
| | |
bunch of merges over the weekend need re-fixing again.
seems like pointing at master of chefstyle is probably a good idea to
start making people fix their code before merging.
|
| |/
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
| |
|
|
| |
This reverts commit ccf46bf3055b2a1c06499ec104f3d74c26643395.
|
| |
|
|
|
|
|
| |
bunch of merges over the weekend need re-fixing again.
seems like pointing at master of chefstyle is probably a good idea to
start making people fix their code before merging.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
| |
|
|
| |
chefstyle -a fixed 1044 occurrances
|
| |
|
|
|
|
|
|
|
| |
fixes the following offenses:
46 Lint/EndAlignment
21 Lint/BlockAlignment
3 Lint/SpaceBeforeFirstArg
1 Lint/DefEndAlignment
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
A FileSystemEntry with a nil parent is a "root directory" and thus
should exists so long as its filesystem path exists. This was preventing
the download of files such as invitation.json whose parent directory is
a root directory.
|
| | |
|
| |
|
|
|
|
| |
Fixes #1684
Add tests for path manipulation in chef-fs.
Clean up the handling of paths in chef-fs.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookbooks with self-deps:
name 'foo'
depends 'foo'
are useless and can waste cycles in the depsolver (particularly in
the non-solution case), and likely limit the possible choices of
depsolvers that we could pick at some point to replace gecode.
filtering out the self-dep here will prevent the chef server depsolver
from seeing the self-dep and needing to do the work to strip it.
also warn the user so that they can remove the self-dep.
in the future this will be a hard error.
foodcritic also has a rule about removing these.
|
| | |
|
| | |
|
| | |
|