| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|
|
|
| |
Signed-off-by: Tensibai <tensibai@iabis.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the relicensing effort.
Note that this PR leaves the knife and ohai binstubs still in the
gem(s) while that discussion is still ongoing.
This PR extracts the binstubs to chef-binstubs gem which is not intended
to be redistributed outside of the omnibus chef binaries.
A blank gem for chef-binstubs has been pushed to rubygems.org for
obvious security concerns and so that bundler/rubygems can resolve
the gem
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|
|
|
|
|
|
| |
this is the result of changes to rules we already previously had
enabled.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
Our more esoteric unices need some more careful hand holding
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
|
| |
This commit ensures that the `nodes` dir and the node files within
it are created with the correct permissions by chef-solo.
Signed-off-by: Scott Christopherson <scott@chef.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fix chef-solo spec timeouts
caused by a race condition (not actually fixed) where the pid
can be read by the process which lost the race to lock it before the
pid has been written by the process which got the lock.
the result is a message like:
"WARN: Chef client is running, will wait for it to finish and then run."
without any numerical pid.
i'm not super concerned with fixing the race, this will unbreak a lot
of red travis failures though.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* revert some debugging
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
there's a WONTFIX closed bug in ruby-lang.org on this bug:
https://bugs.ruby-lang.org/issues/10583
they seem to be favoring speed over accuracy with the result
that if you're doing I/O synchronization (like our run_lock?)
inside of a Process.spawn chain like this that you have to
wrap the spawn calls inside of threads.
probably a best practice to wrap every spawn call with a
Thread.
this probably also explains why we had the silly-long 20
second timeout?
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix the 'last' statements (my perl brain occassionally crops up
in ruby code) and replace with a raise. of course this just swaps
one exception for another, but this time its really intended to
work this way.
- swap the order of the expecations so that if we fails to see the
waiting on the other process statement, but we blow up in both
threads in the exception that was just added, we know we actually
have a legit run_lock race condition that this code just found.
does not fix this bug, just gets us a bit more information if it
reoccurs.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
when running on my mac this entirely removes all the sleeps
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removes the requirement that the second wait for the first, just that
one of them waits for the other, so if we ever somehow lose that race
and the second wins the run_lock as long as the first sleeps then its
all good...
drops all the sleeps down a lot, thinking about how to make this more
cleverer so that it doesn't sleep but handshakes properly so that we
don't need 25 seconds of sleep on slowaris tests..
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
ie, only when we're in OG mode and not in local mode.
Signed-off-by: Thom May <thom@chef.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Prefer instance methods to class methods for Chef Zero helpers.
RSpec's design and feature set heavily favors using instance methods
for test setup. This change will allow us to use let bindings and more
naturally move common setup to shared contexts.
* Temporarily copy ChefZero's RSpec features in-repo. master of Chef
Zero is currently broken for unit testing. Copy the changes here for
now so we can make progress.
* Automatically generate a metadata file when using the "cookbook"
helper function. This will be needed for a subsequent change that
makes `name' required in metadata.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes CHEF-4367.
When attempting to load a recipe belonging to a cookbook that is not in
the run_list or any dependencies of cookbooks in the run_list, chef
will now produce an error like this:
Chef::Exceptions::MissingCookbookDependency
-------------------------------------------
Recipe `ancient::aliens` is not in the run_list, and cookbook 'ancient'
is not a dependency of any cookbook in the run_list. To load thisrecipe,
first add a dependency on cookbook 'ancient' in the cookbook you're
including it from in that cookbook's metadata.
This error will occur when chef-solo users use `include_recipe` without
specifying the dependency in metadata; prior to this patch, chef would
typically fail reading an undefined attribute, which commonly would
result in a NoMethodError for nil.
|
| |
|
|
|
|
|
|
|
|
|
| |
A past refactor was incomplete, leaving references to chef_solo_json.
The contract with the superclass is that json data is set to
@chef_client_json
Conflicts:
spec/integration/solo/solo_spec.rb
|
| |
|
|
|
|
| |
exec while launching chef-solo in functional tests as well.
|
|
|
|
| |
the second to make sure they overlap during the test.
|
| |
|
|
|
|
| |
This ensures that if someone does a manual chef-client run, it doesn't fail if the chef is configured as a service on windows and if there is a chef-client run happening right now. The newly started run will wait for the old run to finish and continue after it.
|
| |
|
| |
|
|
|