| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Avoid deprecation warnings. Also remove the monkeypatch that provided
HTTPClientException on older Ruby releases since we're 2.6+ now and we
don't need this.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
| |
Remove all these expects
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
| |
We added a deprecation warning to load_cookbooks and this is going to cause a ton of console spam for end users.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
|
| |
When this shows up in logs it's impossible to figure out what actually
needs to be updated
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
|
|
|
|
|
|
| |
deletes the local copy of it from chef repo
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
|
|
|
|
| |
This reverts commit c29b8da2b0353bb5d6e499b5d7cc79c0fadab9b3.
|
|\
| |
| |
| |
| | |
MsysTechnologiesllc/VSingh/MSYS-1154_knife_list_relative_paths
[knife list] Validate name argument & raise error if no args provided
|
| |
| |
| |
| |
| |
| |
| | |
- Add required specs.
- Raise an error if no argument provided.
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
This is the implementation of [RFC-087](https://github.com/chef-boneyard/chef-rfc/blob/master/rfc087-distro-sugar-helpers.md)
although some of the specifics have been iterated on and changed.
The documentation will be in the [README.md](https://github.com/chef/chef/tree/master/chef-utils/README.md) once this is merged.
While this PR mostly moves chef-sugar utilities into core-chef via this chef-utils gem, the scope of the chef-utils gem
should be considered larger than just that. As an example this PR moves the Mash class into this gem for reuse in ohai
as well.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
- Now showing relevant logs for config.d configuration files.
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
|
|
|
|
|
|
|
|
| |
* Use default windows 2019 image
* Skip 8dot3name tests as default disabled on 2019
* Use windows privileged executor for functional tests
* Use windows docker image for chocolatey tests
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
|
|
|
|
|
|
|
|
| |
Fixes #6300.
This may be a breaking change.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert to using TinyServer and remove the duplicated functionality
with the "app_server_support" helper.
The fact that this change hits the knife raw / knife redirection specs
that have so many timeout issues is very likely not a coincidence.
I would bet a small, but not entirely insignificant amount of money that
this makes those timeout issues go away.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes #8817
Note that if any calling code winds up seeing this error message:
```
NoMethodError: undefined method `set_cookbook_attribute' for nil:NilClass
```
That means that the cookbook_collection was set before the node was
set on the run_context. That wouldn't be a bug in core chef, that must
be fixed in the caller to reverse the order of operations.
Since I only made the positional arguments to the run_context constructor
optional in Chef-15.0 though I don't expect this breaks any existing code
written in the past month or two, but if anything crops up in the future,
consider this a definitive statement that the caller must reverse the
order of their operations and this error being thrown is a feature not
a bug to be fixed.
(The fact that we silently aborted rather than threw a NoMethodError on
NilClass meant that we shipped this defect -- sometimes defensive
programming can be overly defensive and swallow real errors).
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is inspired by "use_inline_resources".
Setting `unified_mode false` in a resource would be the existing
behavior with separate compile/converge phases.
Setting `unified_mode true` in a resource will eliminate the converge
phase. Reverse notifications and delayed notifications will still
fire. The resource action will behave like all resources are executing
at compile time.
As a aside, notifications have never worked for resources firing at
compile time. This implementation gets that behavior correct so
that notifications will work.
Of course forward immediate notifications to resources not yet declared will not
be possible.
Setting `resource_unified_mode_default true` in `Chef::Config` would
turn off the split compile/converge mode for every custom resource.
NOTE: This does not affect recipe mode at all.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Layout/MultilineMethodCallBraceLayout
- Layout/ClosingParenthesisIndentation
- Layout/IndentFirstArgument
EnforcedStyle: consistent
- Layout/BlockEndNewline
the first of these autocorrected to horrible looking code which exposed
that we really needed the other three as well, which also cleaned up a
bunch of other terrible looking code.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
enforce pretzels.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
since we use double quotes, be consistent everywhere.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
| |
given how many regexps we have with /'s in the match this seems like
a very good one.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
start enforcing using %i{} instead of arrays of symbols
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|
|
|
| |
Signed-off-by: Tensibai <tensibai@iabis.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the relicensing effort.
Note that this PR leaves the knife and ohai binstubs still in the
gem(s) while that discussion is still ongoing.
This PR extracts the binstubs to chef-binstubs gem which is not intended
to be redistributed outside of the omnibus chef binaries.
A blank gem for chef-binstubs has been pushed to rubygems.org for
obvious security concerns and so that bundler/rubygems can resolve
the gem
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
Pun intentional.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|
|
|
| |
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
|
|\
| |
| |
| |
| | |
MsysTechnologiesllc/Vijay/MSYS-932_Fix_for_unable_to_access_databag_after_update_to_encrypt_data
Allow encrypting a previously unencrypted data bag
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Added specs for data_bag_create_specs
- Added specs for data_bag_edit_specs
- Added specs for data_bag_show_specs
- Ensured chefstyle
Signed-off-by: vijaymmali1990 <vijay.mali@msystechnologies.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously this was not possible. Now you can do this:
```
chef-client -o "" ./foo.rb
```
And it will only run foo.rb and not any of the recipes in your
run_list at all. Node will not be saved at the end.
Useful to one-shot something like keyrotation (which still needs
keys and needs to talk to the chef server API, so this is a
different use case from simple chef-apply).
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
| |
This just gives us a line count to the change and perhaps a starting
point for when we do this in Chef 15
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
Some of this supports older versions of Ruby 2.1/2.2 and others support Ruby 1.8
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
|
|
| |
We have a foodcritic rule to tell people not to do this
It's not being used anywhere and is just a pile of code we run for no reason
We should start warning that it's an unknown attribute when cookbooks contain these as it's wasted effort on the part of cookbook authors
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
|
| |
this is the result of changes to rules we already previously had
enabled.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
includes backcompat for 2.5
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
| |
rely on killing the thread to terminate the server, and rely on
thread#join to correctly signal to the main thread that the
server thread is dead, don't leak the server object out of the
helper.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
Remove the lazy loading of chef provisioning resources
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
|
|
|
| |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
|\
| |
| |
| | |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|