| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Autocorrected from RuboCop Performance which is now smart enough to detect when you use the match and when you don't. Using match? does not create any objects so it's slightly faster and uses less memory.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
|
|
|
|
|
|
| |
There's a RuboCop cop to fix these before Ruby 3 breaks it.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
|
|
|
|
| |
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
|
|
|
|
|
|
| |
Autocorrected with chefstyle after enabling that cop. It was very hard to read some complex autocorrected blocks w/o this.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
| |
The code this was used with is long gone
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The git provider now no longer checks out to a "deploy" branch by
default and now checks out to the branch (with a remote upstream) or
else checks out to a detatched head.
The prior behavior can be restored by using "checkout branch 'deploy'".
This also removes the SCM resource base class and replaces it with a
resource partial and does some internal reorganization.
It also introduces the RecipeDSLHelper for better functional tests and
cleans up the functional tests of the git provider.
Properties that were only ever implemented on the git provider were
removed from the subversion provider where they had been inherited from
the base class incorrectly.
Some additional env var handling was added to the subversion handler in
the process of sorting out the common properties, including HOME
handling for alternative users.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
| |
Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
|
|
|
| |
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
|
|
|
|
|
|
|
| |
This implements RFC-40 from the old chef rfc repo:
https://github.com/chef-boneyard/chef-rfc/blob/master/rfc040-on-demand-cookbook-libraries.md
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
I'm looking at you Ubuntu 20.04
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
| |
Merging in this check broke the build tests on Windows hosts.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
This reverts commit 88c07f9d240d90efe269a776f698c6b7ce47e067.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's provided by cheffish, but with one difference (force).
Unfortunately, that force can't be pushed to cheffish as-is because it
relies on ChefUtils.windows?. This could be changed to something
else... A global for all I care.
But, we might not want to push this commit yet. I just can't stand the
noise in the test output as I try to clean this stuff up.
Signed-off-by: Ryan Davis <zenspider@chef.io>
|
|
|
|
|
|
|
| |
Lots more in lib, but that's out of scope for this. I'm just trying to
make it easier to debug a failing spec when needed.
Signed-off-by: Ryan Davis <zenspider@chef.io>
|
|
|
|
| |
Signed-off-by: Ryan Davis <zenspider@chef.io>
|
|
|
|
|
|
|
| |
1. Bundler.with_clean_env is deprecated. Switched to with_unbundled_env.
2. When we test for win32/daemon existance, redir to dev/null.
Signed-off-by: Ryan Davis <zenspider@chef.io>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
Run it all.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
| |
Windows Nano isn't a thing anymore so we shouldn't spending compute time checking to see if we're on Windows Nano
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
|
|
| |
The new Rubocop detects more unnecessary returns. This fixes these ahead of time so we can roll out the new Rubocop engine without breaking builds later.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|\
| |
| | |
Add output for the file provider verification
|
| |
| |
| |
| |
| |
| |
| | |
- Fix failing specs.
- Fix long strings getting truncated for RSpec expectations.
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
| |
| |
| |
| |
| |
| | |
code 12
Signed-off-by: Jonathan Jones <gitmaster@thespooky.house>
|
| |
| |
| |
| | |
Signed-off-by: Jonathan Jones <gitmaster@thespooky.house>
|
| |
| |
| |
| | |
Signed-off-by: Jonathan Jones <gitmaster@thespooky.house>
|
| |
| |
| |
| | |
Signed-off-by: Jonathan Jones <gitmaster@thespooky.house>
|
|/
|
|
|
|
| |
Resolved new method in linux_user not returning the correct array.
Signed-off-by: Jonathan Jones <gitmaster@thespooky.house>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the implementation of [RFC-087](https://github.com/chef-boneyard/chef-rfc/blob/master/rfc087-distro-sugar-helpers.md)
although some of the specifics have been iterated on and changed.
The documentation will be in the [README.md](https://github.com/chef/chef/tree/master/chef-utils/README.md) once this is merged.
While this PR mostly moves chef-sugar utilities into core-chef via this chef-utils gem, the scope of the chef-utils gem
should be considered larger than just that. As an example this PR moves the Mash class into this gem for reuse in ohai
as well.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|\
| |
| | |
Add mac_user resource that is compatible with macOS >= 10.14
|
| |
| |
| |
| | |
Signed-off-by: Ryan Cragun <ryan@chef.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Convert to using TinyServer and remove the duplicated functionality
with the "app_server_support" helper.
The fact that this change hits the knife raw / knife redirection specs
that have so many timeout issues is very likely not a coincidence.
I would bet a small, but not entirely insignificant amount of money that
this makes those timeout issues go away.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|/
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Layout/MultilineMethodCallBraceLayout
- Layout/ClosingParenthesisIndentation
- Layout/IndentFirstArgument
EnforcedStyle: consistent
- Layout/BlockEndNewline
the first of these autocorrected to horrible looking code which exposed
that we really needed the other three as well, which also cleaned up a
bunch of other terrible looking code.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
enforce pretzels.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
since we use double quotes, be consistent everywhere.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
| |
given how many regexps we have with /'s in the match this seems like
a very good one.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lint/BlockAlignment:
Enabled: true
EnforcedStyleAlignWith: start_of_block
this works better with Layout/MultilineMethodCallIndentation to
force indentation of multiline method calls that wind up with multiline
blocks.
i'd probably pull back the end to match with the start of the expression
but this gets the indentation level inside the block correct.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
| |
zero args methods don't get parens.
this certainly reads better than the inverse.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
start enforcing using %i{} instead of arrays of symbols
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
| |
i like this one, gives visual priority to returns or raises that are
buried in the middle of things.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|