| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
no enforced trailing comma on arguments...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
252 Style/TrailingCommaInLiteral
84 Style/TrailingCommaInArguments
15 Style/SpaceAroundKeyword
--
351 Total
We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.
TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?
|
| |
|
|
|
|
|
|
|
|
|
| |
Style/NegatedWhile
Style/ParenthesesAroundCondition
Style/WhileUntilDo
Style/WordArray
Performance/ReverseEach
Style/ColonMethodCall
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
| |
|
| |
|
|
|
|
| |
Chocolatey.
|
| |
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
|
|
| |
Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
|
|
|
|
|
| |
1. Warn when default values are invalid.
2. Never validate nil (on set or get) if there is no default.
3. Emit "will be invalid in Chef 13" warning when setting an invalid nil value.
|
| |
|
|
|
|
| |
See #3570
|
|
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
|
|
|
|
|
|
|
| |
autocorrects some merges that will be broken when the next
chefstyle is released.
also runs chefstyle after the travis tests, because i'd rather know
how the code is broken rather than how its not pretty.
|
| |
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
|
|
|
| |
chefstyle -a fixed 1044 occurrances
|
|\
| |
| | |
really fix cops
|
| | |
|
|\ \
| | |
| | | |
assert candidates exist for alternate sources and when pinning versions
|
| | | |
|
|\ \ \
| |_|/
|/| | |
fixes #4354 and fixes #4372 stop trying to auto detect versions for exe installers
|
| |/
| |
| |
| | |
installers
|
|/
|
|
|
|
|
|
|
| |
fixes the following offenses:
46 Lint/EndAlignment
21 Lint/BlockAlignment
3 Lint/SpaceBeforeFirstArg
1 Lint/DefEndAlignment
|
| |
|
|\
| |
| | |
Fix failing package unit test
|
| | |
|
| | |
|
|/ |
|
| |
|
|\
| |
| | |
adds support for installer types inno, nsis, wise and installshield to windows_package resource
|
| |
| |
| |
| | |
windows_package resource
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously dpkg -s would allow a 0 or 1 exit status and it wasn't
entirely clear why this was so either from the code or the tests.
This restores throwing an exception if we are outside of the [0,1]
range, and then adds tests for both behaviors:
- on old ubuntu/debian we get an exit(0) and output on stdout if the
file is not installed
- on newer ubuntu/debian we get an exit(1) and output on stderr if
the file is not installed
Added tests for both those cases, and the case where dpkg -s does
some other kind of exitcode barf and we should raise.
|
|
|
|
|
|
|
|
| |
- multipackages dpkg_package
- fixes edge conditions in load-current-resource around purging/removing
packages that threw errors before
- fixes the ability to purge packages that have been removed
- adds a lot of functional tests for dpkg_package
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- :update and :install are now treated the same way and throw the
same exceptions
- :remove and :purge don't require the source at all, so don't do
any checking on that
- fix some convoluted side-effecty logic in load_current_resource
- load_current_resource now correctly gets the dpkg state on
:remove and :purge when the file does not exist (pretty sure
the old logic did not)
- fixed the FIXME about using en_US.UTF-8 (the default for shell_out!)
- just use shell_out! to throw exceptions
- clean up all the specs and remove all the instance vars from the code
|
|
|
|
|
|
|
|
|
|
|
| |
Fedora 21+ use dnf as the primary package manager. Lamont added code in
12.5 to allow for a yum compat mode. This doesn't entirely work though
as we need yum-dump.py to correctly run. We were parsing the shabang in
the yum binary to find the path to python. On a dnf system the yum
binary is a bash script though so we were trying to run yum-dump.py
using bash which obviously fails. I added a fallback method to use
python if the shebang parsing returns bash. With this in place AND the
yum package installed you can use the package resource on Fedora.
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
gem_package should install to the systemwide Ruby when using ChefDK.
|
| | |
|
| |
| |
| |
| | |
Thanks to @kwilczynski for the original implementation
|
| |
| |
| |
| |
| | |
Call all the methods Provider#run_action would call rather than just
poking lower-level implementation.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Most egregious problem was stubbing two shellout calls at once, which
was confusing and let some shell_out calls slip though the stubbing.
Also added a bogus catchall stub to ensure that all calls to shell out
have a corresponding stub.
Additionally, re-arranged some tests which were not in a sensible test
context.
|