| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
|
|
| |
Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
|
|
|
|
|
| |
1. Warn when default values are invalid.
2. Never validate nil (on set or get) if there is no default.
3. Emit "will be invalid in Chef 13" warning when setting an invalid nil value.
|
|\
| |
| | |
Add an apt_update resource
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
See #3570
|
|
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
|
|
|
|
|
|
|
| |
autocorrects some merges that will be broken when the next
chefstyle is released.
also runs chefstyle after the travis tests, because i'd rather know
how the code is broken rather than how its not pretty.
|
| |
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
|
|
|
| |
chefstyle -a fixed 1044 occurrances
|
|
|
|
|
|
|
|
|
|
|
| |
so, this is a bit special...
the API for "priority" is clearly broken. but this broken API comes
from the service resource itself which appears to have been broken
by design since at least 2010.
just fixing the code for how it behaves and dropping in FIXMEs
for now, since this uncovered a fairly massive API-breaking yak.
|
|\
| |
| | |
really fix cops
|
| | |
|
|\ \
| | |
| | | |
assert candidates exist for alternate sources and when pinning versions
|
| | | |
|
|\ \ \
| |_|/
|/| | |
fixes #4354 and fixes #4372 stop trying to auto detect versions for exe installers
|
| |/
| |
| |
| | |
installers
|
|\ \
| | |
| | | |
chefstyle: fix Lint/StringConversionInInterpolation
|
| |/
| |
| |
| | |
useless use of `"#{foo.to_s}"`
|
|/
|
|
|
|
|
|
|
| |
fixes the following offenses:
46 Lint/EndAlignment
21 Lint/BlockAlignment
3 Lint/SpaceBeforeFirstArg
1 Lint/DefEndAlignment
|
|\
| |
| | |
add chocolatey_package to core chef
|
| | |
|
|/
|
|
|
|
|
| |
In the process, stop auto-expanding JSON in the HTTP client, and let
individual classes control that themselves.
Fixes #2737, Fixes #3518
|
|\
| |
| | |
fix run_as_user of windows_service
|
| |
| |
| |
| | |
not clobber existing service rights of other users
|
| |
| |
| |
| | |
Fixed resource to use let
|
|\ \
| |/
|/| |
Fix failing package unit test
|
| | |
|
| | |
|
|/ |
|
| |
|
|\
| |
| | |
adds support for installer types inno, nsis, wise and installshield to windows_package resource
|
| |
| |
| |
| | |
windows_package resource
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously dpkg -s would allow a 0 or 1 exit status and it wasn't
entirely clear why this was so either from the code or the tests.
This restores throwing an exception if we are outside of the [0,1]
range, and then adds tests for both behaviors:
- on old ubuntu/debian we get an exit(0) and output on stdout if the
file is not installed
- on newer ubuntu/debian we get an exit(1) and output on stderr if
the file is not installed
Added tests for both those cases, and the case where dpkg -s does
some other kind of exitcode barf and we should raise.
|
| |
|
|
|
|
|
|
|
|
| |
- multipackages dpkg_package
- fixes edge conditions in load-current-resource around purging/removing
packages that threw errors before
- fixes the ability to purge packages that have been removed
- adds a lot of functional tests for dpkg_package
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- :update and :install are now treated the same way and throw the
same exceptions
- :remove and :purge don't require the source at all, so don't do
any checking on that
- fix some convoluted side-effecty logic in load_current_resource
- load_current_resource now correctly gets the dpkg state on
:remove and :purge when the file does not exist (pretty sure
the old logic did not)
- fixed the FIXME about using en_US.UTF-8 (the default for shell_out!)
- just use shell_out! to throw exceptions
- clean up all the specs and remove all the instance vars from the code
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* removes the mutation of the new_resource.version
* adds package_class_supports_arrays for multipackage providers
* cleans up the package resource initializer and sets the package_name
correctly through the accessor method.
By mutating new_resource.version we were destroying the original intent
of what the user was requesting. This is a bug that must be fixed.
Generally, subclasses will be able to get the correct information they
need through either the version argument they were passed in
install_package(name, version) instead, or through their
`#target_version_array` method. If this breaks anything then those
providers need bugfixes as well (since this is a change to an internal
API accessible only to subclassing, and there are backwards compatible
and correct ways to get the information, this is *not* a SemVer
violating change). See the fix I made to the OpenBSD provider to
preserve the same semantics, avoid using new_resource.version where it
was inappropriate, and make the code more symmetrical where before
substantially different looking code in install_package and
remove_package had exactly the same ultimate effect.
The package_class_supports_arrays 'DSL' for writing multipackage
providers coerces the arguments to the virtual methods (e.g.
install_package) into arrays, even if the user is only requesting a
single package install. This removes most of the `is_a?(Array)`
checks from the implementation subclasses.
The cleanup of the initializer is similarly necessary so that we can
use Chef 12.5 coercions to make the package_name and version arguments
accept string, but always be Arrays. This should eliminate the rest
of the need to write `is_a?(Array)` code all over the package provider
implementations.
|
|\
| |
| | |
Implement live streaming for execute resources
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the logic is now:
if the resource is not sensitive, and if it's explicitly requested to be
streamed or if the log level is info or debug, then we'll consider
streaming it.
If we're configured to send the output to the events stream, we'll do
so.
Otherwise, if we're not daemonized and have a TTY, we'll go to STDOUT
|
| | |
|