summaryrefslogtreecommitdiff
path: root/spec/unit
Commit message (Collapse)AuthorAgeFilesLines
* Autofixing Style/PercentLiteralDelimeterslcg/percentliteraldelimetersLamont Granquist2016-01-1833-97/+97
| | | | | | See chef/chefstyle#11 for analysis and discussion. We select '{}' since audit of our source code shows that is the most common, and that used to be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
* fix chefstyle failuresLamont Granquist2016-01-151-2/+2
| | | | | | | | autocorrects some merges that will be broken when the next chefstyle is released. also runs chefstyle after the travis tests, because i'd rather know how the code is broken rather than how its not pretty.
* adding functional tests for chocolatey providerchoco_func_testsMatt Wrock2016-01-141-6/+19
|
* ServerAPI will return a raw hash, so do thattm/fix_failing_testThom May2016-01-141-2/+1
|
* Use double quotes by defaultThom May2016-01-14460-4931/+4931
| | | | | | | This is an entirely mechanically generated (chefstyle -a) change, to go along with chef/chefstyle#5 . We should pick something and use it consistently, and my opinion is that double quotes are the appropriate thing.
* Merge pull request #4398 from chef/lcg/trailing_commaThom May2016-01-14100-557/+557
|\ | | | | autocorrecting Style/TrailingComma
| * autocorrecting Style/TrailingCommalcg/trailing_commaLamont Granquist2016-01-13100-557/+557
| | | | | | | | chefstyle -a fixed 1044 occurrances
* | Correctly save policy_name and policy_group with `knife node edit`jr/knife-node-edit-save-policy_name-groupJordan Running2016-01-131-0/+211
|/ | | | | | | | | | | | | Fixes #4364 - Add specs for Chef::Knife::NodeEditor. - Add `policy_name` and `policy_group` to properties compared in `NodeEditor#updated?`. - Add `policy_name` and `policy_group` to Hash returned by `NodeEditor#view`. - Use `Node.from_hash` in `NodeEditor#apply_updates` instead of duplicating functionality. - Add some YARD docs for Chef::Knife::NodeEditor.
* Merge pull request #4393 from chef/lcg/duplicated-keysLamont Granquist2016-01-131-3/+6
|\ | | | | fix Lint/DuplicatedKey
| * fix Lint/DuplicatedKeylcg/duplicated-keysLamont Granquist2016-01-131-3/+6
| | | | | | | | | | | | | | | | | | | | | | so, this is a bit special... the API for "priority" is clearly broken. but this broken API comes from the service resource itself which appears to have been broken by design since at least 2010. just fixing the code for how it behaves and dropping in FIXMEs for now, since this uncovered a fairly massive API-breaking yak.
* | Merge pull request #4395 from chef/lcg/lint-cops-againThom May2016-01-131-3/+3
|\ \ | | | | | | yet more lint cops
| * | yet more lint copslcg/lint-cops-againLamont Granquist2016-01-131-3/+3
| |/ | | | | | | | | | | | | fixes: Lint/AmbiguousOperator Lint/DuplicateMethods
* | Move server and repository fs objects to their own directoriesJohn Keiser2016-01-131-3/+3
|/
* Merge pull request #4344 from chef/if/warn-on-reload-resourceThom May2016-01-131-2/+2
|\ | | | | Warn (v. info) when reloading resources
| * debug log messages upon reloaded resourcesif/warn-on-reload-resourceIsa Farnik2016-01-121-2/+2
| | | | | | | | tests for debug messages when reloading resources
* | Merge pull request #4388 from chef/lcg/more-rubocop-lintThom May2016-01-131-8/+5
|\ \ | |/ |/| more rubocop fixes
| * more rubocop fixeslcg/more-rubocop-lintLamont Granquist2016-01-121-8/+5
| | | | | | | | | | | | | | | | | | | | | | fixes: Lint/UnreachableCode Lint/NonLocalExitFromIterator Lint/LiteralInCondition Lint/EmptyEnsure Lint/DefEndAlignment Lint/CircularArgumentReference
* | Merge pull request #4384 from chef/lcg/really-fix-copsLamont Granquist2016-01-123-19/+21
|\ \ | | | | | | really fix cops
| * | really fix copslcg/really-fix-copsLamont Granquist2016-01-123-19/+21
| |/
* | Merge pull request #4378 from chef/choco_editsMatt Wrock2016-01-121-3/+31
|\ \ | | | | | | assert candidates exist for alternate sources and when pinning versions
| * | assert candidates exist for alternate sources and when pinning versionsMatt Wrock2016-01-121-3/+31
| | |
* | | Merge pull request #4375 from chef/no_version_detectMatt Wrock2016-01-121-69/+5
|\ \ \ | |_|/ |/| | fixes #4354 and fixes #4372 stop trying to auto detect versions for exe installers
| * | fexes #4354 and fiexs #4372 stop trying to auto detect versions for exe ↵no_version_detectMatt Wrock2016-01-111-69/+5
| |/ | | | | | | installers
* | Merge pull request #4381 from chef/lcg/useless-to-sLamont Granquist2016-01-126-13/+13
|\ \ | | | | | | chefstyle: fix Lint/StringConversionInInterpolation
| * | chefstyle: fix Lint/StringConversionInInterpolationLamont Granquist2016-01-126-13/+13
| |/ | | | | | | useless use of `"#{foo.to_s}"`
* | fix some lint copsLamont Granquist2016-01-1213-15/+15
|/ | | | | | | | | fixes the following offenses: 46 Lint/EndAlignment 21 Lint/BlockAlignment 3 Lint/SpaceBeforeFirstArg 1 Lint/DefEndAlignment
* Merge pull request #4106 from chef/lcg/chocolatey-packageLamont Granquist2016-01-113-1/+490
|\ | | | | add chocolatey_package to core chef
| * chocolatey multipackage providerlcg/chocolatey-packageLamont Granquist2016-01-083-1/+490
| |
* | Convert all uses of Chef::REST to Chef::ServerAPItm/no_more_restThom May2016-01-1138-268/+258
|/ | | | | | | In the process, stop auto-expanding JSON in the HTTP client, and let individual classes control that themselves. Fixes #2737, Fixes #3518
* Merge pull request #4315 from bbbco/masterThom May2016-01-041-0/+20
|\ | | | | Add extra tests around whether to skip with multiple guards
| * Add extra tests around whether to skip with multiple guardsbbbco2015-12-151-0/+20
| |
* | Merge pull request #4321 from chef/service_userMatt Wrock2015-12-291-27/+18
|\ \ | | | | | | fix run_as_user of windows_service
| * | fixes #3521 correcting format of user name passed to policy apis and does ↵Matt Wrock2015-12-291-27/+18
| | | | | | | | | | | | not clobber existing service rights of other users
* | | Merge pull request #4333 from chef/vaultMatt Wrock2015-12-224-31/+41
|\ \ \ | | | | | | | | no longer wait on node search to refresh vault but pass created ApiCient instead
| * | | no longer wait on node search to refresh vault but pass created ApiClient ↵Matt Wrock2015-12-224-31/+41
| | | | | | | | | | | | | | | | instead
* | | | Added profile provider for OS XNate Walck2015-12-173-0/+329
|/ / / | | | | | | | | | Fixed resource to use let
* | | Merge pull request #4320 from chef/jk/fix-package-nil-warningJay Mundrawala2015-12-161-5/+1
|\ \ \ | |/ / |/| | Fix failing package unit test
| * | Fix failing package unit testjk/fix-package-nil-warningJohn Keiser2015-12-161-5/+1
| | |
* | | Merge pull request #4277 from chef/mwrock/packageMatt Wrock2015-12-151-7/+17
|\ \ \ | |_|/ |/| | non msi packages must explicitly provide a source attribute on install
| * | fixing post merge test breaksMatt Wrock2015-12-151-2/+2
| | |
| * | non msi packages must explicitly provide a source attribute on installMatt Wrock2015-12-151-5/+15
| |/
* | Add knife/ChefFS support for policyfiles and policy_groups.John Keiser2015-12-151-4/+0
|/
* Use properties in package resourcesjk/package-propertiesJohn Keiser2015-12-153-7/+1
|
* Merge pull request #4309 from chef/lcg/fix-tags-and-set-unlessThom May2015-12-151-1/+25
|\ | | | | tags always an array; fix set_unless
| * really always return an Arraylcg/fix-tags-and-set-unlessLamont Granquist2015-12-141-0/+12
| |
| * tags always an array; fix set_unlessLamont Granquist2015-12-141-1/+13
| | | | | | | | | | | | | | previously if the node had a { normal: { tags: nil } } that we read since the key existed (but was nil) we would not initialize with an array. replacing the code with a call to node.set_unless revealed that set_unless was similarly buggy. fixed both issues by fixing set_unless.
* | why is 'identity' different than 'name_property'?Lamont Granquist2015-12-141-1/+1
| |
* | Don't warn when setting a property to nil unless its value wouldjk/updates2John Keiser2015-12-141-12/+14
|/ | | | | actually change. Gets rid of cases where we are initializing a resource with values from another resource.
* Merge pull request #4273 from chef/jdm/default-auth-1.1Jay Mundrawala2015-12-112-42/+23
|\ | | | | Use signing protocol 1.1 by default
| * Use signing protocol 1.1 by defaultjdm/default-auth-1.1Jay Mundrawala2015-12-102-42/+23
| | | | | | | | | | | | | | | | | | | | | | All supported Chef servers support the 1.1 signing protocol. There is no reason to continue using 1.0, and removing it as the default allows us to remove a bunch of code that tries to upgrade 1.0 to 1.1 when the node name is too long. If the user specifies 1.0 as the auth protocol version from this point on, they will have to guarantee that the node name is not too long.
View Lorry Controller Status