summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Specify a profile on the command lineThom May2017-12-181-0/+2
| | | | Signed-off-by: Thom May <thom@chef.io>
* Generate a credentials fileThom May2017-12-141-60/+10
| | | | Signed-off-by: Thom May <thom@chef.io>
* Merge pull request #6654 from ↵Tim Smith2017-12-111-4/+11
|\ | | | | | | | | MsysTechnologiesllc/vasundhara/chef_windows_task_resource_not_idempotent_for_any_command windows_task: Fix resource isn't fully idempotent due to command property
| * [MSYS-731] Fix for [chef] windows_task resource isn't idempotent for any commandVasu11052017-12-111-4/+11
| | | | | | | | Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
* | Merge pull request #6618 from MsysTechnologiesllc/nim/on_logon_issueTim Smith2017-12-111-0/+16
|\ \ | | | | | | Invalid date error on windows_task with frequency :on_logon
| * | invalid date error on windows_task with frequency :on_logonnimisha2017-12-081-0/+16
| | | | | | | | | | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
* | | Fix sneaky chefstyle violationstm/fix_chefstyleThom May2017-12-111-3/+3
| |/ |/| | | | | Signed-off-by: Thom May <thom@chef.io>
* | Merge pull request #6636 from EmFl/patch-1Thom May2017-12-101-1/+22
|\ \ | | | | | | Ensure data bags names can contain reserved words
| * | added test for data bag name containing reserved wordEmilien2017-12-091-1/+22
| | |
* | | Merge pull request #6628 from chef/more_taskTim Smith2017-12-082-18/+97
|\ \ \ | |/ / |/| | windows_task: Add additional input validation to properties
| * | Update the start_time spec for the new messageTim Smith2017-12-081-1/+1
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | These are all input validation errors so they should raise ArgumentError not ↵more_taskTim Smith2017-12-081-9/+9
| | | | | | | | | | | | | | | | | | RuntimeError Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Expect the right exceptionsTim Smith2017-12-081-23/+23
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Properly handle an ISO8601 duration of 0 secondsTim Smith2017-12-081-0/+3
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add tests for invalid datesTim Smith2017-12-071-2/+21
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Improve the integer/string warning messageTim Smith2017-12-072-5/+5
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Validate the start_date is correctly passedTim Smith2017-12-071-1/+1
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | allow random_delay and execution_time_limit to be integers and properly validateTim Smith2017-12-071-11/+37
| | | | | | | | | | | | | | | | | | Also set the default the right way with execution_time_limit Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Validate that starttime is actually in HH:mm formatTim Smith2017-12-071-0/+10
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Test lowercase system users not requiring passwordsTim Smith2017-12-071-0/+5
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add testing of sec_to_durTim Smith2017-12-071-0/+16
| |/ | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #6631 from chef/jsinha/fix_svcadmThom May2017-12-081-5/+6
|\ \ | | | | | | Solaris: Fix svcadm clear to only run in maintenance state
| * | Fix svcadm clear to only run in maintenance statejsinha/fix_svcadmJaymala Sinha2017-12-071-5/+6
| |/ | | | | | | | | Signed-off-by: Jaymala Sinha <jsinha@chef.io> Signed-off-by: Patrick Wright <patrick@chef.io>
* | fix alphabetic sorting of classeslcg/node-map-speedupLamont Granquist2017-12-071-0/+16
|/ | | | | | but we really shouldn't do this... Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Improve the passwordless user error, logic, and testsimproved_task_loggingTim Smith2017-12-062-14/+19
| | | | | | Specify exactly what we're checking for in the error. This needs to go into the docs site as well. Signed-off-by: Tim Smith <tsmith@chef.io>
* Update resource specsTim Smith2017-12-061-14/+14
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Clarify that we're talking about the 1 and only SYSTEM user hereTim Smith2017-12-062-2/+2
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #6625 from chef/lcg/lwrp-test-speedupLamont Granquist2017-12-065-35/+56
|\ | | | | speedup lwrp tests
| * travis caught another speclcg/lwrp-test-speedupLamont Granquist2017-12-061-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * speedup lwrp testsLamont Granquist2017-12-064-34/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reset the global resource and provider handler maps before each and every test. note that mutation through the top-level keys will get preserved so this is not perfect, but deep-duping through every single test we run becomes expensive. this is sufficient to flush out the global state of all the test lwrp fixtures that we setup. it discovered several usage bugs where we either relied on this feature or where we were testing different fixtures from the ones we thought we were. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #6424 from chef/lcg/deep-merge-cache-rewriteLamont Granquist2017-12-064-54/+117
|\ \ | | | | | | Node attributes per-container lazy deep merge and deep merge performance improvements
| * | fixup some unit testslcg/deep-merge-cache-rewriteLamont Granquist2017-12-061-6/+7
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | remove more debugging and revert no-longer necessary fixLamont Granquist2017-12-061-4/+2
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | Per-container deep merge cachingLamont Granquist2017-12-063-47/+111
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces the one-big top level deep merge cache with individual deep merge caches in every container. The Immutable container state becomes the deep merge cache. - Does not use a pure decorator style approach since that failed before because of ruby internals breaking things like `===` and `=~` on decorated objects, so we inherit (ultimately from Hash + Array). - The state being the container state is useful in ruby since APIs on Hash and Array poke around in internal state to make things fast. If we inherit from Hash/Array but don't have the correct internal state things go wonky. - Throwing away the internal state is equivalent to flushing the cache. - Since we throw away all linked objects when we do that, we flush at every level below the level being flushed (which is correct semantics). - If a user has a pointer to an old immutable object from a sub-level, that isn't mutated so the old object still contains the old view of the data (which I think is correct, although I have some doubts that its necessary, but it came along free for the ride). - When we reset the cache we do mutate the cache being reset, which might change data in held references. If this becomes an issue the fix would be to reset the cache at the level above by creating a new, "empty" ImmutableHash/ImmutableArray object and inserting it into the deep_merge_cache datastructure instead of clearing the internal state of the child object. I don't know practically how anyone would hit this, though, so would prefer to wait on doing that work until we see an actual bug report. - Because of the way ruby pokes around internally there's some weirdnesses like the pre-generation of the cache for all the values of a subarray when #each is called, which is due to the way that ruby walks through array-serialized hashes when called like: `Array#each { key, value| ... }` (which is an undocumented(?) thing in ruby). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Fixup the functional testsTim Smith2017-12-061-2/+2
|/ | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #6590 from mal/knife-ssh-prefixLamont Granquist2017-12-012-46/+122
|\ | | | | Knife SSH prefix option
| * Add custom prefix attribute support to knife sshMal Graty2017-11-282-15/+101
| | | | | | | | Signed-off-by: Mal Graty <mal.graty@googlemail.com>
| * Refactor SSH attributeMal Graty2017-11-282-29/+19
| | | | | | | | Signed-off-by: Mal Graty <mal.graty@googlemail.com>
| * TyposMal Graty2017-11-282-2/+2
| | | | | | | | Signed-off-by: Mal Graty <mal.graty@googlemail.com>
* | Merge pull request #6576 from cma-arnold/masterLamont Granquist2017-11-291-15/+71
|\ \ | | | | | | Hide sensitive properties in converge_if_changed.
| * | Hide sensitive properties in converge_if_changed.Chris Arnold2017-11-271-15/+71
| | | | | | | | | | | | Signed-off-by: Chris Arnold <cma.arnold@gmail.com>
* | | Merge pull request #6541 from chef/path_idempotencyLamont Granquist2017-11-291-1/+1
|\ \ \ | | | | | | | | Fix windows_path converging on every run
| * | | Fix typo in path specspath_idempotencyTim Smith2017-11-281-1/+1
| | |/ | |/| | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #6608 from chef/lcg/nodemap-platform-versionsLamont Granquist2017-11-291-0/+18
|\ \ \ | |/ / |/| | fix NodeMap to not throw exceptions on platform_versions
| * | fix NodeMap to not throw exceptions on platform_versionslcg/nodemap-platform-versionsLamont Granquist2017-11-281-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | Chef::Version and VersionConstraint are for x.y/x.y.z cookbook versions, and are always wrong for anything other than cookbooks. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Forgot to check for a unit test. Sigh.Noah Kantrowitz2017-11-272-9/+16
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
* | | Remove empty line.Noah Kantrowitz2017-11-271-1/+0
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
* | | Tests++.Noah Kantrowitz2017-11-271-1/+9
| |/ |/| | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
* | Merge pull request #6544 from MsysTechnologiesllc/nim/invalid_date_errThom May2017-11-231-0/+27
|\ \ | | | | | | [MSYS-688] Fixed invalid date and Invalid starttime error
| * | Unit tests for invalid date and starttime errornimisha2017-11-151-0/+27
| | | | | | | | | | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
View Lorry Controller Status