summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Remove the spec for epic_failepic_fail_specTim Smith2018-01-291-5/+0
| | | | | | Missed this one Signed-off-by: Tim Smith <tsmith@chef.io>
* the format of this flametest doesn't matterlcg/fix-powershell-outLamont Granquist2018-01-291-21/+5
| | | | | | | we don't need to test the exact output of this powershell command, just get literally anything that looks like it ran successfully. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Merge pull request #6494 from Rarian/lock_package_idempotencyLamont Granquist2018-01-292-20/+64
|\ | | | | Ensure package (un)locking is idempotent
| * Ensure package (un)locking is idempotentAndy Wagner2018-01-042-20/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to the nature of the comparison done, the `package_locked` methods will always return false as they presume the package name is a string, when it is in fact always coerced into an array. Additionally in situations where the package_name is set rather than being inherited from the package resource's name, it will always return false. Resolves #6361 Resolves #6493 Signed-off-by: Andy Wagner <andy@andywagner.ca>
* | Merge pull request #6804 from ↵Thom May2018-01-292-19/+457
|\ \ | | | | | | | | | | | | jasonwbarnett/feature/add-create-delete-and-configure-actions-to-windows_service Add create, delete and configure actions to windows_service
| * | Add description property to converge configure actionJason Barnett2018-01-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
| * | Remove temporary lineJason Barnett2018-01-271-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
| * | chefstyle -aJason Barnett2018-01-262-62/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
| * | Fix existing tests and add new onesJason Barnett2018-01-262-19/+459
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
* | | Nillable properties are the default nowtm/true_nillableThom May2018-01-261-5/+0
|/ / | | | | | | | | | | Fixes: #6054 Signed-off-by: Thom May <thom@chef.io>
* | fix node assignment of ImmutableArrays to VividMashes/AttrArraysLamont Granquist2018-01-251-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | node.default['foo'] = node['bar'] need to have node['bar'] have its cache vivified otherwise we potentially get an empty hash or array. in the case of hashes, the assignment must have been walking though the values with #each or something which poked the cache on the target hash which caused it to vivify, so this bug only affected Arrays where the AttrArray initializer likely did a quick-n-dirty copy of the internal structure of the ImmutableArray which was empty. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #6687 from ↵Bryan McLellan2018-01-253-8/+113
|\ \ | | | | | | | | | | | | MsysTechnologiesllc/nim/logonSession_user_permission [MSYS-724] Chef::Util::Windows::LogonSession should allow having only the prescribed users permissions
| * | Fixed/added specs for LogonSession changesnimisha2018-01-243-2/+39
| | | | | | | | | | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
| * | Fixed/added specs for LogonSession changesnimisha2018-01-243-1/+44
| | | | | | | | | | | | Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
| * | Brought back Chef::Win32::Security functional test for running as a non ↵nimisha2018-01-241-2/+1
| | | | | | | | | | | | | | | | | | admin user Signed-off-by: nimisha <nimisha.sharad@msystechnologies.com>
| * | add missing functional tests for usersMSys2018-01-241-7/+33
| | | | | | | | | | | | Signed-off-by: MSys <harikesh.kolekar@msystechnologies.com>
* | | Merge pull request #6761 from ↵Tim Smith2018-01-241-2/+303
|\ \ \ | | | | | | | | | | | | | | | | MsysTechnologiesllc/ash/add_idempotent_check_to_windows_task Added idempotent checks to windows_task_spec
| * | | Fix review comment and chefstyleNAshwini2018-01-241-5/+4
| | | | | | | | | | | | | | | | Signed-off-by: NAshwini <ashwini.nehate@msystechnologies.com>
| * | | Added idempotent checks to windows_task_specNAshwini2018-01-241-2/+304
| |/ / | | | | | | | | | Signed-off-by: NAshwini <ashwini.nehate@msystechnologies.com>
* | | Merge pull request #6778 from chef/lcg/immutable-node-apisThom May2018-01-241-1/+11
|\ \ \ | |/ / |/| | update immutable API blacklist and whitelist
| * | update immutable API blacklist and whitelistLamont Granquist2018-01-231-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adds the whitelist so that when we update to new ruby versions it forces us to audit the new Array and Hash methods and figure out if they are mutators or not. this change closes the Hash#store loophole that was being abused by some cookbook consumers to directly modify merged ImmutableHashes (producing inherently undefined behavior that we 'broke' at one point). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Merge pull request #6775 from chef/lcg/speed-up-http-func-testsLamont Granquist2018-01-232-18/+28
|\ \ \ | |/ / |/| | speed up http func tests
| * | speed up http func testslcg/speed-up-http-func-testsLamont Granquist2018-01-232-18/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For the truncated downloads the tiny server needs to hit its RequestTimeout in order to terminate the truncated request, so that is set to 1 second. Then also drop down the retries and the rest_timeout on the client side (but keep the rest_timeout to 2 to keep it above the tiny_server timeout) Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Revert "Fail on interval runs on windows"Lamont Granquist2018-01-232-5/+5
| | |
* | | Merge pull request #6766 from chef/lcg/windows-intervalThom May2018-01-232-5/+5
|\ \ \ | | | | | | | | Fail on interval runs on windows
| * | | fail on interval runs on windowslcg/windows-intervalLamont Granquist2018-01-222-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | closes #4824 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Added support for setting node policy name and group from knifepiyushawasthi2018-01-231-0/+122
| |/ / |/| | | | | | | | Signed-off-by: piyushawasthi <piyush.awasthi@msystechnologies.com>
* | | Merge pull request #6765 from chef/lcg/node-map-last-writer-winsLamont Granquist2018-01-224-37/+37
|\ \ \ | | | | | | | | Convert node map to last-writer-wins for ties
| * | | fix integration testslcg/node-map-last-writer-winsLamont Granquist2018-01-221-26/+26
| | | |
| * | | Convert node map to last-writer-wins for tiesLamont Granquist2018-01-223-11/+11
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We still bind preferentially by specificity, but for ties with specificity we now prefer last-writer-wins instead of the alphabetic by class name method we had before (that was never documented and I'm pretty certain nobody understood). So now `provides(:whatever) { true }` in a cookbook should always win over core. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Merge pull request #6762 from chef/lcg/remove-node-setLamont Granquist2018-01-221-15/+1
|\ \ \ | | | | | | | | Remove node.set and node.set_unless attribute levels
| * | | Chef-14 Breaking: remove node.set and node.set_unlesslcg/remove-node-setLamont Granquist2018-01-221-15/+1
| |/ / | | | | | | | | | | | | | | | been deprecated since late-12. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Rename the OpenSSL mixin to avoid name conflictsTim Smith2018-01-221-3/+3
|/ / | | | | | | | | | | This way people don't have to refactor their code from OpenSSL::Whatever to ::OpenSSL::Whatever Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #6736 from chef/openssl_resourcesTim Smith2018-01-224-0/+401
|\ \ | | | | | | Add dhparam, rsa_private_key and rsa_public_key resources
| * | Chefstyle fixopenssl_resourcesTim Smith2018-01-121-2/+2
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Remove node from the specsTim Smith2018-01-123-3/+0
| | | | | | | | | | | | | | | | | | We're not using this here anymore Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add some resource specsTim Smith2018-01-123-0/+152
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add tests for the mixinTim Smith2018-01-051-0/+252
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #6719 from chef/dash_r_soloThom May2018-01-221-8/+1
|\ \ \ | | | | | | | | Remove deprecated -r option for Solo mode
| * | | Remove deprecated -r option for Solo modedash_r_soloTim Smith2018-01-011-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We claimed we were going to remove this in Chef 13. Let's stop rewriting ARGs now. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Merge pull request #6728 from chef/reindexThom May2018-01-221-125/+0
|\ \ \ \ | | | | | | | | | | Remove knife index rebuild command that requires Chef < 11
| * | | | Remove knife index rebuild command that requires Chef < 11reindexTim Smith2018-01-041-125/+0
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | knife index rebuild only works on Chef Server < 11. We no longer support Chef Server 10 and anyone still using 10 should use an older DK or gem install of chef for management. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Merge pull request #6718 from chef/chef14_deprecationsThom May2018-01-221-13/+0
|\ \ \ \ | | | | | | | | | | Remove previously deprecated mixins and Chef::DSL::Recipe::FullDSL
| * | | | Remove previously deprecated mixins and Chef::DSL::Recipe::FullDSLchef14_deprecationsTim Smith2018-01-011-13/+0
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We wired these up previously with deprecations. They've been deprecated for a long time and are pretty rarely used on the Supermarket. Additionally we have Foodcritic rules to detect their usage: FC102: Deprecated Chef::DSL::Recipe::FullDSL class used FC100: Deprecated Chef::Mixin::Language mixin used FC099: Deprecated Chef::Mixin::LanguageIncludeRecipe mixin used FC098: Deprecated Chef::Mixin::RecipeDefinitionDSLCore mixin used FC097: Deprecated Chef::Mixin::LanguageIncludeAttribute mixin used Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Merge pull request #6753 from chef/deprecated_resourcesThom May2018-01-2210-2191/+0
|\ \ \ \ | | | | | | | | | | Remove erl_call and deploy resources
| * | | | Remove erl_call and deploy resourcesdeprecated_resourcesTim Smith2018-01-2010-2191/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We deprecated these for removal in Chef 14. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | | Merge pull request #6760 from chef/resource_spec_cleanupThom May2018-01-2151-274/+107
|\ \ \ \ \ | | | | | | | | | | | | Remove useless class tests and cleanup specs
| * | | | | Remove useless class tests and cleanup specsresource_spec_cleanupTim Smith2018-01-2051-274/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We create the class then instantly check that it's exactly what we created. There's not much value in that. This also converts more things over to let. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | | | Merge pull request #6758 from chef/tm/creds_int_testsThom May2018-01-211-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Ensure we don't use credentials during integration tests
| * | | | | | Ensure we don't use credentials during integration teststm/creds_int_testsThom May2018-01-191-0/+5
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Thom May <thom@chef.io>