summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Improve comma separated list splitting in group resourcegroup_propertiesTim Smith2018-07-171-16/+16
| | | | | | | | | | | | | | | This is the same thing I did in sudo. It just makes the string parsing a bit more user spacing proof. accepted before: - 1,2,3 accepted now: - 1,2,3 - 1, 2, 3 - 1 ,2 ,3 - any combo of the above 3 Signed-off-by: Tim Smith <tsmith@chef.io>
* Fix functional specs to set properties to empty arraysTim Smith2018-07-161-2/+2
| | | | | | These can't be directly set to nil anymore. Signed-off-by: Tim Smith <tsmith@chef.io>
* Simplify platform detection in the group functional specsTim Smith2018-07-161-5/+5
| | | | | | We're trying to catch everything linux here. Just catch that. Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove the gating logic for testing on macOS 10.6Tim Smith2018-07-161-5/+1
| | | | | | This is ancient and we don't have to worry about it. Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #7466 from chef/knife_supermarketTim Smith2018-07-134-15/+19
|\ | | | | Move all knife cookbook site plugin logic into knife supermarket
| * Move all plugin logic into knife supermarketknife_supermarketTim Smith2018-07-134-15/+19
| | | | | | | | | | | | | | | | We want to deprecate knife cookbook site. This moves all the logic into the knife supermarket plugins and has the legacy knife cookbook site plugins inherit from that. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #7465 from chef/lcg/fix-dup-query-paramsTim Smith2018-07-131-1/+7
|\ \ | | | | | | Fix duplicated query parameters to resolve Chef::HTTP::Simple regression
| * | Fix duplicated query parametersLamont Granquist2018-07-131-1/+7
| |/ | | | | | | | | | | | | rubocop rule led to us mutating the argument to the constructor here and continuously appending query params. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #7379 from chef/lcg/fixing-array-argsTim Smith2018-07-1310-260/+263
|\ \ | |/ |/| Fixing array args in some unix providers
| * fix missing stubs for install_profileLamont Granquist2018-07-061-0/+2
| | | | | | | | | | | | otherwise we really shell_out to profile Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * rebase + squashLamont Granquist2018-07-0610-260/+261
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #7455 from coderanger/config-commandsTim Smith2018-07-133-0/+400
|\ \ | | | | | | Add knife config get/use-profile commands
| * | Fix a lingering rubocop issue.Noah Kantrowitz2018-07-111-28/+27
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | Feed the rubocop.Noah Kantrowitz2018-07-111-22/+23
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | A few more test cases.Noah Kantrowitz2018-07-111-0/+52
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | Use the right class for the reset.Noah Kantrowitz2018-07-112-2/+2
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | New `knife config list-profiles` command to show available profiles.Noah Kantrowitz2018-07-111-0/+136
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | Add two new knife commands for getting and setting the credentials profile name.Noah Kantrowitz2018-07-102-0/+212
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
* | | Merge pull request #7458 from chef/better_rehash_errorTim Smith2018-07-131-1/+1
|\ \ \ | | | | | | | | Provide a better error when knife plugins are missing from the cache
| * | | Provide a better error when knife plugins are missing from the cachebetter_rehash_errorTim Smith2018-07-111-1/+1
| |/ / | | | | | | | | | | | | | | | No one outside chef developers knows what the manifest is and we don't actually tell them what command to run. Leave the details out. Just tell them how to fix it. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #7457 from chef/require_the_right_shelloutTim Smith2018-07-124-4/+0
|\ \ \ | | | | | | | | Remove require mixlib/shellouts where not necessary
| * | | Remove require mixlib/shellouts where not necessaryrequire_the_right_shelloutTim Smith2018-07-104-4/+0
| |/ / | | | | | | | | | | | | | | | the dscl user provider uses mixin/shell_out instead and the specs don't seem to use mixlib/shellout or actually need the require. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #7445 from ↵Stuart Preston2018-07-121-0/+21
|\ \ \ | |/ / |/| | | | | | | | MsysTechnologiesllc/nimesh/MSYS-843/add_remove_account_right [MSYS-843] - Add remove_account_right function to win32/security
| * | [MSYS-843] -nimesh-msys2018-07-101-0/+21
| |/ | | | | | | | | | | | | - Added functionality 'remove_account_right' to remove the type of logon that a user account can perform. - Added rspec Signed-off-by: nimesh-msys <nimesh.patni@msystechnologies.com>
* | Attribute -> Property in additional placesTim Smith2018-07-103-12/+12
|/ | | | | | Specs and comments, but we should get it right in those places as well Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #7390 from coderanger/yet-more-credsLamont Granquist2018-07-032-1/+190
|\ | | | | knife config and a bunch of UX improvements
| * Merge branch 'master' into yet-more-credsNoah Kantrowitz2018-07-029-41/+37
| |\ | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * \ Merge branch 'master' into yet-more-credsNoah Kantrowitz2018-07-02383-8961/+9167
| |\ \ | | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | | Rename the command to `knife config get`.Noah Kantrowitz2018-06-281-3/+3
| | | | | | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | | Don't need this anymore.Noah Kantrowitz2018-06-241-4/+0
| | | | | | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | | Apparently the block argument is already in use with `knife()` even though I ↵Noah Kantrowitz2018-06-242-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | can't figure out quite how. Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | | Add tests for `knife config`.Noah Kantrowitz2018-06-232-1/+194
| | | | | | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
* | | | fix Style/MutableConstantLamont Granquist2018-07-0210-18/+18
| |_|/ |/| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | fix Style/PreferredHashMethodsLamont Granquist2018-07-028-38/+34
| | | | | | | | | | | | | | | | | | | | | absolutely hard requirement on the fixes that went into chef-config 2.2.11, so the floor of that gem is bumped up. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | fix Naming/HeredocDelimiterCaseLamont Granquist2018-07-021-3/+3
| |/ |/| | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Style/TrailingCommaInHashLiteralLamont Granquist2018-07-023-5/+5
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix some Style/StringLiterals introduced by the UnneededInterpolationLamont Granquist2018-07-021-8/+8
| | | | | | | | | | | | cop Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Style/UnneededInterpolationLamont Granquist2018-07-0217-43/+43
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Layout/LeadingCommentSpaceLamont Granquist2018-07-0252-129/+129
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | clean up whitespace againLamont Granquist2018-07-0227-242/+242
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Layout/DotPositionLamont Granquist2018-07-0247-641/+641
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Layout/AlignHash caused by Style/HashSyntaxLamont Granquist2018-07-021-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Layout/IndentHeredocLamont Granquist2018-07-02106-5915/+5915
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix Style/HashSyntaxLamont Granquist2018-07-02297-2409/+2409
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #7406 from chef/lcg/suppress-turdfileLamont Granquist2018-06-291-1/+2
|\ \ | | | | | | Suppress data_collector.json spec turd file
| * | Suppress data_collector.json spec turd fileLamont Granquist2018-06-291-1/+2
| |/ | | | | | | | | | | Our unit tests keep creating this file that dirties the repo Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #7380 from chef/sp/ffi-powershellTim Smith2018-06-281-1/+1
|\ \ | | | | | | Switch powershell_exec mixin to use FFI instead of COM
| * \ Merge branch 'master' into sp/ffi-powershellStuart Preston2018-06-233-13/+169
| |\ \ | | |/ | | | | | | Signed-off-by: <>
| * | Merge branch 'master' into sp/ffi-powershellStuart Preston2018-06-2038-542/+759
| |\ \ | | | | | | | | | | | | Signed-off-by: <>
| * | | Fix up tests for appveyorStuart Preston2018-06-191-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Stuart Preston <stuart@chef.io>