summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Chefstyle fixesTim Smith2018-03-072-3/+3
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove a few more provides and update the resolver specTim Smith2018-03-071-23/+18
| | | | | | We need to rethink this spec. The 1:1 mapping stuff doesn't seem like it has a lot of value. The portion below where we test 1:many mappings seem to be the value. I want to know the right thing mapped to package, service, or user on Debian XYZ. Signed-off-by: Tim Smith <tsmith@chef.io>
* Remove platfom restrictions in provides and don't require providersTim Smith2018-03-071-1/+1
| | | | | | Don't require providers in the resources since we map these automatically. Also remove or simplify the platform restrictions in the provides lines in the resources. We're not really getting anything from these the way we wire up resources. Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #6956 from chef/bffTim Smith2018-03-072-8/+6
|\ | | | | Rename bff provider to match its resource
| * Update the provider resolver specs for bff packagebffTim Smith2018-03-061-4/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Update the bff package specTim Smith2018-03-061-4/+4
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #6950 from chef/more_propertiesTim Smith2018-03-071-1/+1
|\ \ | | | | | | Convert more set_or_returns to proper properties
| * | Remove the nil user in execute specTim Smith2018-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | We're not longer initializing user to nil and instead we're letting property handle it. This user => nil statement isn't the actual test here, but was just a workaround for the funky behavior. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #6958 from jasonwbarnett/remove-old-explicit-provider-setThom May2018-03-071-2/+0
|\ \ \ | | | | | | | | Remove explicit setting of @provider and depend on ProviderResolver
| * | | Remove old way of being and depend on ProviderResolverJason Barnett2018-03-071-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as Indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
* | | | Merge pull request #6952 from chef/lcg/remove-deprecated-namespace-collisionsLamont Granquist2018-03-061-95/+0
|\ \ \ \ | | | | | | | | | | remove deprecated property namespace collisions
| * | | | remove deprecated proprety namespace collisionslcg/remove-deprecated-namespace-collisionsLamont Granquist2018-03-051-95/+0
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | require writing `new_resource.my_property` instead of just `my_property` in provider code. a surprise in this code was that methods directly on the resource are all injected into the provider, and we never deprecated that, because we didn't know about it. that makes `action_class {}` helpers unnecessary, but causes additional namespace pollution, but at least the methods declared in the resource will lose to DSL methods (i.e. `def execute` will not work). but that also means that resources which are injected into the DSL which overwrite resource methods in other cookbooks may break their use in that cookbooks providers/action_classes. we should probably deprecate that as well, but we didn't and people probably found this behavior and used it. i cleaned it up a bit and removed the methods on Chef::Resource directly which polluted the provider class with all kinds of bizzare crap methods (not_if and only_if were getting injected into the provider, etc). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Merge pull request #6938 from zfjagann/from_fileThom May2018-03-063-0/+87
|\ \ \ \ | | | | | | | | | | Added source_file to FromFile
| * | | | Added source_file to FromFileZeal Jagannatha2018-03-053-0/+87
| | |_|/ | |/| | | | | | | | | | | | | | | | | | This new field tracks the file from which the object was loaded. Signed-off-by: Zeal Jagannatha <zealjagannatha@gmail.com>
* | | | Avoid compile time error in apt_repositoryTim Smith2018-03-051-12/+0
| |/ / |/| | | | | | | | | | | | | | My previous PR to apt_repository introduced a bug where gpg keys couldn't validate. This converts a raise to an execute so it all happens during converge. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #6923 from chef/2k3Tim Smith2018-03-0513-65/+13
|\ \ \ | | | | | | | | Remove support for Windows 2003
| * | | Remove support for Windows 20032k3Tim Smith2018-03-0213-65/+13
| | | | | | | | | | | | | | | | | | | | | | | | Windows 2003 is fully end of life at this point and hasn't been supported by Chef for quite a while. EXTENDED support for Windows 2003 ended July 14, 2015. We avoid a good number of WMI queries by removing this support entirely. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Merge pull request #6896 from chef/tm/resource_inspectorThom May2018-03-051-0/+60
|\ \ \ \ | | | | | | | | | | add a utility to dump info about resources
| * | | | add a utility to dump info about resourcestm/resource_inspectorThom May2018-03-051-0/+60
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Thom May <thom@chef.io>
* | | | | Merge pull request #6914 from chef/lcg/no-fork-default-command-lineLamont Granquist2018-03-052-13/+137
|\ \ \ \ \ | | | | | | | | | | | | Don't use supervisor process for one-shot / command-line runs
| * | | | | windows does not support daemonizelcg/no-fork-default-command-lineLamont Granquist2018-03-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the option doesn't even exist due to it being omitted at class-parsing time. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | | fix legacy mode and legacy mode testsLamont Granquist2018-02-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | also more broadly applies the integration tests to legacy mode which was the original intent of the chef-solo tests in client_spec.rb here Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | | add an explicit check for --onceLamont Granquist2018-02-261-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | | Don't use supervisor process for one-shot / command-line runsLamont Granquist2018-02-262-13/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | without --interval we default to --no-fork, with --interval we default to running --fork. --once and --daemonize are handled before this code so they will also DTRT. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | | Merge pull request #6927 from chef/jcowie/poise-hoistThom May2018-03-051-2/+74
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Add attribute hoisting into core
| * | | | | Make sure before block of specs is calling correct methods now defensive ↵jcowie/poise-hoistJon Cowie2018-03-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | code removed Signed-off-by: Jon Cowie <jonlives@gmail.com>
| * | | | | Add attribute hoisting into coreJon Cowie2018-03-011-2/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit implements RFC-105 and adds specs to verify attribute hoisting is working correctly in conjunction with existing attributes. Signed-off-by: Jon Cowie <jonlives@gmail.com>
* | | | | | Merge pull request #6947 from chef/registry_keyLamont Granquist2018-03-051-1/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | registry_key: Properly limit allowed values for architecture
| * | | | | | registry_key: Properly limit allowed values for architectureTim Smith2018-03-041-1/+5
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Partially modernize registry_key resource. The main fix here is that we limit what symbols can be passed to the architecture property now where as before it was wide open. This will probably help a bit since the docs are a bit confusing and also enormous. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | | | Merge pull request #6903 from chef/portageThom May2018-03-051-5/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Modernize provides in the portage_package resource
| * | | | | Remove the provider check in the portage resourceportageTim Smith2018-02-261-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're not doing this in other resources and we let Chef handle it all with provides now Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | | | Merge pull request #6498 from chef/apt_repo_cleanupTim Smith2018-03-041-31/+108
|\ \ \ \ \ \ | | | | | | | | | | | | | | Apt repo cleanup and testing expansion
| * | | | | | Break out the gpg key validation into its own methodapt_repo_cleanupTim Smith2018-02-261-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This logic was entirely different than the key validation and doing them in the same block didn't make any sense. This makes it a lot easier to follow as well since there isn't the cmd variable that requires searching the code to see what we're actually running Signed-off-by: Tim Smith <tsmith@chef.io>
| * | | | | | Update specsTim Smith2018-02-261-30/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | | | | | Test is_ppa_url and repo_componentsTim Smith2018-02-261-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | | | | | Remove "should" wordingTim Smith2018-02-261-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | | | | | Test cookbook_name and key_type methodsTim Smith2018-02-261-1/+23
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | | | Add windows_feature, windows_feature_powershell, andTim Smith2018-03-023-0/+123
| |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | windows_feature_dism resources Ported from the windows cookbook 4.0 Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | | Remove the :uninstall action from chocolatey_package - CHEF-21remove_choco_uninstallTim Smith2018-02-281-13/+0
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | Remove the previously deprecated :uninstall action for chocolatey_package. This is noted in CHEF-21 Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Merge pull request #6916 from chef/lcg/fix-default-precedenceThom May2018-02-282-3/+67
|\ \ \ \ | | | | | | | | | | Stop mixlib-cli default clobbering mixlib-config settings
| * | | | Stop mixlib-cli default clobbering mixlib-config settingslcg/fix-default-precedenceLamont Granquist2018-02-262-3/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pre-14 precedence level is: 1. mixlib-cli setting 2. mixlib-cli default 3. mixlib-config setting 4. mixlib-config default This means that if an option has a mixlib-cli default that it cannot ever be set in the config file. This PR swaps 2+3 around: 1. mixlib-cli setting 2. mixlib-config setting 3. mixlib-cli default 4. mixlib-config default Now the mixlib-cli defaults still take precedence over mixlib-config defaults, but it is possible to set a value in config.rb if there's a mixlib-cli default setting (which creeps into the settings in hidden ways if you just use `boolean: true` in mixlib-cli). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | Merge pull request #6781 from linyows/notice-duplicated-ipThom May2018-02-271-0/+18
|\ \ \ \ \ | | | | | | | | | | | | Raise fatal error If FQDN duplicated
| * | | | | support behavior for duplicated_fqdns optionlinyows2018-02-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: linyows <linyows@gmail.com>
| * | | | | use skip_on_duplicated_fqdns as command optionlinyows2018-01-251-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: linyows <linyows@gmail.com>
| * | | | | to warning instead of fatal errorlinyows2018-01-251-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: linyows <linyows@gmail.com>
| * | | | | add testlinyows2018-01-241-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: linyows <linyows@gmail.com>
* | | | | | Merge pull request #6861 from smcavallo/bootstrap_preinstall_commandThom May2018-02-271-0/+12
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add support for knife bootstrap-preinstall-command
| * | | | | Add support for knife bootstrap-preinstall-commandS.Cavallo2018-02-151-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: S. Cavallo <smcavallo@hotmail.com>
* | | | | | Merge pull request #6767 from chef/windows_resourcesTim Smith2018-02-266-0/+268
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Add windows auto_run, font, pagefile, printer, printer_port, and shortcut resources
| * | | | | Add windows auto_run, font, pagefile, printer, printer_port, and shortcut ↵Tim Smith2018-02-236-0/+268
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | resources Ported from the Windows cookbook Signed-off-by: Tim Smith <tsmith@chef.io>