| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the target mode error in the case of no creds at all to:
```
FATAL: ArgumentError: Credentials file specified for target mode does not exist: '/Users/lamont/.chef/credentials'
```
From:
```
[2019-05-20T17:30:41-07:00] FATAL: NoMethodError: undefined method `[]' for nil:NilClass
```
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
| |
This will allow bootstrap to work with systems
that have `requiretty` configured, and is consistent
with the behavior of Chef 14 bootstrap
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes a few fixes:
1. properly handle the default value for session_timeout in cases where
merge_config is not called (plugins) to populate defaults.
2. verify that we're using the ssh protoocl before referencing ssh
constants.
3. capture and compare the higher-level Train::Error for the check
to see if we've gotten a missing fingerprint error, instead of using
Train::Transports::SSHFailed which may not be loaded when exception
is being evaluated.
4. Add tests for missing fingerprint behavior
5. do not save session_timeout to Chef::Config[:knife], it was not
referenced as knife config in any location and we're trying to move away
from pushing CLI values into knife config.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
|
|
|
|
|
| |
We're creating these dfs shares so it makes a lot more sense to make the action create. This is probably what people using Chef would expect.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|\
| |
| |
| |
| | |
MsysTechnologiesllc/VSingh/bootstrap-session-timeout
Chef 15: Add --session-timeout bootstrap option for both ssh & winrm
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We converted --winrm-session-timeout MINUTES
to --session-timeout SECONDS
If someone is providing a short session timeout, it's possible
that they're doing so based on the flag accepting minutes. We'll warn
them and suggest an alternative so that if things go wrong,
they'll know where to start looking.
We can remove this once we remove the deprecation for
winrm-session-timeout
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
We added default value for session-timeout, but the tests
weren't aware of that because config was mocked.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Add bootstrap option --session-timeout.
- Add wirnrm-session to deprecations.
- Default --session-timeout value is 60 secs(same was added for --winrm-session-timeout).
- Modify existing specs related to old winrm session timeout key and add specs for session timeout.
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
| |
| |
| |
| | |
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #8482 by prompting to continue if the host key is not recognized.
This attempts to tell Net:SSH to accept and write the key but it is only
temporarily accepting.
This changes the parameters of --ssh-verify-host-key (which is new) to
take the Net::SSH values, which get passed through by train. This allows
the user more options than only verifying or not.
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
|
|\
| |
| | |
[knife-ec2-547] Update config_source to support using knife classes without requiring merge_config
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This moves initialization of @original_config out of
merge_configs and into the constructor.
A common access pattern for plugins running knife commands is:
cmd = KnifeCommand.new
cmd.config[:something] = value
cmd.run
This bypasses the `Knife.run` class method, which does extra config
initialization - including merge_configs.
When that happens, `config_source` will now return `nil` as the
source instead of exploding.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
|\ \
| | |
| | | |
Use exports compatibile with /bin/sh in the bootstrap script
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
The bootstrap script is explicitly using /bin/sh.
On some solaris servers the version of /bin/sh exporting environment variables
using "export id=value" fails. The form "id=value export id" does work.
Bootstrap fails when the wrong form is used.
Signed-off-by: markgibbons <mark.gibbons@nordstrom.com>
|
|\ \
| | |
| | |
| | |
| | | |
MsysTechnologiesllc/Kapil/MSYS-996_Win32APIError_The_operation_completed_successfully
Fix for Chef::Exceptions::Win32APIError: The operation completed successfully.
|
| | |
| | |
| | |
| | | |
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
|
| |/
|/|
| |
| |
| |
| | |
Some shells interpret the '-' character in 'accept-no-persist'
Signed-off-by: tyler-ball <tball@chef.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Also updating the transmission of the license acceptance through the
config.rb because that brings it in line with existing patterns
(Test Kitchen).
Signed-off-by: tyler-ball <tball@chef.io>
|
|\ \
| | |
| | | |
Remove resource collision deprecations
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Switch to only doing warnings. Remove the features in the node_map that
we never used.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
MsysTechnologiesllc/Kapil/MSYS-986_Move_response_file_and_response_file_variables_out_of_base_package_resource
package: move response_file and response_file_variables out of base package resource
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
Fix for Move response_file and response_file_variables out of base package resource
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
update require changes
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
Updated require changes
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
Fixed some unit test cases
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: tyler-ball <tball@chef.io>
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
While I'm in here fix the validator default check
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|\ \ \
| | | |
| | | | |
Initial target_mode implementation
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Bryan McLellan <btm@chef.io>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Bryan McLellan <btm@chef.io>
|
|\ \ \ \
| |/ / /
|/| | | |
Add logic to require acceptannce of the Chef license to run the client
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
unstable -> current
Signed-off-by: tyler-ball <tball@chef.io>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Mark Anderson <mark@chef.io>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: tyler-ball <tball@chef.io>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Mark Anderson <mark@chef.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because in order to run `chef-client` on the bootstrapped node the user
needs to have accepted the licenses locally. Right now we have commented
out this code because we will enforce it in a different PR.
Signed-off-by: tyler-ball <tball@chef.io>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: tyler-ball <tball@chef.io>
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This adds a new feature to chef-client where users must accept the
EULA before using the product. Users can accept the license by
passing '--chef-license accept', setting ENV[CHEF_LICENSE]=accept or by
running 'chef-client' and following the interactive prompt.
Signed-off-by: tyler-ball <tball@chef.io>
|
|\ \ \
| | | |
| | | | |
Restore bootstrap pre-release support
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Updates BootstrapContext and WindowsBootstrapContext to
expect a 'channel' config value instead of a 'prelease' value.
This removes the old behavior of inferring pre-release (current) from
the presence of a fourth version number in the version string (eg
1.2.3.pre) - that was specific to gem installs, and gem installs are not
used in bootstrap.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This adds support for deprecating a boolean flag
into a non-boolean value, and uses it to make `--prerelease`
deprecated in favor of `--channel current`. By default,
`channel` is `stable`.
Separately, all deprecated options are now configured
to display at the end of the options list, instead of mixed into
the non-deprecated list.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If a value comes from CLI defaults, it will now return :cli_default.
This supports verifying deprecations when we need to know
if a value was actually supplied from the CLI, or if it was
defaulted from CLI options.
Since we have all of the original sources still available,
this also makes it so that we don't keep a separate hash
for tracking config source - we're just checking in the original
config sources in order that matches merge priority.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It was originally removed after discussion in community slack,
but it turns out to have a little more utility than we thought.
When enabled, it will cause the package to be downloaded from
the `current` channel.
Option description has been updated from 'install prerelease gem'
to 'install from current channel'.
This commit otherwise restores the original behavior and adds some tests.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
|\ \ \ \
| |_|/ /
|/| | | |
Fix for cron resource get confused by environment/property mismatch
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
can also be specified as a `property`
- Added unit test cases
- Ensured chefstyle
- Added a warning in case user is using a `environment` for an entry that can also be specified as a `property`
- Revert changes in order to pass chefstyle
- Added a warning in case user is using a `environment` for an entry that can also be specified as a `property`
- Added these changes in cron_different? method
- Added unit test cases
- Added some changes in cron.rb
- It now throws error if user passes both environment with the {:SHELL, :HOME, :PATH, :MAILTO} and these properties itself.
- It maintains idempotency.
- Added Rspecs for this case.
- Ensured chef-style.
Signed-off-by: vijaymmali1990 <vijay.mali@msystechnologies.com>
|
|\ \ \
| |/ /
|/| | |
Chef-15: cookbook compiler should parse only .rb files
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes #6281 which is a frequently reported issue where md files and swap
files and other junk causes the cookbook compiler to barf.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|\ \ \
| | | |
| | | | |
[CHEF-8432] Ensure default protocol is used properly. Use correct 'require' before accessing Net::SSH constants.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This also updates bootstrap to provide `non_interactive` as an option
to TrainConnector, instead of TrainConnector setting it behind the
scenes. Bootstrap uses non-interactive to ensure that we don't
get net/ssh prompts for password in case of password failure.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|