summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* add spec around node['class'] vs. node.class behaviorlcg/node-presenter-tweaksLamont Granquist2016-09-201-0/+7
| | | | | | we want attributes before methods Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* add another spec for chef_environmentLamont Granquist2016-09-201-1/+8
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* fix method_access and array handling in node presenterLamont Granquist2016-09-201-1/+8
| | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* clean up users left from terminated builds and use explicid UIDs and GIDsMatt Wrock2016-09-191-3/+11
|
* Make 12.5+ custom resources whyrun safe by default.John Keiser2016-09-161-1/+17
| | | | | | (This was always intended to be the case, and it's difficult to do it yourself. We have been teaching people whyrun-safe methods to make resources right alongside Custom Resources, as well.)
* Fix whitespace on EOMsJohn Keiser2016-09-161-43/+43
|
* Renamed supress_log_resource_count to count_log_resource_updatesnimisha2016-09-161-5/+5
|
* Removed update_resource_count attribute and added supress_log_resource_count ↵nimisha2016-09-162-20/+5
| | | | chef config
* Fixing travis issuesnimisha2016-09-162-4/+4
|
* Added specs for update_resource_count attributenimisha2016-09-162-0/+29
|
* Merge pull request #5330 from chef/lcg/derpLamont Granquist2016-09-151-1/+6
|\ | | | | derp fix for master breakage
| * derp fix for master breakagelcg/derpLamont Granquist2016-09-151-1/+6
| | | | | | | | | | | | thought this was green, but it was clearly red on appveyor/windows Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #5268 from ↵Bryan McLellan2016-09-152-17/+45
|\ \ | |/ |/| | | | | MsysTechnologiesllc/dh/registry_resource_idempotent_issue Fix for idempotent issue for some registry types in registry_key resource
| * Updated functional spec as per review commentdheerajd-msys2016-09-141-1/+2
| |
| * Added functional specs for registry keydheerajd-msys2016-09-131-0/+9
| |
| * Refactored specsdheerajd-msys2016-09-131-28/+36
| |
| * Added specs for registry_key resource idempotent issue fixdheerajd-msys2016-09-131-1/+11
| |
* | Merge pull request #5322 from chef/lcg/manage-home-fixLamont Granquist2016-09-153-6/+42
|\ \ | | | | | | revert supports[:manage_home] behavior
| * | suppress deprecation errors in testslcg/manage-home-fixLamont Granquist2016-09-152-0/+6
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | add tests for provider behaviorLamont Granquist2016-09-141-0/+12
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | revert supports[:manage_home] behaviorLamont Granquist2016-09-141-6/+24
| |/ | | | | | | | | | | | | even though i violently disagree that this is correct behavior and we're just going to break everyone in one massive go when we hit Chef 13. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | typofix [ci skip]Lamont Granquist2016-09-151-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | add tests and tweak codeLamont Granquist2016-09-151-9/+34
|/ | | | | | | also fixes the fact that we've been using @new_resource.name instead of @new_resource.path all along which was never what was intended. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Fixes GH-4955, allowing local gems with remote dependenciesJoseph (Jy) Yaworski2016-09-081-4/+2
|
* Merge pull request #5234 from ↵Bryan McLellan2016-09-072-0/+189
|\ | | | | | | | | MsysTechnologiesllc/ali/allow_symlink_directory_delete_on_windows Added code to handle deletion of directories on Windows that are symlinks.
| * Added functional RSpecs for the fix added here for symlink issue on windows.aliasgar162016-09-071-0/+34
| |
| * Fixed RuboCop issues.aliasgar162016-09-011-35/+35
| |
| * Added RSpecs for the fix.aliasgar162016-09-011-0/+155
| |
* | Merge pull request #5281 from coderanger/recipe_file_loadedNoah Kantrowitz2016-09-062-3/+45
|\ \ | | | | | | Hook up the recipe_file_loaded event which was defined but not actually called
| * | Thanks, Windows.Noah Kantrowitz2016-09-061-1/+3
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | Fix dispatcher tests.Noah Kantrowitz2016-09-061-2/+2
| | | | | | | | | | | | Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
| * | Hook up the recipe_file_loaded event which was defined but not actually called.Noah Kantrowitz2016-09-021-1/+41
| | | | | | | | | | | | | | | | | | | | | This also extends two of the recipe events to get the recipe name in addition to the path because that's usually useful for display. These arguments are both added at the end so the auto-magic argument trimmer will keep backwards compat. Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
* | | Merge pull request #5279 from chef/lcg/fix-solo-spec-testLamont Granquist2016-09-061-6/+11
|\ \ \ | | | | | | | | use threads to workaround Process.spawn buginess in chef-solo unit test
| * | | use threads to workaround Process.spawn buginesslcg/fix-solo-spec-testLamont Granquist2016-09-021-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | there's a WONTFIX closed bug in ruby-lang.org on this bug: https://bugs.ruby-lang.org/issues/10583 they seem to be favoring speed over accuracy with the result that if you're doing I/O synchronization (like our run_lock?) inside of a Process.spawn chain like this that you have to wrap the spawn calls inside of threads. probably a best practice to wrap every spawn call with a Thread. this probably also explains why we had the silly-long 20 second timeout? Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Merge pull request #5250 from ↵Bryan McLellan2016-09-061-0/+9
|\ \ \ \ | |/ / / |/| | | | | | | | | | | MsysTechnologiesllc/dh/add_timeout_during_package_removal Added timeout during removing of windows package
| * | | Added spec for Timeout function in Windows remove package codedheerajd-msys2016-09-061-0/+9
| | | |
* | | | tweak chef-solo run_lock timing testlcg/solo-test-loop-tweakingLamont Granquist2016-09-021-4/+4
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - fix the 'last' statements (my perl brain occassionally crops up in ruby code) and replace with a raise. of course this just swaps one exception for another, but this time its really intended to work this way. - swap the order of the expecations so that if we fails to see the waiting on the other process statement, but we blow up in both threads in the exception that was just added, we know we actually have a legit run_lock race condition that this code just found. does not fix this bug, just gets us a bit more information if it reoccurs. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Added fix for spaces in profile identifiers (#5159)Nate Walck2016-08-291-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added fix for spaces in profile identifiers * Added an attempt to test spaces in identifier names * Derp, bad merge * Fixed osx profile spec test
* | | Merge pull request #5248 from chef/lcg/linux-user-check-lockLamont Granquist2016-08-261-38/+19
|\ \ \ | | | | | | | | rewrite linux_user provider check_lock
| * | | add check for the centos why-run buglcg/linux-user-check-lockLamont Granquist2016-08-241-0/+3
| | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | rewrite linu_user provider check_lockLamont Granquist2016-08-241-38/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this removes the kinda brittle kinda insane parsing of the installed rpm version. now we're just less strict about the exit 1 code and fail on the output not being what is expected. this also likely fixes a bug in rhel in why-run mode where shell_out! would have failed on the user-not-found and raised an exception that would have ended the run. the code before certainly looks buggy. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Use symbols instead of strings as keys for systemd user property (#5241)Joshua Miller2016-08-262-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use symbols instead of strings as keys for systemd user property related funcs * Fix tests for provider/service/systemd for when user property is set * Change hash in systemctl_opts to use symbols instead of strings * Fix tests for chef/provider/systemd_unit.rb
* | | | Merge pull request #5249 from evan2645/use-upstart-goal-state-as-service-statusThom May2016-08-251-12/+27
|\ \ \ \ | | | | | | | | | | Use upstart goal state as service status
| * | | | Use upstart goal state as service statusEvan Gilman2016-08-241-12/+27
| |/ / / | | | | | | | | | | | | Solves #5204
* | | | Allow flagging a resource property as sensitiveadamleff/sensitive-propertiesAdam Leff2016-08-251-0/+20
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some properties in custom resources may include sensitive data, such as a password for a database server. When the Resource's state is built for use by Data Collector or similar auditing tool, `Chef::Resource#state_for_resource_reporter` builds a hash of all state properties for that resource and their values. This leads to sensitive data being transmitted and potentially stored in the clear. This change enhances properties with the ability to set an individual property as sensitive and then have the value of that property suppressed when exporting the Resource's state.
* | | remove homedirs not owned by userLamont Granquist2016-08-241-1/+1
| | | | | | | | | | | | | | | | | | | | | userdel -r will not remove a homedir not owned by the user, have to manually rm -rf it. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Merge pull request #5243 from chef/lcg/rewrite-linux-user-providerLamont Granquist2016-08-243-23/+27
|\ \ \ | | | | | | | | Rewrite linux useradd provider
| * | | remove homedir in beforelcg/rewrite-linux-user-providerLamont Granquist2016-08-231-0/+1
| | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | sort out the -m / -M mess a bit betterLamont Granquist2016-08-231-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | -M is not valid for usermod Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | add func spec for default and fix unit specsLamont Granquist2016-08-232-4/+9
| | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>