summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #7788 from chef/lcg/chef-15-shell-out-removalLamont Granquist2018-10-263-219/+1
|\ | | | | Do the shell_out deprecations for Chef-15.
| * remove more deprecated specsLamont Granquist2018-10-261-30/+0
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * more spec removallcg/chef-15-shell-out-removalLamont Granquist2018-10-261-56/+0
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Do the shell_out deprecations for Chef-15.Lamont Granquist2018-10-261-133/+1
| | | | | | | | | | | | | | | | Whoever wrote the what-to-do-in-Chef-15 notes did a pretty decent job of it, but the specs for the timeouts could have used a pointer into the code where the TODOs were located, I got lost there for a few minutes... Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Make all Chef 14 preview resources into full resourcesTim Smith2018-10-264-20/+0
|/ | | | | | These will now load and cookbook resources will not. Signed-off-by: Tim Smith <tsmith@chef.io>
* Add some retry/delay in HTTP functional testsSeth Chisamore2018-10-252-4/+4
| | | | | | | | We are seeing some failures when running the functional tests on our new Anka-based macOS testers. This small tweaks to the `Chef::Config` used in the specs fix the issues. Signed-off-by: Seth Chisamore <schisamo@chef.io>
* Fix the registry_key resource so the correct value is set when sensitive is trueJosh Barker2018-10-241-0/+74
| | | | Signed-off-by: Josh Barker <josh.barker.developer@gmail.com>
* Add support for localized system account to windows_task resourceAnton Kvashenkin2018-10-163-2/+3
| | | | Signed-off-by: Anton Kvashenkin <anton.jugatsu@gmail.com>
* Merge pull request #7753 from chef/lcg/fix-sticky-bitsTim Smith2018-10-161-1/+13
|\ | | | | File provider: fix sticky bits management / preservation
| * File provider: fix sticky bits management / preservationlcg/fix-sticky-bitsLamont Granquist2018-10-151-1/+13
| | | | | | | | | | | | | | | | | | Looks to be an at least 5 year old bug here dealing with how POSIX strips sticky bits off of files on a chown/chgrp. closes #7711 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #7752 from chef/lcg/deep-merge-cache-fixTim Smith2018-10-161-0/+33
|\ \ | |/ |/| Node Attributes: Build ImmutableMash properly in deep_merge!
| * Node Attributes: Build ImmutableMash properly in deep_merge!lcg/deep-merge-cache-fixLamont Granquist2018-10-151-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #7738 The root cause here is that there's a difference between doing Chef::Node::VividMash.new( <another VividMash> ) And: Chef::Node::ImmutableMash.new( <a VividMash> ) The former short circuits and does no work in convert_value. The latter will not short circuit and does the proper work to dup and convert the value argument. Since we build an ImmutableMash now, we do not need to wrap it with the extra immutablize() call. This should be perf neutral or very, very slightly better perf. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | When a property regex fails don't call it an optionbetter_regex_errorTim Smith2018-10-111-1/+1
|/ | | | | | These aren't options. These are properties. Signed-off-by: Tim Smith <tsmith@chef.io>
* Add the timezone resource from the timezone_lwrp cookbookTim Smith2018-10-091-0/+39
| | | | | | Adding this resource to core Chef with permission from @dragonsmith Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #7701 from chef/lcg/allow-downgrade-pseudo-defaultTim Smith2018-09-272-7/+15
|\ | | | | Change the allow_downgrade pseudo-default in the package provider superclass to true
| * fix package provider superclass specslcg/allow-downgrade-pseudo-defaultLamont Granquist2018-09-271-2/+10
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * fix rpm_package specsLamont Granquist2018-09-271-5/+5
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | sanitize inputs to Gem::Versionlcg/gem-version-sanitizationLamont Granquist2018-09-271-0/+22
|/ | | | | | | we know this may produce incorrect comparisons in some cases, but we never want it to fail. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* replace some instances of to_hash with to_hlcg/to-h-cleanupLamont Granquist2018-09-263-22/+22
| | | | | | | | | | | to_hash on a lot of these objects should go away, but even eliminating all our calls to to_hash on these objects internally is difficult. (e.g. converting the knife ui code to call #to_h means we wind up calling nil#to_h which "helpfully" becomes '{}' which is hilarious and i don't know why someone thought that was a good idea). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Work around rspec 3.8.0 issuesLamont Granquist2018-09-252-5/+6
| | | | | | | | | | | | | | | | | Problem is described in detail here: https://github.com/rspec/rspec-expectations/issues/1068#issuecomment-424580564 Note that this is self-inflicted damage and our pattern of having #to_hash on objects be called by #to_json and to produce a serialized 'flavor' of the object breaks what ruby's semantics are supposed to be and those should all be `#to_h` methods, and we should deprecate `#to_hash` but I imagine that will be a reasonably large breaking change (Although hopefully most of the use by users will be Node#to_hash which is entirely correct usage since that thing is actually a kind of glorified Hash-like monster). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Merge pull request #7677 from ↵Tim Smith2018-09-252-4/+13
|\ | | | | | | | | MsysTechnologiesllc/vasundhara/MSYS-888_Add_full_name_property_to_user_resource_for_windows Adds full_name property to user resource for Windows.
| * MSYS-888 Adds full_name property to user resource for Windows.vasu11052018-09-242-4/+13
| | | | | | | | Signed-off-by: vasu1105 <vasundhara.jagdale@msystechnologies.com>
* | add suse rspec testingdheerajd-msys2018-09-252-4/+3
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
* | functional test addeddheerajd-msys2018-09-2516-1/+244
| | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
* | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>dheerajd-msys2018-09-251-0/+43
|/ | | | | | | pick 3cf01debd fix for global options property pick af5cddaca added global_options property pick 7cc82d185 functional test added pick 3684cdb58 add suse rspec testing
* Move subversion properties out of scm and into subversionscmTim Smith2018-09-141-10/+0
| | | | | | This way we're not polluting the git resource with the subversion properties. Cleans up our docs generation a bit. I added some property descriptions while I was in there. Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge branch 'master' into feature/windows_ad_joinStuart Preston2018-09-1410-17/+97
|\
| * add locale resource to chefVincent AUBERT2018-09-111-0/+60
| | | | | | | | Signed-off-by: Vincent AUBERT <vincentaubert88@gmail.com>
| * Merge pull request #7551 from thechile/fix-cookbook-version-regexTim Smith2018-09-101-0/+20
| |\ | | | | | | Fix remote_directory does not obey removal of file specificity
| | * Add fix for filespecificity regexScott McGillivray2018-09-051-0/+20
| | | | | | | | | | | | Signed-off-by: Scott McGillivray <scott.mcgillivray@gmail.com>
| * | Properly capitalize PowerShell in descriptions and errorspowershellTim Smith2018-09-077-14/+14
| | | | | | | | | | | | | | | | | | It's PowerShell not Powershell. Our docs site had already been updated. Signed-off-by: Tim Smith <tsmith@chef.io>
| * | fix specs for deprecation shorteningLamont Granquist2018-09-051-3/+3
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Merge branch 'master' of https://github.com/chef/chef into ↵Derek Groh2018-09-0424-31/+1226
|\ \ \ | |/ / | | | | | | feature/windows_ad_join
| * | Merge pull request #7586 from chef/openssl_updatesTim Smith2018-08-243-8/+71
| |\ \ | | | | | | | | Add openssl_x509_crl resource and fix default modes in x509_certificate / x509_request
| | * | Fix the openssl unit testsopenssl_updatesTim Smith2018-08-243-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename the fixes Update the mode tests Signed-off-by: Tim Smith <tsmith@chef.io>
| | * | Add openssl_x509_crl resourceTim Smith2018-08-241-0/+61
| | |/ | | | | | | | | | | | | | | | This is another great resource added to the openssl cookbook by @juju482 at Institut National de l'Audiovisuel Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Simplify / fix our yard doc Rake taskTim Smith2018-08-231-1/+0
| |/ | | | | | | | | | | | | | | | | We were trying to parse out a readme file that doesn't exist and the license file which produced errors We namespaced the task in a way we don't do anywhere else. This matches our other gems now Tell people to use bundler in the errors instead of gem installing things We required rubygems which is not necessary Signed-off-by: Tim Smith <tsmith@chef.io>
| * switch shell_out to shell_out! in func testslcg/shell-out-mknodLamont Granquist2018-08-211-5/+5
| | | | | | | | | | | | not failing here hides issues caused by e.g. mknod not working properly. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * Merge pull request #7560 from dbresson/feature/repeated-options-systemd-unitTim Smith2018-08-201-1/+2
| |\ | | | | | | support repeated options in systemd_unit
| | * support repeated options in systemd_unitDavid Bresson2018-08-171-1/+2
| | | | | | | | | | | | Signed-off-by: David Bresson <dabresson@gmail.com>
| * | Merge pull request #7483 from ↵Tim Smith2018-08-202-0/+92
| |\ \ | | |/ | |/| | | | | | | MsysTechnologiesllc/dh/MSYS-854_support_task_on_battery Support for battery power options in windows_task resource
| | * added functional testdheerajd-msys2018-07-262-4/+88
| | | | | | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
| | * update for idempotent and test casedheerajd-msys2018-07-261-0/+8
| | | | | | | | | | | | Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
| * | Add specs for the x509_cert and x509_request resourcesopenssl_new_stuffTim Smith2018-08-162-0/+138
| | | | | | | | | | | | | | | | | | Fix the defaults that should be lazied and fix the duplicate class name I was using. Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add specs for the openssl mixinTim Smith2018-08-161-11/+616
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add unit tests for the EC public/private key resourcesTim Smith2018-08-152-0/+107
| | | | | | | | | | | | | | | | | | 95% the same as the rsa public/private key tests Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add a few specs to cron_manage and cron_dTim Smith2018-08-132-0/+62
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Fix the default action in the cron_access specTim Smith2018-08-131-1/+1
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add cron_d and cron_access resources from the cron cookbookTim Smith2018-08-132-0/+64
| | | | | | | | | | | | | | | | | | Cron_d was the #1 requested resource that we already had written. Everyone uses it and we should ship it. It's not a replacement for the existing cron cookbook, but just a different way of managing cron. If people want to manage the whole file or individual snippets we'll give them the option, just as we've always done by having the core resource and this resource. Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Merge pull request #7537 from ↵Tim Smith2018-08-131-3/+3
| |\ \ | | | | | | | | | | | | | | | | MsysTechnologiesllc/ash/MSYS-880_Fix_issue_of_setting_comment_for_windows_user Fix issue of setting comment for windows user