summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Ensure ssh search paginates correctlytm/fix_ssh_searchThom May2017-01-232-40/+38
| | | | | | Also use partial search for much small on-the-wire sizes Signed-off-by: Thom May <thom@chef.io>
* Merge pull request #5606 from chef/adamleff/warn-on-dangerous-property-namesThom May2017-01-181-2/+2
|\ | | | | Deprecate creating properties whose names are already methods
| * Deprecate creating properties whose names are already methodsadamleff/warn-on-dangerous-property-namesAdam Leff2017-01-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When creating a resource, a user can create a property that is the same name as an already-existing Ruby method, such as `#hash`. In the case of the `#hash` method, this can cause issues when attempting to adding resources to other data structures, such as Arrays or Hashes. In other examples, this could cause unexpected behavior that is incredibly difficult to troubleshoot. This change adds a deprecation warning in the case where a user adds a property to a resource that the resource instance already responds to. If y'all are OK with this approach, I'll be happy to write up the deprecation doc for this for docs.chef.io. Signed-off-by: Adam Leff <adam@leff.co>
* | Merge pull request #5726 from higanworks/compatible_with_net-ssh4Thom May2017-01-171-1/+1
|\ \ | | | | | | pass true as 2nd args for Net::SSH.configuration_for by default.
| * | pass true as 2nd args for Net::SSH.configuration_for by default.sawanoboly2017-01-161-1/+1
| | | | | | | | | | | | Signed-off-by: SAWANOBORI Yukihiko <sawanoboriyu@higanworks.com>
* | | Merge pull request #5539 from atward/remote_sftp_test_fixThom May2017-01-171-3/+3
|\ \ \ | | | | | | | | Correct SFTP remote_file tests
| * | | Correct SFTP remote_file testsAdam Ward2016-11-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Incorrectly tested 'ftp' scheme. Fixes: #4750 Obvious fix. Signed-off-by: Adam Ward <adamw@subdesigns.net>
* | | | Merge pull request #5313 from ↵Thom May2017-01-171-3/+3
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | juliandunn/aix_candidate_version_blindly_checks_source Don't blindly check source on candidate_version calls.
| * | | Don't blindly check source on candidate_version calls.Julian C. Dunn2016-12-051-3/+3
| | | | | | | | | | | | | | | | Signed-off-by: Julian C. Dunn <jdunn@chef.io>
* | | | fix node attribute "unless" API methodsLamont Granquist2017-01-111-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #5556 corrects behavior to 12.11.x behavior which was lost in the refactor may address #5715 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Merge pull request #4894 from chef/lcg/dnf-providerLamont Granquist2017-01-1116-0/+860
|\ \ \ \ | | | | | | | | | | DNF Provider PR #2
| * | | | add some idempotency checksLamont Granquist2016-12-161-1/+21
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | fix FIXME in define_resource_requirementsLamont Granquist2016-12-151-0/+14
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | review feedback plus break out helper classLamont Granquist2016-12-152-4/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | refactor to use array indexes instead of package_namesLamont Granquist2016-12-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes arch array support. pretty sure that my "helpfully" compacting out nils from the names and versions passed to install_package / remove_package was a design flaw now. all of the helpers i've created to translate from package_name to various arrays also assumes the package_name is a unique identifier which is what was going wrong here, and is wrong. best to just have all the arrays indexed the same. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add some arch testing, fix a local install testLamont Granquist2016-12-131-1/+81
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | get versions working as well as possibleLamont Granquist2016-12-131-0/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add srpms to repoLamont Granquist2016-12-132-0/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add failing specs for versionLamont Granquist2016-12-131-0/+36
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | test the property works as wellLamont Granquist2016-12-131-0/+18
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | arches were legit busted, fixing add a couple testsLamont Granquist2016-12-131-1/+27
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | few more tests for when there's no candidate versionsLamont Granquist2016-12-131-0/+29
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | roll back :install doing upgrades or downgrades, it shouldn'tLamont Granquist2016-12-131-15/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dunno what i was thinking. add some more testing as well. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | fix and test :install and :upgrade source arg idempotencyLamont Granquist2016-12-131-0/+16
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | fix deprecation warning spec failureLamont Granquist2016-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | fix downgrades with local source using :installLamont Granquist2016-12-131-1/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add more tests and work around superclass firing off deprecationsLamont Granquist2016-12-131-0/+39
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | support source property and local installsLamont Granquist2016-12-131-275/+291
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | fix deprecation warning testsLamont Granquist2016-12-131-0/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add tests and deprecation for allow_downgradeLamont Granquist2016-12-131-1/+35
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add dnf resource unit specLamont Granquist2016-12-131-0/+100
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | add flush_cache and fix yum'sLamont Granquist2016-12-131-0/+20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | squashing dnf workLamont Granquist2016-12-1312-0/+366
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | Fix failing useradd test for rhel6 on s390x platformjsinha/fix_rhel67_testsJaymala Sinha2017-01-051-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | usermod -U for user with empty password on Rhel6 zlinux systems exits with error message. Updating the test for this behavior Signed-off-by: Jaymala Sinha <jsinha@chef.io>
* | | | | Fixed Review Commentsnimisha2017-01-051-2/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: nimisha <nimisha.sharad@clogeny.com>
* | | | | Added specs and fixed existing specsVasu11052016-12-292-19/+31
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
* | | | | Merge pull request #5668 from chef/afiune/COOL-642/dont-report-sensitive-dataSalim Afiune2016-12-221-0/+24
|\ \ \ \ \ | | | | | | | | | | | | Report a blank resource if sensitive is enabled
| * | | | | Create a new blank Resource instead of transforming itSalim Afiune2016-12-221-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Salim Afiune <afiune@chef.io>
| * | | | | Transform sensitive resources before report themSalim Afiune2016-12-221-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | COOL-642/ZD 12936 - Chef Manage Run History compromises sensitive data Before this commit we were sending sensitive resource information to Reporting and therefor you were able to see the sensitive data on the Run History in the Chef Manage Console. This commit is fixing this problem and now it is transforming any sensitive resource to display the word `*sensitive*` instead of the actual data. As we are inserting this values directly to the data base, it means that this change will cascade all the way to the front-end. Catch: Old data that was already reported and is displaying sensitive data will contineu to be displayed. Apologize. Signed-off-by: Salim Afiune <afiune@chef.io>
* | | | | | fix dscl group provider func breakageLamont Granquist2016-12-221-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | i didn't fully grok the way the dscl providers were written and only half fixed the group dscl provider, but later did a better job fixing the user one. fixes the breakage caught in the dscl group func tests. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | | cleanup of ifconfig and route providerslcg/route-ifconfigLamont Granquist2016-12-225-80/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * run_command elimination * shell_out array usage * other misc cleanup Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | | user provider cleanupLamont Granquist2016-12-225-109/+108
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * removes more run_command * converts to shell_out_compact * some other misc style cleanup Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | cleanup of group providerlcg/group-provider-cleanupLamont Granquist2016-12-217-73/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - consistent use of shell_out_compact! - remove more uses of run_command - some other code cleanup Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | fix unnecessary quoting of argslcg/deprecate-run-commandLamont Granquist2016-12-201-2/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | fix groupadd specs and modernizeLamont Granquist2016-12-201-22/+23
| |_|_|/ |/| | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Merge pull request #5630 from ↵Adam Leff2016-12-161-0/+7
|\ \ \ \ | |/ / / |/| | | | | | | | | | | chef/adamleff/ipo-500/fix-data-collector-org-parsing Fix Data Collector organization parsing regex
| * | | Fix Data Collector organization parsing regexAdam Leff2016-12-071-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The regex used to pluck the Chef Server Organization from the chef_server_url config value did not permit hyphens in org names even though they are allowed by Chef Server. This caused org names to get incorrectly truncated when sending the payload to Data Collector servers. Re: Chef bug IPO-500 Signed-off-by: Adam Leff <adam@leff.co>
* | | | Use object ID when detected unprocessed Resources (#5604)Adam Leff2016-12-121-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use object ID when detected unprocessed Resources In the Data Collector, when detecting unprocessed resources, a Set was built up using the resource object itself as the Set element. Internally, Set adds this to a Hash. We allow users to create custom resources that could contain a property named "hash" which in turn wires up a `#hash` instance method on the Resource. Ruby expects object's `#hash` method to return a Fixnum that it uses internally. So if a resource had a "hash" property that returned a String, bad things happened. With this change, we make our own Hash and use the resource's object ID in the key so we don't have to worry about the resource's `#hash` method getting called and throwing an exception. I will send up a separate change that warns users when they choose a property name that is already an existing method name. Fixes #5565. Signed-off-by: Adam Leff <adam@leff.co>
* | | | Merge pull request #5631 from chef/lcg/deprecate-chef-platform-methodsLamont Granquist2016-12-0914-6/+22
|\ \ \ \ | |/ / / |/| | | Properly deprecate old Chef::Platform methods
| * | | fix windows testslcg/deprecate-chef-platform-methodsLamont Granquist2016-12-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | dsc_script provider needs os defined. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
View Lorry Controller Status