summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #9544 from pschaumburg/ps/windows_firewall_rule-reworkTim Smith2020-04-041-47/+82
|\ | | | | windows_firewall_rule: Fix idempotency and add icmp_type property
| * Merge branch 'master' into ps/windows_firewall_rule-reworkPatrick Schaumburg2020-04-033-30/+173
| |\
| * | remove unused testsPatrick Schaumburg2020-04-011-78/+0
| | | | | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | Merge branch 'master' into ps/windows_firewall_rule-reworkPatrick Schaumburg2020-04-0111-41/+410
| |\ \
| * | | add some more testsPatrick Schaumburg2020-03-301-7/+23
| | | | | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | | changing unit tests for methodPatrick Schaumburg2020-03-301-42/+14
| | | | | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | | redo unit checks for is_set_properly?Patrick Schaumburg2020-03-301-28/+57
| | | | | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | | fix linting errors + add unit test for is_set_properly? methodPatrick Schaumburg2020-03-301-0/+61
| | | | | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | | fix test for groupPatrick Schaumburg2020-03-271-2/+2
| | | | | | | | | | | | | | | | Signed-off-by: Patrick Schaumburg <pschaumburg@tecracer.de>
| * | | fix wrong property names again in testsPatrick Schaumburg2020-03-271-13/+3
| | | |
| * | | fix wrong property name in testsPatrick Schaumburg2020-03-271-2/+2
| | | |
| * | | remove space in test as it should not be therePatrick Schaumburg2020-03-271-4/+4
| | | |
| * | | add and change testsPatrick Schaumburg2020-03-271-45/+90
| | | |
* | | | Implement eager_load_libraries metadata optionLamont Granquist2020-04-035-40/+198
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implements RFC-40 from the old chef rfc repo: https://github.com/chef-boneyard/chef-rfc/blob/master/rfc040-on-demand-cookbook-libraries.md Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Change name_property to be identity and not desired_state by defaultLamont Granquist2020-04-022-13/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If no other property is an identity property then the name_property is the default identity property. The name_property is also marked as not being desired state by default (the 'name' should never change). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | remove redundant identityLamont Granquist2020-04-021-0/+3
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | name_property implies identity if there is no other identity property this has been the behavior for a very long time, dunno why #4282 was never closed. closes #4282 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Merge pull request #9562 from chef/lcg/after-resourceTim Smith2020-04-023-30/+173
|\ \ \ | |_|/ |/| | Add after_resource to pair with current_resource
| * | remove duping for load_current_value and code duplicationlcg/after-resourceLamont Granquist2020-03-311-2/+3
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | Add after_resource to pair with current_resourceLamont Granquist2020-03-312-28/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For custom resources which correctly implement load_current_value the new after_resource comes for "free" and load_current_value will be called twice to load the current_resource (should be renamed the "before_resource" but that ship sailed) and then the after_resource. Appropriate wiring is added for a new event and capturing that into the action_collection and then the data_collector. The resource_reporter has not and will not be updated. For old style resources which are difficult to convert to custom resources (thinking here particularly of the 1:N model of the service resource in core chef, or stuff that just may be a lot of work like the file resource) then they can override the load_after_resource to manually wire up their own after_resource. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Fix functional tests on Windows 10 by matching lessBryan McLellan2020-03-311-4/+4
|/ / | | | | | | | | | | | | | | | | | | | | | | Windows 10 1909 is a service pack, but without being called a service pack. 1909 is a very small update over 1903, and in fact most of the binaries are not rebuilt. The version for 1909 is 10.0.18363, but the version in many files is still 10.0.18362, which was the version for 1903. This caused this functional test to fail on 1909 because 10.0.18362 != 10.0.18363. Nowhere else are we concerned with the file versions matching the OS version, so the fix is to match less of the version. By matching only '10.0', we should not see this again. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
* | Fix failing specsTim Smith2020-03-311-2/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Handle scenario where no value found in the updateTim Smith2020-03-311-1/+31
| | | | | | | | | | | | Also add a pile of specs Signed-off-by: Tim Smith <tsmith@chef.io>
* | Add testing of the xcode CLI detection plist parsingTim Smith2020-03-313-11/+133
| | | | | | | | | | | | Use the data files from the macos cookbook Signed-off-by: Tim Smith <tsmith@chef.io>
* | Switch the array format of shell_out and add a testTim Smith2020-03-311-1/+25
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Skip the ifconfig functional tests if we don't have ifconfignet-toolsTim Smith2020-03-273-3/+9
| | | | | | | | | | | | I'm looking at you Ubuntu 20.04 Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #9480 from chef/fix-clear-sourcesTim Smith2020-03-273-31/+216
|\ \ | | | | | | Fix unintuitive behavior of sources on gem resources
| * | Fix chefstyle violation.Pete Higgins2020-03-231-1/+1
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Make include_default_source nil by default and change implied logic.Pete Higgins2020-03-231-12/+119
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Clear sources if either a source or rubygems_url is set.Pete Higgins2020-03-231-1/+21
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Switch to canonical "https://rubygems.org" URL for rubygems.Pete Higgins2020-03-232-21/+21
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Change the default value for :rubygems_url to be nil.Pete Higgins2020-03-231-8/+8
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Move clear_sources? helper from resource to provider.Pete Higgins2020-03-232-38/+45
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Update gem_package to make clear_sources opt-out.Pete Higgins2020-03-232-6/+57
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
| * | Default clear_sources to nil for chef_gem and gem_package.Pete Higgins2020-03-231-2/+2
| | | | | | | | | | | | Signed-off-by: Pete Higgins <pete@peterhiggins.org>
* | | Merge pull request #9524 from ↵Tim Smith2020-03-271-1/+3
|\ \ \ | |_|/ |/| | | | | | | | MsysTechnologiesllc/sangmeshA/Fix_windows_share_cannot_modify_frozen_String Fixed windows share cannot modify frozen string bug
| * | Required specs updatedsanga172020-03-261-3/+1
| | | | | | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
| * | Specs added for freezed string and cloned stringsanga172020-03-241-0/+4
| | | | | | | | | | | | Signed-off-by: sanga17 <sausekar@msystechnologies.com>
* | | Improve chef_client_* resourcesTim Smith2020-03-252-6/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add new accept_chef_license property - Wire up config_directory property in chef_client_cron to match the chef_client_scheduled_task behavior - Add run_on_battery property to chef_client_scheduled_task - Move logic into helpers in chef_client_schedule_task - Add more testing to chef_client_scheduled_task Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #9531 from chef/fix_windows_buildsTim Smith2020-03-241-1/+1
|\ \ \ | | | | | | | | Switch to RUBY_PLATFORM for the windows check
| * | | Switch to RUBY_PLATFORM for the windows checkfix_windows_buildsTim Smith2020-03-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Merging in this check broke the build tests on Windows hosts. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Merge pull request #9528 from chef/chef_client_windows_taskTim Smith2020-03-241-0/+70
|\ \ \ \ | | | | | | | | | | Add chef_client_windows_task resource from chef-client cookbook
| * | | | Add chef_client_windows_task resource from chef-client cookbookchef_client_windows_taskTim Smith2020-03-241-0/+70
| |/ / / | | | | | | | | | | | | | | | | | | | | Allow setting up chef-client to run as a scheduled task out of the box. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | | Add :https_for_ca_consumer property to rhsm_register resourceJason Barnett2020-03-241-0/+24
|/ / / | | | | | | | | | Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
* | | Set append_log_file property to true by defaultchef_client_cronTim Smith2020-03-241-8/+8
| | | | | | | | | | | | | | | | | | This is from a convo in slack where it was determined that we can safely append due to log rotation that occurs in mixlib-log Signed-off-by: Tim Smith <tsmith@chef.io>
* | | If append_log_file is set then use the -L flagTim Smith2020-03-241-1/+1
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Validate that splay values are positiveTim Smith2020-03-231-2/+11
| | | | | | | | | | | | | | | | | | Add some tests for this and fix the naming of other tests Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Use random to ensure we have a splay sleep time in rangeTim Smith2020-03-231-9/+9
| | | | | | | | | | | | | | | | | | The previous method was resulting in wildly out of range times. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Fix some bugs in command generation and add specsTim Smith2020-03-231-0/+36
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Initial commit of unit testsTim Smith2020-03-231-0/+64
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #9522 from chef/cron_validationsTim Smith2020-03-235-91/+101
|\ \ \ | |_|/ |/| | Move cron_d validation methods to a helper and use that in the cron resource